From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Date: Fri, 19 May 2023 21:14:27 +0300 Organization: LINKOV.NET Message-ID: <86lehk9ojh.fsf@mail.linkov.net> References: <875yapvoxh.fsf@fastmail.com> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> <86lejajex8.fsf@mail.linkov.net> <86h6t3q3nt.fsf@mail.linkov.net> <86ttwckwqf.fsf@mail.linkov.net> <861qjgkvui.fsf@mail.linkov.net> <0c52f6ed-c3e2-6d9e-6d57-6f3779257b25@gmx.at> <86ilcqnbsp.fsf@mail.linkov.net> <3a021a53-814d-3721-31fb-b77f4087a455@gmx.at> <86wn153b43.fsf@mail.linkov.net> <2b1dade6-740f-6add-b6f0-4677a1c09789@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34607"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 62427@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 19 20:17:36 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q04fX-0008p4-N4 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 May 2023 20:17:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q04f3-00051J-Du; Fri, 19 May 2023 14:17:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q04f0-00050h-Ox for bug-gnu-emacs@gnu.org; Fri, 19 May 2023 14:17:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q04f0-0001uE-H5 for bug-gnu-emacs@gnu.org; Fri, 19 May 2023 14:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q04f0-0008PD-A2 for bug-gnu-emacs@gnu.org; Fri, 19 May 2023 14:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 May 2023 18:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs Original-Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.168452021332292 (code B ref 62427); Fri, 19 May 2023 18:17:02 +0000 Original-Received: (at 62427) by debbugs.gnu.org; 19 May 2023 18:16:53 +0000 Original-Received: from localhost ([127.0.0.1]:57375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q04eq-0008Om-LG for submit@debbugs.gnu.org; Fri, 19 May 2023 14:16:52 -0400 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:47421) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q04el-0008Nw-Ip for 62427@debbugs.gnu.org; Fri, 19 May 2023 14:16:47 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 465C9E0009; Fri, 19 May 2023 18:16:40 +0000 (UTC) In-Reply-To: <2b1dade6-740f-6add-b6f0-4677a1c09789@gmx.at> (martin rudalics's message of "Fri, 19 May 2023 09:31:48 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262021 Archived-At: >> + (when (minibufferp) (select-window (get-mru-window))) > > Here and below I'd use > > (when (window-minibuffer-p) > > because it more clearly demonstrates the idea and also handles the > (unlikely) case where a minibuffer is shown in a normal window. Thanks, now pushed to emacs-29. >> (window-state-put ws nil 'safe))) >> >> ;; Select the minibuffer when it was active before switching tabs >> @@ -1575,8 +1575,7 @@ tab-bar-new-tab-to >> >> (when tab-bar-new-tab-choice >> ;; Handle the case when it's called in the active minibuffer. >> - (when (minibuffer-selected-window) >> - (select-window (minibuffer-selected-window))) >> + (when (minibufferp) (select-window (get-mru-window))) >> (let ((ignore-window-parameters t) >> (window--sides-inhibit-check t)) >> (if (eq tab-bar-new-tab-choice 'clone) > > You might want to try this with multiple frames (some of them without > their own minibuffer window) jumping from one frame to another within > the scope of 'read-from-minibuffer'. I confirm that this works correctly.