bug#65094: 30.0.50; '/ u' is missing in menu bar under Package

bug#65094: 30.0.50; '/ u' is missing in menu bar under Package

[Arash Esbati]

Hi all,

is there a specific reason why `package-menu-filter-upgradable' bound to
'/ u' is missing in package menu under "Package -> Filter packages"?
All other filtering commands described in the manual[1] are available
there.

`package-menu-filter-upgradable' was added with commit 8c96c720fa.

Best, Arash

Footnotes:
[1]  https://www.gnu.org/software/emacs/manual/html_node/emacs/Package-Menu.html

bug#65094: 30.0.50; '/ u' is missing in menu bar under Package

[Eli Zaretskii]

> From: Arash Esbati <arash@gnu.org>
> Date: Sat, 05 Aug 2023 14:14:41 +0200
> 
> is there a specific reason why `package-menu-filter-upgradable' bound to
> '/ u' is missing in package menu under "Package -> Filter packages"?
> All other filtering commands described in the manual[1] are available
> there.

No reason.  Feel free to submit a patch to add that, but please do it
for the emacs-29 branch (as I believe that command exists in Emacs 29
as well).

Thanks.

bug#65094: 30.0.50; '/ u' is missing in menu bar under Package

[Arash Esbati]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> No reason.  Feel free to submit a patch to add that, but please do it
> for the emacs-29 branch (as I believe that command exists in Emacs 29
> as well).

Yes, that command was introduced with Emacs 28.1, IIUC.  Please find
attached a patch against the emacs-29 branch.

Best, Arash

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Filter-packages-available-for-upgrade-via-menu-bar.patch --]
[-- Type: text/x-patch, Size: 1265 bytes --]

From 25b9fe55dd8813c09b9af7ec998b91a07671bd32 Mon Sep 17 00:00:00 2001
From: Arash Esbati <arash@gnu.org>
Date: Sat, 5 Aug 2023 17:39:32 +0200
Subject: [PATCH] ; Filter packages available for upgrade via menu bar

* lisp/emacs-lisp/package.el (package-menu-mode-menu): Add entry
to filter packages available for upgrade via menu bar.  (bug#65094)
---
 lisp/emacs-lisp/package.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 58ca19f7fe2..c17703afde9 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -3090,6 +3090,8 @@ package-menu-mode-menu
      ["Filter by Name or Description" package-menu-filter-by-name-or-description
       :help "Filter packages by name or description"]
      ["Filter by Status" package-menu-filter-by-status :help "Filter packages by status"]
+     ["Filter by Upgradeability" package-menu-filter-upgradable
+      :help "Filter packages by upgradeability"]
      ["Filter by Version" package-menu-filter-by-version :help "Filter packages by version"]
      ["Filter Marked" package-menu-filter-marked :help "Filter packages marked for upgrade"]
      ["Clear Filter" package-menu-clear-filter :help "Clear package list filter"])
-- 
2.41.0

bug#65094: 30.0.50; '/ u' is missing in menu bar under Package

[Eli Zaretskii]

> From: Arash Esbati <arash@gnu.org>
> Cc: 65094@debbugs.gnu.org
> Date: Sat, 05 Aug 2023 17:46:05 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > No reason.  Feel free to submit a patch to add that, but please do it
> > for the emacs-29 branch (as I believe that command exists in Emacs 29
> > as well).
> 
> Yes, that command was introduced with Emacs 28.1, IIUC.  Please find
> attached a patch against the emacs-29 branch.

Thanks, but can we make the help-echo string a bit more helpful, by
not just repeating what the item's name says?  What does it mean "by
upgradeability" -- does it mean only packages that can be upgraded
will be shown? if so, let's say so.

(Yes, I know the other help-echo are also of this kind, but that
doesn't mean they are a good example to follow...)

bug#65094: 30.0.50; '/ u' is missing in menu bar under Package

[Arash Esbati]

[-- Attachment #1: Type: text/plain, Size: 1487 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> Thanks, but can we make the help-echo string a bit more helpful, by
> not just repeating what the item's name says?  What does it mean "by
> upgradeability" -- does it mean only packages that can be upgraded
> will be shown? if so, let's say so.
>
> (Yes, I know the other help-echo are also of this kind, but that
> doesn't mean they are a good example to follow...)

My choice was driven solely by symmetry to the other entries.  Maybe
something like this:

--8<---------------cut here---------------start------------->8---
diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 58ca19f7fe2..83c7380553d 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -3090,6 +3090,8 @@ package-menu-mode-menu
      ["Filter by Name or Description" package-menu-filter-by-name-or-description
       :help "Filter packages by name or description"]
      ["Filter by Status" package-menu-filter-by-status :help "Filter packages by status"]
+     ["Filter by Upgrades available" package-menu-filter-upgradable
+      :help "Filter packages by available upgrades"]
      ["Filter by Version" package-menu-filter-by-version :help "Filter packages by version"]
      ["Filter Marked" package-menu-filter-marked :help "Filter packages marked for upgrade"]
      ["Clear Filter" package-menu-clear-filter :help "Clear package list filter"])
--8<---------------cut here---------------end--------------->8---

Best, Arash


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Filter-packages-available-for-upgrade-via-menu-bar.patch --]
[-- Type: text/x-patch, Size: 1273 bytes --]

From f67aeefef1e04ccd3c2cca1d1be4747a1f2f3107 Mon Sep 17 00:00:00 2001
From: Arash Esbati <arash@gnu.org>
Date: Sat, 5 Aug 2023 17:39:32 +0200
Subject: [PATCH] ; Filter packages available for upgrade via menu bar

* lisp/emacs-lisp/package.el (package-menu-mode-menu): Add entry
to filter packages available for upgrade via menu bar.  (bug#65094)
---
 lisp/emacs-lisp/package.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
index 58ca19f7fe2..83c7380553d 100644
--- a/lisp/emacs-lisp/package.el
+++ b/lisp/emacs-lisp/package.el
@@ -3090,6 +3090,8 @@ package-menu-mode-menu
      ["Filter by Name or Description" package-menu-filter-by-name-or-description
       :help "Filter packages by name or description"]
      ["Filter by Status" package-menu-filter-by-status :help "Filter packages by status"]
+     ["Filter by Upgrades available" package-menu-filter-upgradable
+      :help "Filter packages by available upgrades"]
      ["Filter by Version" package-menu-filter-by-version :help "Filter packages by version"]
      ["Filter Marked" package-menu-filter-marked :help "Filter packages marked for upgrade"]
      ["Clear Filter" package-menu-clear-filter :help "Clear package list filter"])
-- 
2.41.0

bug#65094: 30.0.50; '/ u' is missing in menu bar under Package

[Eli Zaretskii]

> From: Arash Esbati <arash@gnu.org>
> Cc: 65094@debbugs.gnu.org
> Date: Sat, 05 Aug 2023 22:06:14 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Thanks, but can we make the help-echo string a bit more helpful, by
> > not just repeating what the item's name says?  What does it mean "by
> > upgradeability" -- does it mean only packages that can be upgraded
> > will be shown? if so, let's say so.
> >
> > (Yes, I know the other help-echo are also of this kind, but that
> > doesn't mean they are a good example to follow...)
> 
> My choice was driven solely by symmetry to the other entries.  Maybe
> something like this:

Thanks, installed.  But what I had in mind is the kind of changes I
made in the followup commit, please take a look.

Closing the bug.

bug#65094: 30.0.50; '/ u' is missing in menu bar under Package

[Arash Esbati]

Eli Zaretskii <eliz@gnu.org> writes:

> Thanks, installed.  But what I had in mind is the kind of changes I
> made in the followup commit, please take a look.

Ah, you were thinking about revamping the whole thing.  Sorry, I didn't
get it.  Thanks for fixing this.

Best, Arash

bug#65094: 30.0.50; '/ u' is missing in menu bar under Package

[Eli Zaretskii]

> From: Arash Esbati <arash@gnu.org>
> Cc: 65094@debbugs.gnu.org
> Date: Sun, 06 Aug 2023 12:11:24 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Thanks, installed.  But what I had in mind is the kind of changes I
> > made in the followup commit, please take a look.
> 
> Ah, you were thinking about revamping the whole thing.

Yes, but from you I wanted only the one for the single filter you
added.  I find "Filter packages by available upgrades" not very
useful, since it just says what the menu-item's name says anyway.