From: Eli Zaretskii <eliz@gnu.org>
To: Vladimir Kazanov <vekazanov@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] User-defined fringe tooltips (a request for review)
Date: Sun, 07 Apr 2024 21:40:34 +0300 [thread overview]
Message-ID: <86le5pyq1p.fsf@gnu.org> (raw)
In-Reply-To: <CAAs=0-3XMjCrXHpVHqiwR+rMdSmgeKp18oP0aOYC4Kk-Gc4DCQ@mail.gmail.com> (message from Vladimir Kazanov on Sun, 7 Apr 2024 18:07:31 +0100)
> From: Vladimir Kazanov <vekazanov@gmail.com>
> Date: Sun, 7 Apr 2024 18:07:31 +0100
> Cc: emacs-devel@gnu.org
>
> 1. Use the iterator it used in the display_line function to extract
> tooltips from fringe-related display specs (patch v1). This needs
> caching Lisp_Objects in glyph_row structures for future retrieval.
> This is good because it looks in all specs everywhere, doesn't matter
> if the text is visible or not. Bad because it needs storing additional
> non-text values in glyph_row.
> 2. Iterating over buffer text positions of the row (patch v2). Hard to
> take into account all variants of text coming from buffers and
> strings. This implementation only finds fringe-help in visible text of
> the buffer.
> 3. Iterating of glyphs of the row (patch v3). All visible text, both
> from the buffer and strings, is visited by the implementation.
>
> I'd say that option 1 is best for user code as specs are retrieved uniformly.
But it has a disadvantage of storing Lisp objects in the glyph row
structure (which means basically to store them in the glyph matrices).
I'd like to avoid that.
> Option 3 is the cleanest implementation-wise but we'd have to document
> limitations and the suggested solution.
>
> So if you're fine with this approach, I'll clean up the documentation
> and provide a final patch based on option 3.
Yes, please.
next prev parent reply other threads:[~2024-04-07 18:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 19:38 [PATCH] User-defined fringe tooltips (a request for review) Vladimir Kazanov
2023-12-20 12:31 ` Eli Zaretskii
2023-12-21 16:51 ` Vladimir Kazanov
2023-12-21 17:37 ` Eli Zaretskii
2023-12-23 13:28 ` Vladimir Kazanov
2023-12-23 13:40 ` Eli Zaretskii
2023-12-24 11:31 ` Vladimir Kazanov
2023-12-24 16:54 ` Eli Zaretskii
2024-03-25 15:55 ` Vladimir Kazanov
2024-03-25 17:11 ` Eli Zaretskii
2024-03-26 22:16 ` Vladimir Kazanov
2024-03-27 10:59 ` Vladimir Kazanov
2024-03-27 11:25 ` Po Lu
2024-03-27 12:48 ` Vladimir Kazanov
2024-03-27 11:25 ` Po Lu
2024-03-31 8:36 ` Eli Zaretskii
2024-04-07 11:14 ` Vladimir Kazanov
2024-04-07 12:44 ` Eli Zaretskii
2024-04-07 17:07 ` Vladimir Kazanov
2024-04-07 18:40 ` Eli Zaretskii [this message]
2024-04-08 14:41 ` Vladimir Kazanov
2024-04-13 9:14 ` Eli Zaretskii
2024-04-13 9:32 ` Vladimir Kazanov
2024-04-13 11:21 ` Eli Zaretskii
2024-04-13 14:53 ` Vladimir Kazanov
2024-04-13 15:47 ` Eli Zaretskii
2024-03-27 12:14 ` Eli Zaretskii
2024-03-27 12:48 ` Vladimir Kazanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86le5pyq1p.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=vekazanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.