From: Eli Zaretskii <eliz@gnu.org>
To: Magiel Bruntink <magiel.bruntink@icloud.com>
Cc: 70329@debbugs.gnu.org
Subject: bug#70329: 29.3; etags-regen-mode fails in projects that have spaces in their root path elements
Date: Thu, 11 Apr 2024 19:17:32 +0300 [thread overview]
Message-ID: <86le5jub4z.fsf@gnu.org> (raw)
In-Reply-To: <7yh6g7dhw7.fsf@icloud.com> (message from Magiel Bruntink on Thu, 11 Apr 2024 17:43:36 +0200)
[Please use Reply All to reply, to keep the bug tracker CC'ed.]
> From: Magiel Bruntink <magiel.bruntink@icloud.com>
> Date: Thu, 11 Apr 2024 17:43:36 +0200
>
> No problem, thanks for the fix.
>
> While applying your patch I found a similar issue with ediff-ptch.el though. It
> won't find the to-be-patched file if there are spaces involved in the path.
>
> Here is the patch for it :-)
Thanks. I installed a slightly more radical change instead:
diff --git a/lisp/vc/ediff-ptch.el b/lisp/vc/ediff-ptch.el
index f8d4c1c..2d5d460 100644
--- a/lisp/vc/ediff-ptch.el
+++ b/lisp/vc/ediff-ptch.el
@@ -721,10 +721,11 @@ ediff-patch-file-internal
nil ; don't redisplay
shell-command-switch ; usually -c
(format "%s %s %s %s"
- ediff-patch-program
+ (shell-quote-argument ediff-patch-program)
ediff-patch-options
ediff-backup-specs
- (ediff--buffer-file-name buf-to-patch))
+ (shell-quote-argument
+ (ediff--buffer-file-name buf-to-patch)))
))
;; restore environment for gnu patch
next prev parent reply other threads:[~2024-04-11 16:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 19:32 bug#70329: 29.3; etags-regen-mode fails in projects that have spaces in their root path elements Magiel Bruntink via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-11 7:29 ` Eli Zaretskii
[not found] ` <7ysezsc6q6.fsf@icloud.com>
2024-04-11 14:48 ` Eli Zaretskii
[not found] ` <7yh6g7dhw7.fsf@icloud.com>
2024-04-11 16:17 ` Eli Zaretskii [this message]
2024-04-11 17:10 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86le5jub4z.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=70329@debbugs.gnu.org \
--cc=magiel.bruntink@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.