From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Building the igc branch on MS-Windows Date: Fri, 26 Apr 2024 13:39:04 +0300 Message-ID: <86le50z9vb.fsf@gnu.org> References: <86il063imh.fsf@gnu.org> <87ttjqghyd.fsf@gmail.com> <86zfti101u.fsf@gnu.org> <87pluegd4z.fsf@gmail.com> <86ttjp20je.fsf@gnu.org> <87y191fwnd.fsf@gmail.com> <87cyqcfv6k.fsf@gmail.com> <86o79wzi31.fsf@gnu.org> <875xw4fsol.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18818"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, emacs-devel@gnu.org To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 26 12:40:16 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s0J04-0004eY-Aq for ged-emacs-devel@m.gmane-mx.org; Fri, 26 Apr 2024 12:40:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s0Iza-0001Sm-De; Fri, 26 Apr 2024 06:39:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0IzU-0001SQ-HN for emacs-devel@gnu.org; Fri, 26 Apr 2024 06:39:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0IzU-0002R5-83; Fri, 26 Apr 2024 06:39:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=IiFXKn/wj3vSEt9weXPkczDpJlzyS5ns7G7S/jmK2Cs=; b=q6577g9L9mLE +eTlzSKm1zNfaJvwZb508XcrH1pdjbMLYagRHIQnK/3dXE8HxTBUsESMtT8PqFdSHkqsifisTTnNg ERKCayhdl26Z8D6PEGNh7S/tAHj/f04xoYKe26NflbD0slbPLclmdy/0PZ7ryuaVs+Lfl6O3QH8MI 4FOJrK1LBD9UQGwMRbvL0Oa7ESX8K3mUzJclFObzy0Gm5+JcLLZG0hebPjvZjzR09XLBSkToB1BaS 17fjb2N0A/A0FVaArWD7m6v9NXFZqpKD5EW+NPd1nfv8XX8tsKNd52yaCQ5896/efcT1nJzXV4DZf i+tmvXtFgjMvB9RR5rkoGA==; In-Reply-To: <875xw4fsol.fsf@gmail.com> (message from Helmut Eller on Fri, 26 Apr 2024 10:12:58 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:318119 Archived-At: > From: Helmut Eller > Cc: gerd.moellmann@gmail.com, emacs-devel@gnu.org > Date: Fri, 26 Apr 2024 10:12:58 +0200 > > > if (FRAME_WINDOW_P (f) && FRAME_OUTPUT_DATA (f)) > > { > > struct font *font = FRAME_FONT (f); > > if (font) > > IGC_FIX12_RAW(ss, &font); <<<<<<<<<<<<<<<<<<<<< > > } > > I think this change introduced a bug. Remember that MPS is moving > GC. So it sometimes needs to update the pointer in the struct that we > are scanning. We have to give it the address of the field, not the > address of some local variable on the stack. Perhaps clearer is this: > > struct font **font = &FRAME_FONT (f); > if (*font) > IGC_FIX12_RAW(ss, font); Done. > > However, the crashes while scrolling through xdisp.c are still there. > > I just had 2 of them; backtraces below. It sounds like the first one > > is due to Lisp strings, but the second one is related to markers. > > > > igc.c:1584: Emacs fatal error: assertion failed: !"other" > > Yes, I see this too. I will try to write some code to reproduce > this without needing manual input. Thanks.