From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#70577: [PATCH] New command other-project-prefix Date: Thu, 02 May 2024 09:12:18 +0300 Organization: LINKOV.NET Message-ID: <86le4tz88d.fsf@mail.linkov.net> References: <86le501ykg.fsf@mail.linkov.net> <86jzkhe81b.fsf@mail.linkov.net> <208c7a05-6cfe-40c2-af54-187967348686@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16361"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 70577@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 02 08:21:27 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s2Pos-00040J-MM for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 May 2024 08:21:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2Png-0004H1-Kk; Thu, 02 May 2024 02:20:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2PnD-00045O-60 for bug-gnu-emacs@gnu.org; Thu, 02 May 2024 02:19:43 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s2PnC-0000cX-3Z for bug-gnu-emacs@gnu.org; Thu, 02 May 2024 02:19:42 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s2PnX-0004Ej-Md for bug-gnu-emacs@gnu.org; Thu, 02 May 2024 02:20:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 May 2024 06:20:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70577 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70577-submit@debbugs.gnu.org id=B70577.171463077616225 (code B ref 70577); Thu, 02 May 2024 06:20:03 +0000 Original-Received: (at 70577) by debbugs.gnu.org; 2 May 2024 06:19:36 +0000 Original-Received: from localhost ([127.0.0.1]:41756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2Pn5-0004Dd-Qa for submit@debbugs.gnu.org; Thu, 02 May 2024 02:19:36 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:56837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2Pn4-0004DJ-Ll for 70577@debbugs.gnu.org; Thu, 02 May 2024 02:19:35 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 24942240006; Thu, 2 May 2024 06:19:04 +0000 (UTC) In-Reply-To: <208c7a05-6cfe-40c2-af54-187967348686@gutov.dev> (Dmitry Gutov's message of "Mon, 29 Apr 2024 00:40:00 +0300") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284271 Archived-At: >> Something is wrong here. I bound 'other-project-prefix' to 'C-x p P'. >> Then typing 'C-x p P C-x d' asked a directory name, then later >> after selecting a project asked for the directory name again. > > Looks like that has to do with the interactive spec. See the attached next > revision, it seems to behave better. Thanks, this works now (except that it can't be debugged because of the Lisp error: (wrong-type-argument listp ignore)). Also 'C-h' is not a problem: 'help-form-show' does nothing without 'help-form', but with 'help-form' works fine: (define-key map (vector help-char) (lambda () (interactive) (let ((help-form "You can use any global keybinding.")) (help-form-show)))) However, a much bigger problem is that unfortunately many test cases from https://debbugs.gnu.org/63648#203 are broken. For example, 'C-x p p C-b' fails the same way as in bug#58784. 'C-x p p f M-n' fails because it expects to read arguments in a previous project with an old value of default-directory, etc. Maybe this could be fixed by running 'interactive' in a previous project by using something like: (around-fun (lambda (command &rest _args) (interactive (lambda (spec) (let ((default-directory prev-dir)) (advice-eval-interactive-spec spec))))