From: Eli Zaretskii <eliz@gnu.org>
To: n142857@gmail.com, Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 71223@debbugs.gnu.org
Subject: bug#71223: 30.0.50; stack overflow after very fast opening and closing of frames
Date: Mon, 27 May 2024 15:36:35 +0300 [thread overview]
Message-ID: <86le3vv3cc.fsf@gnu.org> (raw)
In-Reply-To: <86msobv3yy.fsf@gnu.org> (message from Eli Zaretskii on Mon, 27 May 2024 15:23:01 +0300)
> Cc: 71223@debbugs.gnu.org
> Date: Mon, 27 May 2024 15:23:01 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> Does the patch below help?
Actually, the more thorough patch below should be better. Can you see
if it solves the problems with "Lisp nesting exceeds
`max-lisp-eval-depth'"?
Stefan, any comments about the problem and the proposed solution?
diff --git a/lisp/server.el b/lisp/server.el
index b650532..fcaf0ab 100644
--- a/lisp/server.el
+++ b/lisp/server.el
@@ -1034,6 +1034,15 @@ server-goto-toplevel
(run-with-timer 0 nil (lambda () (server-execute-continuation proc)))
(top-level)))
+(defun server--sit-for (proc seconds)
+ "Like `sit-for', but disable filter of process PROC and don't redisplay."
+ (let ((orig-filter (process-filter proc)))
+ (unwind-protect
+ (progn
+ (set-process-filter proc nil)
+ (sit-for seconds t))
+ (set-process-filter proc orig-filter))))
+
;; We use various special properties on process objects:
;; - `env' stores the info about the environment of the emacsclient process.
;; - `continuation' is a no-arg function that we need to execute. It contains
@@ -1159,7 +1168,7 @@ server-process-filter
;; it, in case the error written by emacsclient to stderr is not
;; visible for some reason.
(message "Authentication failed")
- (sit-for 2)
+ (server--sit-for proc 2)
(server-send-string
proc (concat "-error " (server-quote-arg "Authentication failed")))
(unless (eq system-type 'windows-nt)
@@ -1169,7 +1178,7 @@ server-process-filter
(delete-terminal terminal))))
;; Before calling `delete-process', give emacsclient time to
;; receive the error string and shut down on its own.
- (sit-for 1)
+ (server--sit-for proc 1)
(delete-process proc)
;; We return immediately.
(cl-return-from server-process-filter)))
@@ -1508,7 +1517,7 @@ server-return-error
;; it, in case the error written by emacsclient to stderr is not
;; visible for some reason.
(message (error-message-string err))
- (sit-for 2)
+ (server--sit-for proc 2)
(server-send-string
proc (concat "-error " (server-quote-arg
(error-message-string err))))
@@ -1520,7 +1529,7 @@ server-return-error
(delete-terminal terminal))))
;; Before calling `delete-process', give emacsclient time to
;; receive the error string and shut down on its own.
- (sit-for 5)
+ (server--sit-for proc 5)
(delete-process proc)))
(defun server-goto-line-column (line-col)
next prev parent reply other threads:[~2024-05-27 12:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 11:01 bug#71223: 30.0.50; stack overflow after very fast opening and closing of frames Daniel Clemente
2024-05-27 12:23 ` Eli Zaretskii
2024-05-27 12:36 ` Eli Zaretskii [this message]
2024-05-27 14:44 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-27 15:21 ` Eli Zaretskii
2024-05-27 17:49 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-27 18:15 ` Eli Zaretskii
2024-05-27 18:33 ` Eli Zaretskii
2024-05-29 0:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-29 11:48 ` Eli Zaretskii
2024-05-29 20:58 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-30 5:12 ` Eli Zaretskii
2024-05-30 13:40 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-30 15:29 ` Eli Zaretskii
2024-05-27 15:21 ` Daniel Clemente
2024-05-27 15:26 ` Eli Zaretskii
2024-05-29 0:28 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-29 10:54 ` Daniel Clemente
2024-05-29 19:56 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-30 4:56 ` Eli Zaretskii
2024-05-30 13:35 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-29 21:07 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-30 5:19 ` Eli Zaretskii
2024-05-30 16:09 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-30 16:49 ` Eli Zaretskii
2024-05-30 18:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-30 22:39 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-31 5:45 ` Eli Zaretskii
2024-05-31 12:41 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-30 11:22 ` Daniel Clemente
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86le3vv3cc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=71223@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=n142857@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.