From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71380: 30.0.50; Submitting php-ts-mode, new major mode for php Date: Sun, 09 Jun 2024 20:49:24 +0300 Message-ID: <86le3e9fbv.fsf@gnu.org> References: <3686989.dWV9SEqChM@3-191.divsi.unimi.it> <3561301.dWV9SEqChM@fedora> <86r0d69q75.fsf@gnu.org> <4927373.OV4Wx5bFTl@fedora> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27288"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71380@debbugs.gnu.org To: Vincenzo Pupillo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 09 19:50:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sGMgJ-0006vO-OS for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Jun 2024 19:50:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sGMfv-0008RZ-4p; Sun, 09 Jun 2024 13:49:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGMfq-0008RI-Ca for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2024 13:49:46 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sGMfq-0001jV-4V for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2024 13:49:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sGMg6-0003a2-7y for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2024 13:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Jun 2024 17:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71380 X-GNU-PR-Package: emacs Original-Received: via spool by 71380-submit@debbugs.gnu.org id=B71380.171795539013718 (code B ref 71380); Sun, 09 Jun 2024 17:50:02 +0000 Original-Received: (at 71380) by debbugs.gnu.org; 9 Jun 2024 17:49:50 +0000 Original-Received: from localhost ([127.0.0.1]:51650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGMft-0003ZC-Kp for submit@debbugs.gnu.org; Sun, 09 Jun 2024 13:49:49 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGMfs-0003Yw-Cb for 71380@debbugs.gnu.org; Sun, 09 Jun 2024 13:49:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGMfW-0001ce-It; Sun, 09 Jun 2024 13:49:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=U/hyFX9h5S0gcSvkz3/WmqxOcrdeNRFLnhCfMF0V8Go=; b=BEtcKurGEiLE gKstO5JONJ8Kii8hvMnulVgaCr7rFB0tvjEuR9PtEpXjchVuGLoHC2AdX1e7xY38XmpjUOdrV8zGB iA+dp6/3+fAeh7lg6K6XMOpeJBbxqjljPHBQkpCDUqAE8d+PHpdOLt6bhGFijNupcyjlNMLrmW+VI NKRlUl4bC1jlD1pgdaglTDzaaLQ/fcy2EC3U+Ta1JT/vj5nfonX4Fhmd5vAxqu06PC1p+lH0Y8y/j dDnuAZ8AB2Beb9/1tXY5pka7mB39TZWAjVYeKJZEgvmkNo0eOqT/qjXJKvUHVnx6Bl+nIu47OvDXg STl1PuEEu71Ijl6LwKv+Ww==; In-Reply-To: <4927373.OV4Wx5bFTl@fedora> (message from Vincenzo Pupillo on Sun, 09 Jun 2024 19:23:05 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286955 Archived-At: > From: Vincenzo Pupillo > Cc: 71380@debbugs.gnu.org > Date: Sun, 09 Jun 2024 19:23:05 +0200 > > > > > Thanks, but does this replace both patches you sent in a previous > > > > message? See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71380#23 > > > > Or does this replace only one of the two, and the other one is still > > > > needed? > > > > > > Replace only one. The other is still needed. I made a separate patch, > > > waiting to hear if I should open another bug for html-ts-mode. > > > > Would you mind posting both patches together, updated so that I could > > install them both? And note that I just found a strange mistake(?) in > > the second patch. > > > > Thanks. > Hi Eli, > sorry. I made a mistake with the second patch. > The warning Andrea reported was actually due to the (require 'html-ts-mode) at > the beginning of php-ts-mode. > I then use a solution similar to elixir-ts-mode, the (require 'html-ts-mode) > is done only after checking that the parser exists. But the patch you posted now doesn't include the HTML part, does it? is the patch self-contained, or does it still need the second patch? > There is one problem I don't know how to solve: enabling php-ts-mode, because > of the require html-ts-mode, the major mode for html changes from mhtml-mode > to html-ts-mode. > Can you tell me how to fix this? Just document this side effect, so that users know.