all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Vincenzo Pupillo <v.pupillo@gmail.com>
Cc: 71380@debbugs.gnu.org
Subject: bug#71380: 30.0.50; Submitting php-ts-mode, new major mode for php
Date: Sun, 09 Jun 2024 20:49:24 +0300	[thread overview]
Message-ID: <86le3e9fbv.fsf@gnu.org> (raw)
In-Reply-To: <4927373.OV4Wx5bFTl@fedora> (message from Vincenzo Pupillo on Sun, 09 Jun 2024 19:23:05 +0200)

> From: Vincenzo Pupillo <v.pupillo@gmail.com>
> Cc: 71380@debbugs.gnu.org
> Date: Sun, 09 Jun 2024 19:23:05 +0200
> 
> > > > Thanks, but does this replace both patches you sent in a previous
> > > > message?  See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=71380#23
> > > > Or does this replace only one of the two, and the other one is still
> > > > needed?
> > > 
> > > Replace only one. The other is still needed. I made a separate patch,
> > > waiting to hear if I should open another bug for html-ts-mode.
> > 
> > Would you mind posting both patches together, updated so that I could
> > install them both?  And note that I just found a strange mistake(?) in
> > the second patch.
> > 
> > Thanks.
> Hi Eli, 
> sorry. I made a mistake with the second patch.
> The warning Andrea reported was actually due to the (require 'html-ts-mode) at 
> the beginning of php-ts-mode.
> I then use a solution similar to elixir-ts-mode, the (require 'html-ts-mode) 
> is done only after checking that the parser exists.

But the patch you posted now doesn't include the HTML part, does it?

is the patch self-contained, or does it still need the second patch?

> There is one problem I don't know how to solve: enabling php-ts-mode, because 
> of the require html-ts-mode, the major mode for html changes from mhtml-mode 
> to html-ts-mode. 
> Can you tell me how to fix this?

Just document this side effect, so that users know.





  reply	other threads:[~2024-06-09 17:49 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-05 13:59 bug#71380: 30.0.50; Submitting php-ts-mode, new major mode for php Vincenzo Pupillo
2024-06-06  6:58 ` Eli Zaretskii
2024-06-07 10:45   ` Vincenzo Pupillo
2024-06-07 11:12     ` Eli Zaretskii
2024-06-07 12:50       ` Vincenzo Pupillo
2024-06-07 13:44         ` Eli Zaretskii
2024-06-07 15:05           ` Vincenzo Pupillo
2024-06-08  9:31             ` Vincenzo Pupillo
2024-06-08 10:45               ` Eli Zaretskii
2024-06-08 11:15                 ` Vincenzo Pupillo
2024-06-09 13:54                   ` Eli Zaretskii
2024-06-09 17:23                     ` Vincenzo Pupillo
2024-06-09 17:49                       ` Eli Zaretskii [this message]
2024-06-09 19:37                         ` Vincenzo Pupillo
2024-06-09 20:36                           ` Vincenzo Pupillo
2024-06-12  9:25                             ` Vincenzo Pupillo
2024-06-12 18:27                               ` Eli Zaretskii
2024-06-12 20:44                                 ` Vincenzo Pupillo
2024-06-09 13:53     ` Eli Zaretskii
2024-06-06 14:06 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-07  9:04   ` Vincenzo Pupillo
2024-06-07 12:53     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-07 13:25       ` Vincenzo Pupillo
2024-06-07 13:49         ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-07 14:37           ` Vincenzo Pupillo
2024-06-06 14:54 ` Andrea Corallo
2024-06-07  8:36   ` Vincenzo Pupillo
2024-06-07 13:39     ` Andrea Corallo
2024-06-07 17:02       ` Vincenzo Pupillo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86le3e9fbv.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=71380@debbugs.gnu.org \
    --cc=v.pupillo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.