all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: vincenzo.pupillo@lpsd.it, 71518@debbugs.gnu.org
Subject: bug#71518: 30.0.50; Errors during redisplay with c++-ts-mode
Date: Thu, 13 Jun 2024 11:24:27 +0300	[thread overview]
Message-ID: <86le39z1vo.fsf@gnu.org> (raw)
In-Reply-To: <7108109B-3AFB-4623-890E-1E19903FA0D0@gmail.com> (message from Yuan Fu on Wed, 12 Jun 2024 23:51:21 -0700)

> From: Yuan Fu <casouri@gmail.com>
> Date: Wed, 12 Jun 2024 23:51:21 -0700
> Cc: 71518@debbugs.gnu.org,
>  Bug Report Emacs <bug-gnu-emacs@gnu.org>,
>  Eli Zaretskii <eliz@gnu.org>
> 
> So it seems “virtual” is now a named node rather than an anonymous node, which is a little odd. I asked the author about it in the GitHub issue, let me clear that up before fixing c-ts-mode.

Thanks.

> And, Eli, we really really should pin tree-sitter grammars. As more people start using tree-sitter modes, they will found out about the breakage before we do and the tree-sitter major mode would be unusable for them before they upgrade their grammar. Most of them will not know how to do it and which commit to downgrade to. And I really don’t want to chase the random changes these grammars make all the time. Fixing for these breakages is arguably a heavier maintenance burden than pinning tree-sitter grammars.

But we've been through this already: pinning versions is impractical,
except for those of us who build their own grammar libraries and can
checkout and build the specific pinned revision.  The rest of the
users, who rely on grammars compiled by someone else, will have no
practical way of using the TS modes, unless that someone happens to
provide the pinned version.

And what is the mechanism of selecting the pinned version?  Who and
how will determine which version to pin, and how will we indicate
those versions in Emacs?  This was never finalized, and is not trivial
at all.

When we discussed that, there was a question of how the various
distros handle these libraries, if they at all distribute that.  Did
we learn something new about this?

If nothing has changed since we discussed that, why are you saying now
that we "really should pin"?  That other editors use pinned versions
doesn't mean it's a good solution, for us or in general.  It
definitely has a disadvantage of preventing users to upgrade the
grammar libraries until the next Emacs release (which could be several
months or even a year away), and the advantage is quite illusory.
yes, without pinning we have a maintenance headache on our hands, but
if there's no better alternative, what else can we do?





  reply	other threads:[~2024-06-13  8:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-12 12:33 bug#71518: 30.0.50; Errors during redisplay with c++-ts-mode Eli Zaretskii
2024-06-12 13:53 ` Vincenzo Pupillo
2024-06-13  6:51   ` Yuan Fu
2024-06-13  8:24     ` Eli Zaretskii [this message]
2024-06-13  8:57     ` Vincenzo Pupillo
2024-06-22  8:26     ` Eli Zaretskii
2024-06-22 14:42       ` Vincenzo Pupillo
2024-06-22 15:57         ` Eli Zaretskii
2024-06-22 16:14           ` Vincenzo Pupillo
2024-06-22 16:56             ` Eli Zaretskii
2024-06-22 17:03               ` Eli Zaretskii
2024-06-22 17:59                 ` Vincenzo Pupillo
2024-06-22 18:15                   ` Eli Zaretskii
2024-06-22 18:15                   ` Vincenzo Pupillo
2024-06-22 18:19                     ` Eli Zaretskii
2024-06-22 23:18                       ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86le39z1vo.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=71518@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=vincenzo.pupillo@lpsd.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.