all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "J.P." <jp@neverwas.me>, Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 72561@debbugs.gnu.org
Subject: bug#72561: 31.0.50; Scan error in ert--pp-with-indentation-and-newline
Date: Thu, 15 Aug 2024 11:33:32 +0300	[thread overview]
Message-ID: <86le0y6v8j.fsf@gnu.org> (raw)
In-Reply-To: <87v808o5es.fsf@neverwas.me> (jp@neverwas.me)

> From: "J.P." <jp@neverwas.me>
> Date: Sat, 10 Aug 2024 06:48:11 -0700
> 
> Tags: patch
> 
> This apparently began after
> 
>   2f181d60323bd9e0196775828de633100479f4c2
>   Author:     Stefan Monnier <monnier@iro.umontreal.ca>
>   AuthorDate: Fri Jun 16 13:35:06 2023 -0400
>   CommitDate: Sat Jun 17 17:24:38 2023 -0400
> 
>   pp.el (pp-fill): New default pp function
>   
>   1 file changed, 90 insertions(+), 1 deletion(-)
>   lisp/emacs-lisp/pp.el | 91 ++++++++++++++++++++++++++++++++++++++++++++++++++-
> 
> So I guess it also affects Emacs 30. To reproduce, put this in
> test/lisp/emacs-lisp/ert-tests.el:
> 
>    (ert-deftest ert--pp-with-indentation-and-newline ()
>      (should (equal '((:one "1" :three "3" :two "2")) '((:one "1")))))
> 
> Then run something like:
> 
>    $ make -C test \
>      SELECTOR=ert--pp-with-indentation-and-newline \
>      lisp/emacs-lisp/ert-tests.log
> 
>    Error: scan-error ("Containing expression ends prematurely" 221 221)
>      forward-sexp-default-function(-1)
>      forward-sexp(-1)
>      calculate-lisp-indent((5 221 238 nil nil nil 4 nil nil (5 27 161 175
>      lisp-indent-calc-next(#s(lisp-indent-state :stack (50 16 6 5 nil) :p
>      indent-sexp()
>      ert--pp-with-indentation-and-newline((ert-test-failed ((should (equa
>      #f(compiled-function (event-type &rest event-args) #<bytecode 0x16b6
>      #f(compiled-function () #<bytecode -0xb4ce749a56118cd>)()
>      ert-run-or-rerun-test(#s(ert--stats :selector ert--pp-with-indentati
>    
>    Aborted: Ran 1 tests, 0 results as expected, 1 unexpected, -1 skipped
>    
> No idea if there's a deeper issue at play here, maybe something in
> pp.el that a patch like the attached would just be papering over.

Adding Stefan.





  reply	other threads:[~2024-08-15  8:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-10 13:48 bug#72561: 31.0.50; Scan error in ert--pp-with-indentation-and-newline J.P.
2024-08-15  8:33 ` Eli Zaretskii [this message]
2024-08-21 21:41 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-22  0:28   ` J.P.
2024-08-22  1:21     ` J.P.
2024-08-22 13:43       ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-23  1:02         ` J.P.
2024-08-23  6:31           ` Eli Zaretskii
2024-08-29  3:48             ` J.P.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86le0y6v8j.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=72561@debbugs.gnu.org \
    --cc=jp@neverwas.me \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.