From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70994: [PATCH] Make cache regeneration work in group names with / Date: Sat, 24 Aug 2024 14:54:28 +0530 Message-ID: <86le0mb7eb.fsf@gmx.net> References: <86jzjt11ff.fsf@outlook.com> <87le428xvg.fsf@ericabrahamsen.net> <86y182bg9t.fsf@gmx.net> <87zfsg6lut.fsf@ericabrahamsen.net> <865xsbu83j.fsf@outlook.com> <86plpynx9a.fsf@gnu.org> Reply-To: James Thomas Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14832"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: eric@ericabrahamsen.net, 70994@debbugs.gnu.org, stefankangas@gmail.com, daniel@dsemy.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 24 11:25:34 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1shn1Z-0003hc-BB for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Aug 2024 11:25:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1shn1I-0004c3-Jf; Sat, 24 Aug 2024 05:25:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1shn1F-0004ba-Ka for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2024 05:25:14 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1shn1F-0005sB-BA for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2024 05:25:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=NFtdv7XJqLPbE/4j9N2Bz2XTk1CgHqmuqCFTYX6N4Ok=; b=MO86obvedyVb8pBPDvUQMoJT0PmdwZWKl8wX2lqoyI9BdflzgPdXp8He0kaBmJCat51oprhtcppN7gRX0ca8ep6mLrJlY7999u36K41i+H7tdyrrvOHMXtn+MfKxfEIHIrU9y6IesFMz6CwVz4tkkH+EZzw1Ya8OBfrBKkg3iPpxF4I/M47atxL0LYpW9OF7agV1CmKsIv/d6UunsQQqqHy+sKrUFJ3ewqBu4Emc21kPn1ypXOJsjJXLFYi93dRMzTTmHF7nPs50mfOznxAB9O2Es4Db6ziPMoGo+g6IZQ4zX+9aXw4sQjRRb/qjy5pftN2oNu6UqbGpRTN6BtIWcg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1shn21-00007L-KT for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2024 05:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: James Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Aug 2024 09:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70994 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70994-submit@debbugs.gnu.org id=B70994.1724491547424 (code B ref 70994); Sat, 24 Aug 2024 09:26:01 +0000 Original-Received: (at 70994) by debbugs.gnu.org; 24 Aug 2024 09:25:47 +0000 Original-Received: from localhost ([127.0.0.1]:40491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shn1n-00006m-3t for submit@debbugs.gnu.org; Sat, 24 Aug 2024 05:25:47 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:47833) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shn1k-00006S-Jy for 70994@debbugs.gnu.org; Sat, 24 Aug 2024 05:25:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1724491476; x=1725096276; i=jimjoe@gmx.net; bh=NFtdv7XJqLPbE/4j9N2Bz2XTk1CgHqmuqCFTYX6N4Ok=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=OTJacI5nydtkToBpAf9DZtwYwIpSTDC6aacZmi6yL+53iGzP5tPbGIZsxj0aLHjI x9NG7R2HwtFZtlje36IvZzvUyDNd43ItKLs1Mx8EsfLZNA4A6yau5aDrQnEiTA7Nk DFoMThfJY3Bsf8C9WiNT7zODxFEcop6RF+ct8kAllGLD0FtaY3//f2MtZSdzGvOfT PyFliQI6fnlyKLr27QpoGNuSv1KYGrk8eO9tpvjDtZDQmL+MUH0XnoE9nx5IeqqOE nWVXF109wBu5pNI2xfW9/z/gRehNV8QM9V8HipOQTgZsyHsfw6SG4BxNGNv6QUVzz LIjxiO1o2zt4x61BeQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from user-Inspiron-3493 ([120.61.28.248]) by mail.gmx.net (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MOREi-1sU80T1VrK-00JP0W; Sat, 24 Aug 2024 11:24:36 +0200 In-Reply-To: <86plpynx9a.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 24 Aug 2024 11:25:05 +0300") X-Provags-ID: V03:K1:CFwEbXV416xnCkKS+JqaC8Z7MSDJ04Uohm5fMh07Lxp5/CCqutD UkLjaJzLZJF4LZl12B8wJuneoEvYbke6azVQ2mzUVwecQEGHqUja5AYpW5pfyt+kpT+Ln8v pJ8omrOzsztWb119/xB8eR54yl9cb3WwhkvNClIzYnjZLt0aOWdfxldouBxdJjM/VF2vClh bMiqtj67vGACn+u432lAQ== UI-OutboundReport: notjunk:1;M01:P0:H6D5eSiXHOo=;BDAxRhGKdih7wBB21uJQHVRcdaE 2VqVoMITiASSzDY9w36U8X4J17tIWRrp9IdrmUjMg9hKv+h5RCDC5ilMHzJm7cr4myAlN1RB9 Ni2VVWKfkj8LiVs9k3Rq3GkzQ7ujAPQ/4H1YnTtu/Jpvi1Dj5GpXKyWbN1jql0zxPt8/24bkU KSmOZKkxfIpLmZ/qFUShesT6GJxMID14dePMMvuwVCgW2oJOI/BVPM/fBLSfmZ4dKP8Y8webu S9dh2kvHyfiTgsp8xmF6TqAeR4r+3qcwGe5FStlWTTMSWA4ajUPTzLdJwoBW/6JwAofmTLM72 RkoUEbaFM6eyeRRJiikXkqlKjGiEttcQZ6TBps2Nm13vs6Qf0lGu6xH4GrIeccGJzAOxZJfeQ GM3ECuHta14RqmXUFy5sNvBvFN5xnm7LbHmMHzPgHyeI9S7rH2VgEzIueRiiR5Rii8L+JbhUc +4DgFEEjwR52zjv++dJuxjVaLPEdP9jILN2Hvqiy3vJSf31H0pFTVqKosxI10bDteV6ndVDdL s5NlHDvNJOwZZJ6u2cjax6BowtXn3q1EdKOGPEsh/nGlzRkYgK6jTWphJtIgSCPudXhi8j2yQ b2S6SNFTLYzLwxyrYn5XT3KzwcGWWWSplQ4bDCnptYnnxbEksy/AgvupczswnPtRQ9pbmFY56 +AshBNqFG0uujgle+S31xr2CeQ3Gy9tCyI6S6AqlBJZrnQ+14xa/xDd6mHloCwKyzWXLYD0oU 3XZO4MZewVfOrdC5G/iLq2OhOETc+0xrxumPz4iwcLSpRejWo/Jzlk5skKeqwyTv3+jP5rJR X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290652 Archived-At: Eli Zaretskii wrote: > Ping! Can we make some progress here? I'd like to confess again that this doesn't seem to be a big deal: 'gnus-cache-generate-nov-databases' and 'gnus-cache-generate-active' should work regardless. It's only for someone who might accidentally do this. Regards, James > >> Cc: 70994@debbugs.gnu.org, Stefan Kangas , >> Daniel Semyonov >> Date: Thu, 08 Aug 2024 06:46:48 +0530 >> From: James Thomas via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >>=20 >> Eric Abrahamsen wrote: >>=20 >> > James Thomas via "Bug reports for GNU Emacs, the Swiss army knife >> > of >> > text editors" writes: >> > >> >> Eric Abrahamsen wrote: >> >> >> >>> Stefan Kangas writes: >> >>> >> >>>> James Thomas via "Bug reports for GNU Emacs, the Swiss army >> >>>> knife of >> >>>> text editors" writes: >> >>>> >> >>>>> Reproduction steps for bug: >> >>>>> >> >>>>> - emacs -Q >> >>>>> - (setq gnus-secondary-select-methods >> >>>>> '((nnatom "github.com/vedang/pdf-tools/commits.atom"))) >> >>>>> (setq gnus-select-method '(nnnil "")) >> >>>>> - M-x gnus >> >>>>> - Open a message in the new group and press * >> >>>>> - Add the cache virtual server (info "(gnus) Creating a Virtual Se= rver") >> >>>>> - ^ (server buffer) and: g on the cache >> >>>>> - RET to open (fails) >> >>>>> >> >>>>> This is a possible fix that I've tested only on my (limited) setup= , for >> >>>>> now: >> >>>> >> >>>> Eric, what do you think of the below patch? >> >>> >> >>> Thanks for the bump... >> >>> >> >>> James, wasn't this what bug#69517 was supposed to be fixing? >> >> >> >> You're right, but that was specifically the 'cache'. In >> >> regenerate, all >> >> it sees is that the backend is nnml and there's nothing else >> >> special >> >> about the server. >> > >> > Okay, thanks. >> > >> >>> I'm still feeling like we're patching pinhole leaks in a >> >>> fundamentally >> >>> broken system. >> >> >> >> Sorry if my patch made you think so, but I don't feel that way >> >> =F0=9F=99=82. This >> >> feature is just tangential and things like slashes in group names >> >> are >> >> bound to complicate things. >> > >> > I wasn't complaining about your code :) Just generally grumbling >> > that >> > this is so complex. >> > >> >> But let me see if I can whip up an alternative patch that does >> >> things in >> >> a simpler way (I did say: 'possible' patch). One thing to decide >> >> is >> >> whether '%'s are uncommon enough in group names to warrant >> >> special >> >> treatment in a backend as fundamental as nnml. >>=20 >> I've gone ahead and assumed the above; so now the patch is way >> simpler. >> (Btw I meant to say 'nnmail' above, not 'nnml'). It shouldn't be a >> problem: think I remember only Gmail using a % at some point - and a >> simple renaming fixes that - perhaps there should be a NEWS entry. >>=20 >>=20 >> Note that for this to work with nnatom in the current upstream >> you'll >> also need (ahem!) my patch in bug#65467: bug#71888 must be >> responsible. >>=20 >> > Without diving into this right now, it seems like this is >> > something that >> > should be governed by the nnmail abstract backend, from which nnml >> > and >> > friends inherit. I would dearly, dearly love it if all backends >> > that >> > might potentially create an on-disk directory from a group name >> > would >> > use the same code (applying the same user options) to do it, >> > essentially >> > transparently. It makes me nervous when various functions in >> > various >> > places repeat similar-but-not-quite-identical routines in encoding >> > and >> > decoding group names. I suppose that URL encoding/decoding >> > functions >> > might end up being an okay tool, but I wonder if Elisp doesn't >> > already >> > have some prior art here. I'll do a bit of reading. >>=20 >> That's worthwhile of course, but here, for the time being, I've >> decided >> I'm only grappling with the new allowance of '/'s in group names. >> :-) >>=20 >> (A further improvement involves replacing the '/'s in the code with >> '-directory-separator-character', but that's for another report) >>=20 >> Regards, >> James