all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Joe Wells <jbw@macs.hw.ac.uk>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: rms@gnu.org, Markus Triska <markus.triska@gmx.at>, emacs-devel@gnu.org
Subject: Re: something like linum.el ought to be added
Date: Fri, 14 Sep 2007 17:15:19 +0100	[thread overview]
Message-ID: <86k5qtjka0.fsf@macs.hw.ac.uk> (raw)
In-Reply-To: <jwvir6dtko4.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri\, 14 Sep 2007 09\:59\:37 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Yes, that's how I'm doing it now; update is now also added to several
>> other hooks. One oversight in Emacs is, I think, that the functions in
>> window-size-change-functions are invoked as regular functions in
>> xdisp.c, therefore making the hook buffer-local currently results in
>> an error (due to 't'). I'm thus modifying the global hook for now.
>
> I think your code should rely on fontification-functions instead of fiddling
> with things like window-size-change-functions.  It may very well be that
> fontification-functions doesn't work quite right for you, tho (basically it
> was defined for jit-lock and I believe that putting more than one function
> on it won't work right, so maybe you'd want to use jit-lock-register
> instead).

Some comments on the idea of relying on fontification-functions:

I think linum.el should work even if the user has font-locking turned
off, so it shouldn't depend on jit-lock.el (unless jit-lock can be
used without turning font-locking on?).  Anyway, the whole
font-locking subsystem is also quite hard to understand, so it seems
unwise to me to get linum.el tied up in that complexity.  And
font-locking is oriented toward fontifying the entire buffer
eventually while with line numbering you probably only want to keep
active overlays for the displayed region.

And it seems it would be hard for fontification-functions will work
well with linum.el as a separate user from jit-lock.el, because they
would both be competing for control of the same fontified property.
So, for example, if stealth background fontification fontified some
region, it would (I think?) place a non-nil value on the fontified
property of that region, and then when that region was displayed by
scrolling there would be nothing to trigger the line numbering.

I hope these comments are helpful.

-- 
Joe

  reply	other threads:[~2007-09-14 16:15 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-09 10:04 something like linum.el ought to be added Joe Wells
2007-09-09 10:43 ` Leo
2007-09-10 16:53 ` Richard Stallman
2007-09-10 17:34   ` Markus Triska
2007-09-10 20:00     ` David Kastrup
2007-09-11 18:15       ` Markus Triska
2007-09-11 20:27         ` Davis Herring
2007-09-11 21:24           ` Markus Triska
2007-09-12  8:47         ` Richard Stallman
2007-09-12  9:14           ` Joe Wells
2007-09-12  9:21             ` David Kastrup
2007-09-12 18:52             ` Richard Stallman
2007-09-13 17:06           ` Markus Triska
2007-09-14 13:59             ` Stefan Monnier
2007-09-14 16:15               ` Joe Wells [this message]
2007-09-14 17:20                 ` Stefan Monnier
     [not found]                 ` <m1bqajgpc8.fsf_-_@gmx.at>
2007-10-28 18:46                   ` motivation for recent bug reports on overlays and properties like before-string, display, after-string, and face (was: linum.el and display properties) Joe Wells
2007-09-15  2:09               ` something like linum.el ought to be added Richard Stallman
2007-09-14 15:04             ` brianjiang
2007-09-14 15:56               ` Markus Triska
2007-09-15 14:46                 ` Juanma Barranquero
2007-09-15 16:12                   ` Markus Triska
2007-09-15 16:54                     ` Juanma Barranquero
2007-09-11 20:30       ` Richard Stallman
2007-09-11 20:31     ` Richard Stallman
2007-09-11 23:48       ` Markus Triska
2007-09-12  9:19         ` martin rudalics
2007-09-12 11:17           ` Markus Triska
2007-09-12 12:09             ` martin rudalics
2007-09-12 12:55               ` Markus Triska
2007-09-15 14:24     ` Juanma Barranquero
2007-09-15 16:01       ` Markus Triska
2007-09-15 16:14         ` Juanma Barranquero
2007-09-16  5:34         ` Richard Stallman
2007-09-16 15:57           ` Markus Triska
2007-09-17  3:58             ` Richard Stallman
2007-09-16 23:04           ` Stefan Monnier
2007-09-17  3:58             ` Richard Stallman
2007-09-17  5:12               ` brianjiang
2007-09-17 13:49                 ` Stefan Monnier
2007-09-17 13:17               ` Stefan Monnier
2007-09-17 22:24                 ` Richard Stallman
2007-09-18  0:49                   ` Stefan Monnier
2007-09-18  3:30                     ` Richard Stallman
2007-09-18 14:31                       ` Stefan Monnier
2007-09-11  7:08   ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86k5qtjka0.fsf@macs.hw.ac.uk \
    --to=jbw@macs.hw.ac.uk \
    --cc=emacs-devel@gnu.org \
    --cc=markus.triska@gmx.at \
    --cc=monnier@iro.umontreal.ca \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.