From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: isearch for doc-view.el Date: Mon, 05 Nov 2007 13:43:53 +0100 Message-ID: <86k5owlv5i.fsf@lola.quinscape.zz> References: <7gk5p448xq.fsf@fencepost.gnu.org> <87wst33g0o.fsf@baldur.tsdh.de> <87pryv3eew.fsf@baldur.tsdh.de> <87k5p3qisa.fsf@baldur.tsdh.de> <87ejfbqdb4.fsf@baldur.tsdh.de> <87y7dhv89p.fsf@jurta.org> <87ejf8kxwg.fsf@baldur.tsdh.de> <87sl3koq9k.fsf_-_@baldur.tsdh.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1194266652 16631 80.91.229.12 (5 Nov 2007 12:44:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 5 Nov 2007 12:44:12 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 05 13:44:16 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Ip1JM-0004np-JZ for ged-emacs-devel@m.gmane.org; Mon, 05 Nov 2007 13:44:12 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ip1JC-00032n-0k for ged-emacs-devel@m.gmane.org; Mon, 05 Nov 2007 07:44:02 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ip1J9-00032i-H3 for emacs-devel@gnu.org; Mon, 05 Nov 2007 07:43:59 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Ip1J6-00032K-Uz for emacs-devel@gnu.org; Mon, 05 Nov 2007 07:43:59 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ip1J6-000328-R0 for emacs-devel@gnu.org; Mon, 05 Nov 2007 07:43:56 -0500 Original-Received: from pc3.berlin.powerweb.de ([62.67.228.11]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Ip1J6-0004Ok-6I for emacs-devel@gnu.org; Mon, 05 Nov 2007 07:43:56 -0500 Original-Received: from quinscape.de (dslnet.212-29-44.ip210.dokom.de [212.29.44.210] (may be forged)) by pc3.berlin.powerweb.de (8.9.3p3/8.9.3) with ESMTP id NAA08567 for ; Mon, 5 Nov 2007 13:43:50 +0100 X-Delivered-To: Original-Received: (qmail 1672 invoked from network); 5 Nov 2007 12:43:55 -0000 Original-Received: from unknown (HELO lola.quinscape.zz) ([10.0.3.43]) (envelope-sender ) by ns.quinscape.de (qmail-ldap-1.03) with SMTP for ; 5 Nov 2007 12:43:54 -0000 Original-Received: by lola.quinscape.zz (Postfix, from userid 1001) id 7FCE38F2D3; Mon, 5 Nov 2007 13:43:53 +0100 (CET) In-Reply-To: <87sl3koq9k.fsf_-_@baldur.tsdh.de> (Tassilo Horn's message of "Mon\, 05 Nov 2007 13\:01\:11 +0100") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:82571 Archived-At: Tassilo Horn writes: > Here's my patch. It's just a simple start, but doc-view-search-forward > seems to work correctly. > > Index: lisp/doc-view.el > =================================================================== > RCS file: /sources/emacs/emacs/lisp/doc-view.el,v > retrieving revision 1.18 > diff -u -r1.18 doc-view.el > --- lisp/doc-view.el 1 Nov 2007 03:53:32 -0000 1.18 > +++ lisp/doc-view.el 5 Nov 2007 11:41:33 -0000 [...] > ;; Searching > - (define-key map (kbd "C-s") 'doc-view-search) > - (define-key map (kbd "") 'doc-view-search) > - (define-key map (kbd "C-S-n") 'doc-view-search-next-match) > - (define-key map (kbd "C-S-p") 'doc-view-search-previous-match) > + (define-key map (kbd "C-s") 'isearch-forward) > + (define-key map (kbd "") 'isearch-forward) > + (define-key map (kbd "C-r") 'isearch-backward) Is a definition even necessary? Can't you just inherit the normal bindings? -- David Kastrup