Re: master 0ff60ec: Fix some byte-compiler warnings in EDE

Re: master 0ff60ec: Fix some byte-compiler warnings in EDE

[Glenn Morris]

Hi,

Stephen Leake wrote:

> -NOTE: If you use dirmatch, you may need to set :root-only to nil.
> +NOTE: If you use dirmatch, you may need to set :root-only to `nil'.
>  While it may be a root based project, all subdirs will happen to return
> -true for the dirmatch, so for scanning purposes, set it to nil.")
> +true for the dirmatch, so for scanning purposes, set it to `nil'.")

The Emacs doc-string convention is to write nil and t without quotes.

http://www.gnu.org/software/emacs/manual/html_node/elisp/Documentation-Tips.html

Re: [Emacs-diffs] master 0ff60ec: Fix some byte-compiler warnings in EDE

[Stefan Monnier]

>     * lisp/cedet/ede/auto.el (ede-project-class-files): Delete obsolete name
>     argument to eieio class constructor.

Beware: this means the code won't work on Emacs<25.
The more backward-compatible way to handle this is to switch to `make-instance'.


        Stefan

Re: master 0ff60ec: Fix some byte-compiler warnings in EDE

[Stephen Leake]

Glenn Morris <rgm@gnu.org> writes:

> Hi,
>
> Stephen Leake wrote:
>
>> -NOTE: If you use dirmatch, you may need to set :root-only to nil.
>> +NOTE: If you use dirmatch, you may need to set :root-only to `nil'.
>>  While it may be a root based project, all subdirs will happen to return
>> -true for the dirmatch, so for scanning purposes, set it to nil.")
>> +true for the dirmatch, so for scanning purposes, set it to `nil'.")
>
> The Emacs doc-string convention is to write nil and t without quotes.
>
> http://www.gnu.org/software/emacs/manual/html_node/elisp/Documentation-Tips.html

Ok.

It's hard to remember an exception that is not followed in the manual
that describes the exception!


-- 
-- Stephe

Re: master 0ff60ec: Fix some byte-compiler warnings in EDE

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > It's hard to remember an exception that is not followed in the manual
  > that describes the exception!

Would you please explain?

-- 
Dr Richard Stallman
President, Free Software Foundation (gnu.org, fsf.org)
Internet Hall-of-Famer (internethalloffame.org)
Skype: No way! See stallman.org/skype.html.