From: "Juan José García-Ripoll" <juanjose.garciaripoll@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: decompress.c now also compresses
Date: Sun, 29 Mar 2020 18:48:40 +0200 [thread overview]
Message-ID: <86k1331507.fsf@csic.es> (raw)
In-Reply-To: 83369r5efv.fsf@gnu.org
Eli Zaretskii <eliz@gnu.org> writes:
> Something is wrong with your Git installation, I think: for some
> reason Git thinks that you are replacing the entire decompress.c file,
Yes, apologies. I have two copies of git and emacs keeps finding the
right one, but my msys buffer does not.
> This should be +++, not ---, and we should document this primitive in
> the Elisp manual, like we do with zlib-decompress-region.
> We also request a ChangeLog-style commit log message to go with ach
> contribution; please provide one.
Thanks for this and the style comments.
> Last, but not least: I'm not convinced that we would need such a
> primitive (the decompression primitive was provided to support
> decompression of payloads received via network protocols, but there's
> no similar reason for the compression routine). So before you invest
> more work in this, let's hear opinions from others regarding the
> necessity.
My reasoning was that (i) it was easy to do while I was watching
COVID-19 news and (ii) on top of this one can almost trivially build a
file handler for *.gz files that does not require gzip (as in the
automatic compression mode). Currently *-deps.zip ships all types of
compressors, including zlib, but not gzip. There may be other use cases,
such as the Emacs web server by E. Schulte (uses zlib-flate and
gzip). But I understand if you find it yet another maintenance hassle.
Cheers,
--
Juan José García Ripoll
http://juanjose.garciaripoll.com
http://quinfog.hbar.es
next prev parent reply other threads:[~2020-03-29 16:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-29 15:52 decompress.c now also compresses Juan José García-Ripoll
2020-03-29 15:57 ` Juan José García-Ripoll
2020-03-29 16:11 ` Eli Zaretskii
2020-03-29 16:48 ` Juan José García-Ripoll [this message]
2020-03-29 16:54 ` Stefan Monnier
2020-03-29 19:27 ` Juan José García-Ripoll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86k1331507.fsf@csic.es \
--to=juanjose.garciaripoll@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.