From: this nkk <thisnkk@gmail.com>
To: emacs-orgmode@gnu.org
Subject: Bug: (bug?) org-id-find-id-in-file doesn't close files after finding id [9.4 (9.4-7-g3eccc5-elpaplus @ ~/spacemacs/elpa/develop/org-plus-contrib-20200921/)]
Date: Thu, 24 Sep 2020 17:16:24 -0700 [thread overview]
Message-ID: <86k0wiyalj.fsf@aa.i-did-not-set--mail-host-address--so-tickle-me> (raw)
Remember to cover the basics, that is, what you expected to happen and
what in fact did happen. You don't know how to make a good report? See
https://orgmode.org/manual/Feedback.html#Feedback
Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------
** what happened
when running org-id-find-id-in-file on an id and an unvisited file, the
buffer it creates to visit file isn't
closed after finding id.
** what should have happened
I was expecting it to close the buffer if the
file wasn't already visited by another buffer.
Is this desired behavior?
** background info and possible fix
I stumbled on this while looking at an issue with org-roam at
https://github.com/org-roam/org-roam/issues/1129.
For now a guard clause like the following in the calling function closes the
buffer if need be.
(let (file-already-open-p return-val)
(setq file-already-open-p (find-buffer-visiting file))
(setq return-val (org-id-find-id-in-file id file markerp))
(unless file-already-open-p (kill-buffer (find-buffer-visiting file)))
(print return-val))
This logic can be propagated to the function to squash this possible
bug.
Emacs : GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.22, cairo version 1.17.3)
of 2020-08-20
Package: Org mode version 9.4 (9.4-7-g3eccc5-elpaplus @ ~/spacemacs/elpa/develop/org-plus-contrib-20200921/)
next reply other threads:[~2020-09-25 0:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 0:16 this nkk [this message]
2020-10-06 10:15 ` Bug: (bug?) org-id-find-id-in-file doesn't close files after finding id [9.4 (9.4-7-g3eccc5-elpaplus @ ~/spacemacs/elpa/develop/org-plus-contrib-20200921/)] Nicolas Goaziou
2020-10-06 21:36 ` Samuel Wales
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86k0wiyalj.fsf@aa.i-did-not-set--mail-host-address--so-tickle-me \
--to=thisnkk@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.