From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#55977: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message Date: Wed, 15 Jun 2022 10:25:03 +0300 Organization: LINKOV.NET Message-ID: <86k09i5qy8.fsf@mail.linkov.net> References: <87fsk72m0b.fsf@gmail.com> <83y1xzrvn6.fsf@gnu.org> <877d5j2keu.fsf@gmail.com> <87zgif15i9.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23737"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Eli Zaretskii , 55977@debbugs.gnu.org To: Visuwesh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 15 09:27:31 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1NR4-00063L-CP for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jun 2022 09:27:30 +0200 Original-Received: from localhost ([::1]:52514 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o1NR3-0006h1-1X for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jun 2022 03:27:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1NQd-0006gD-Dn for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2022 03:27:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42447) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o1NQc-0005Mr-Mg for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2022 03:27:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o1NQc-0001kG-JY for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2022 03:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Jun 2022 07:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55977 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55977-submit@debbugs.gnu.org id=B55977.16552779676614 (code B ref 55977); Wed, 15 Jun 2022 07:27:02 +0000 Original-Received: (at 55977) by debbugs.gnu.org; 15 Jun 2022 07:26:07 +0000 Original-Received: from localhost ([127.0.0.1]:36336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1NPi-0001ib-S8 for submit@debbugs.gnu.org; Wed, 15 Jun 2022 03:26:07 -0400 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:42681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1NPf-0001ho-1R; Wed, 15 Jun 2022 03:26:05 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 8E8001BF20E; Wed, 15 Jun 2022 07:25:55 +0000 (UTC) In-Reply-To: <87zgif15i9.fsf@gmail.com> (Visuwesh's message of "Tue, 14 Jun 2022 23:39:34 +0530") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234554 Archived-At: close 55977 29.0.50 thanks >>>> repeat-mode echoes unset keys in the help message since it doesn't check >>>> for non-nil value of command bound to key; will attach patch once I get >>>> the bug number. >>> >>> Thanks, but can you please show a recipe from "emacs -Q", to >>> understand better what problem are you trying to fix? >> >> Sure. >> >> 1. M-x repeat-mode RET. >> 2. C-h n. >> 3. M-: (define-key outline-navigation-repeat-map (kbd "C-n") nil). >> 4. C-c @ C-n. Notice how the help message still says C-n despite >> being unbound, and when you type C-n the repeat map exits >> contrary to what the message says. > > Oh, looks like if I give `define-key' a non-nil REMOVE argument, then > C-n is no longer displayed in the help message. Indeed, the REMOVE removes a key, but nil is also a valid way to undefine a key, so now your patch is pushed to master, thanks.