all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Randy Taylor <dev@rjt.dev>
Cc: casouri@gmail.com, 60105@debbugs.gnu.org
Subject: bug#60105: [PATCH] Add yaml-ts-mode
Date: Tue, 03 Jan 2023 20:21:49 +0200	[thread overview]
Message-ID: <86k023v5qa.fsf@mail.linkov.net> (raw)
In-Reply-To: <d4IAgpQk83SggvF-bQ7aBeyaM3Qoww_2iRN_mBibADY6tOP1_lVNO7YwLyZalksjUlVJr_hSUq_SvQOvkU1HSNkuhzUeqcOizr9PNSV84A4=@rjt.dev> (Randy Taylor's message of "Mon, 02 Jan 2023 21:58:57 +0000")

>> But what I propose is to add a customizable option to enable/disable
>> font-lock-string-face on most text to lessen the color burden on users.
>
> I think using treesit-font-lock-recompute-features is the way to
> adjust which features you want, and is what is expected for cases like
> this (but Yuan would know best).

The reason why I proposed a new customizable option is because
ruby-ts-mode provides an option ruby-ts-highlight-predefined-constants
that enables some rules in ruby-ts--font-lock-settings.  But maybe
there is no way to avoid this fine-grained setting in ruby-ts-mode.

But you are right that (treesit-font-lock-recompute-features '() '(string))
is the right way to customize it.

> Alternatively, treesit-font-lock-level dictates which level of
> features should be included for highlighting. The default is level 3,
> and string is on level 2. We can move string to the 4th level, which
> may be an OK compromise?

It would be nice if you will decide to move 'string' to the 4th level
by default since the 4th level is intended for maximal fontification.





  reply	other threads:[~2023-01-03 18:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-15 22:19 bug#60105: [PATCH] Add yaml-ts-mode Randy Taylor
2022-12-16  0:20 ` Stefan Kangas
2022-12-16  2:01   ` Randy Taylor
2022-12-16 22:55 ` Yuan Fu
2023-01-02 18:52 ` Juri Linkov
2023-01-02 21:58   ` Randy Taylor
2023-01-03 18:21     ` Juri Linkov [this message]
2023-01-04 23:30       ` Dmitry Gutov
2023-01-05 18:09         ` Juri Linkov
2023-01-06  1:55           ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86k023v5qa.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=60105@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=dev@rjt.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.