From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#60105: [PATCH] Add yaml-ts-mode Date: Thu, 05 Jan 2023 20:09:22 +0200 Organization: LINKOV.NET Message-ID: <86k02026r1.fsf@mail.linkov.net> References: <864jt8vjyc.fsf@mail.linkov.net> <86k023v5qa.fsf@mail.linkov.net> <9da7be0a-5ce8-f1da-6bb5-10f0c47d20ef@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26754"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Randy Taylor , casouri@gmail.com, 60105@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 05 19:11:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDUi0-0006qp-5D for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Jan 2023 19:11:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDUhk-0000qp-By; Thu, 05 Jan 2023 13:11:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDUhi-0000qX-K8 for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2023 13:11:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pDUhi-0004OX-5n for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2023 13:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pDUhh-0000Cl-N0 for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2023 13:11:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Jan 2023 18:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60105 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60105-submit@debbugs.gnu.org id=B60105.1672942208692 (code B ref 60105); Thu, 05 Jan 2023 18:11:01 +0000 Original-Received: (at 60105) by debbugs.gnu.org; 5 Jan 2023 18:10:08 +0000 Original-Received: from localhost ([127.0.0.1]:52837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDUgp-0000B6-UY for submit@debbugs.gnu.org; Thu, 05 Jan 2023 13:10:08 -0500 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:42059) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDUgm-0000AU-SV for 60105@debbugs.gnu.org; Thu, 05 Jan 2023 13:10:06 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 213CE100004; Thu, 5 Jan 2023 18:09:56 +0000 (UTC) In-Reply-To: <9da7be0a-5ce8-f1da-6bb5-10f0c47d20ef@yandex.ru> (Dmitry Gutov's message of "Thu, 5 Jan 2023 01:30:41 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252623 Archived-At: >> The reason why I proposed a new customizable option is because >> ruby-ts-mode provides an option ruby-ts-highlight-predefined-constants >> that enables some rules in ruby-ts--font-lock-settings. But maybe >> there is no way to avoid this fine-grained setting in ruby-ts-mode. > > But there is. What do you think about this change? > > @@ -202,9 +197,11 @@ ruby-ts--font-lock-settings > > :language language > :feature 'builtin > - `(((global_variable) @var (:match ,ruby-ts--predefined-variables @var)) @font-lock-builtin-face > - ,@(when ruby-ts-highlight-predefined-constants > - `(((constant) @var (:match ,ruby-ts--predefined-constants @var)) > @font-lock-builtin-face))) > + `(((global_variable) @var (:match ,ruby-ts--predefined-variables @var)) @font-lock-builtin-face) > + > + :language language > + :feature 'builtin-constant > + `(((constant) @var (:match ,ruby-ts--predefined-constants @var)) @font-lock-builtin-face) Look like this is a clear name.