From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Date: Mon, 27 Mar 2023 19:39:25 +0300 Organization: LINKOV.NET Message-ID: <86jzz2f8si.fsf@mail.linkov.net> References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35773"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 62427@debbugs.gnu.org, bensonchu457@fastmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 27 18:42:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgpvJ-00094f-ML for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Mar 2023 18:42:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pgpv3-0001sJ-Mu; Mon, 27 Mar 2023 12:42:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgpv1-0001qX-3M for bug-gnu-emacs@gnu.org; Mon, 27 Mar 2023 12:42:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pgpv0-0005zO-AB for bug-gnu-emacs@gnu.org; Mon, 27 Mar 2023 12:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pgpv0-0004N0-5o for bug-gnu-emacs@gnu.org; Mon, 27 Mar 2023 12:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Mar 2023 16:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs Original-Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.167993529716744 (code B ref 62427); Mon, 27 Mar 2023 16:42:02 +0000 Original-Received: (at 62427) by debbugs.gnu.org; 27 Mar 2023 16:41:37 +0000 Original-Received: from localhost ([127.0.0.1]:48318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgpub-0004Lz-52 for submit@debbugs.gnu.org; Mon, 27 Mar 2023 12:41:37 -0400 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:53545) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgpuW-0004LT-Jy for 62427@debbugs.gnu.org; Mon, 27 Mar 2023 12:41:32 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 6D86220005; Mon, 27 Mar 2023 16:41:24 +0000 (UTC) In-Reply-To: <83cz4u9uz1.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 27 Mar 2023 16:36:50 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258760 Archived-At: >> >> > I've noticed that when I call #'tab-bar-new-tab while I'm in a >> >> > side-window that has siblings, I get an error from >> >> > #'window--sides-check, which happens when #'tab-bar-new-tab calls >> >> > #'delete-other-windows. Here's an example of my problem: >> >> > ... >> >> > The attached patch fixes this issue. Could it be applied to the emacs-29 >> >> > branch? >> >> >> >> Thanks. Unless Eli has objections, I'd like to push the patch >> >> to the emacs-29 branch since it correctly fixes the problem. >> > >> > I'd like first to understand better the code involved and the >> > suggested change in it. Just reading the code of tab-bar-new-tab-to, >> > it looks strange. Why does tab-bar.el care about "window parameters >> > that can cause problems with 'delete-other-windows' and >> > 'split-window'" to begin with? And why removing these parameters from >> > windows is TRT for tab-bar.el to resolve such problems, when it >> > doesn't really "own" those windows? >> >> Indeed, maybe 'delete-other-windows' and `split-window' >> should handle these cases. So since the patch fixes the bug, >> it could be pushed to emacs-29. Then in master >> 'delete-other-windows' and `split-window' could be rewritten >> to handle the 'window-side' parameter. > > Maybe I'll agree, but I still don't understand the problem well > enough. Would you please explain the original problem that led > tab-bar.el to care about these window parameters? Sorry, I can't explain. I just did that Martin said to do in bug#53662.