all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: 65631@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#65631: Xref updates stack in case of error
Date: Thu, 31 Aug 2023 19:33:07 +0300	[thread overview]
Message-ID: <86jztb2qkc.fsf@mail.linkov.net> (raw)
In-Reply-To: <c4066920-c547-e366-3f0d-6f44bc94f6b0@gutov.dev> (Dmitry Gutov's message of "Thu, 31 Aug 2023 03:50:53 +0300")

>>>> 1. move point to any word
>>>> 2. type 'M-.' (xref-find-definitions)
>>>> 3. an error is displayed correctly "No definitions found for: This"
>>>>
>>>> But the problem is that an unrecognized word is added to the xref stack.
>>>> So the context menu shows "Go Back", and 'M-,' (xref-go-back) goes back
>>>> to that word.
>>> FWIW, I'm not sure this is necessarily a bug.  It looks like a bug in
>>> your case, because you deliberately tricked Xref into using a word
>>> that is definitely not a program symbol.  But that is not the case in
>>> a more reasonable situation, where point is on a symbol, but for some
>>> reason the symbol's definition is not found, e.g., because the TAGS
>>> table needs to be regenerated.
>> In case of error, point doesn't move.  So there is no need to go back.
>
> At this point, I was kind of feeling that this is a known-but-tolerated
> behavior (that some might already be relying on, also known as "spacebar
> heater" effect), but if it's still annoying, let's see about a fix.

It's not annoying, just surprises with the requirement to type extra ‘M-,’.

> How's the attached patch?

Thanks.  I expected a smaller change, but if this is still reliable,
then why not.  At least, it works in cases that I tested.





  reply	other threads:[~2023-08-31 16:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-30 16:44 bug#65631: Xref updates stack in case of error Juri Linkov
2023-08-30 17:01 ` Eli Zaretskii
2023-08-30 17:16   ` Juri Linkov
2023-08-31  0:50     ` Dmitry Gutov
2023-08-31 16:33       ` Juri Linkov [this message]
2023-09-01  1:39         ` Dmitry Gutov
2023-09-01 13:25 ` Mattias Engdegård
2023-09-02  2:00   ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86jztb2qkc.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=65631@debbugs.gnu.org \
    --cc=dmitry@gutov.dev \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.