all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: raman@google.com, emacs-devel@gnu.org
Subject: Re: Faces for strong, emph and friends in Info?
Date: Mon, 08 Apr 2024 21:27:43 +0300	[thread overview]
Message-ID: <86jzl7yajk.fsf@gnu.org> (raw)
In-Reply-To: <87o7ajssgp.fsf@gmail.com> (message from Robert Pluim on Mon, 08 Apr 2024 18:57:10 +0200)

> From: Robert Pluim <rpluim@gmail.com>
> Cc: "T.V Raman" <raman@google.com>,  emacs-devel@gnu.org
> Date: Mon, 08 Apr 2024 18:57:10 +0200
> 
>     Eli> I think it's just that no one has written the code to show *foo* and
>     Eli> _foo_ as italics and bold (and hide the _ and * characters).  Of
>     Eli> course, this will cause some lines be shorter or longer than they are
>     Eli> supposed to be, but maybe this is a worthwhile price to pay.
> 
>     Eli> Patches welcome.
> 
> How robust do you want this to be?

As robust as possible, of course.

> +(defface Info-strong
> +  '((t :inherit bold))
> +  "Face used for *strong* elements."
> +  :version "30.1")

We need fallback for terminals that don't support bold.  Some
stand-out color, perhaps?

Also, the doc string should mention Info mode.

> +      (while (re-search-forward "\\([*_]\\)\\([^*_\n]+\\)\\([*_]\\)" nil t)

This is too fragile, I think.  It matches stuff like "*Note foo_",
which can happen in cross-references, for example.  Also, what if
@emph or @strong spans a newline?

Thanks.



  parent reply	other threads:[~2024-04-08 18:27 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-08 14:49 Faces for strong, emph and friends in Info? T.V Raman
2024-04-08 14:59 ` Eli Zaretskii
2024-04-08 16:57   ` Robert Pluim
2024-04-08 17:28     ` T.V Raman
2024-04-08 18:06     ` [External] : " Drew Adams
2024-04-08 18:27     ` Eli Zaretskii [this message]
2024-04-08 19:32       ` Drew Adams
2024-04-09  9:01       ` Robert Pluim
2024-04-09  9:56         ` Eli Zaretskii
2024-04-10 16:11           ` Robert Pluim
2024-04-10 16:17             ` T.V Raman
2024-04-10 16:27               ` Robert Pluim
2024-04-10 16:53                 ` Eli Zaretskii
2024-04-11 12:59                   ` Robert Pluim
2024-04-11 14:10                     ` T.V Raman
2024-04-10 16:51             ` Eli Zaretskii
2024-04-08 22:02     ` T.V Raman
2024-04-08 22:29     ` T.V Raman
2024-04-09  1:47       ` [External] : " Drew Adams
2024-04-09  2:23         ` T.V Raman
2024-04-09  4:22           ` Eli Zaretskii
2024-04-09  1:35     ` T.V Raman
2024-04-09  4:21       ` Eli Zaretskii
2024-04-09 13:29         ` T.V Raman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86jzl7yajk.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=raman@google.com \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.