Re: Add Tango and Adwaita icons for the toolbar

Re: Add Tango and Adwaita icons for the toolbar

[Elijah G]

[-- Attachment #1: Type: text/plain, Size: 599 bytes --]

Yuan Fu <casouri@gmail.com> writes:
> I certainly would like to have xpm and bpm versions for the new
> icons, but as I said, I’m no graphic designer and have no ability to
hand-draw
> them; the only thing I can do is to convert them from png, which you also
> against. (Though, to be fair, even if I have the
> ability, I probably wouldn’t want to, it’s a lot of work to hand draw all
these icons.)

Hi, I'm interested in help to convert the icons into xpm and bpm, i think
the process would be faster if the original icons are in svg otherwise i
can make my best effort in help.

[-- Attachment #2: Type: text/html, Size: 849 bytes --]

Re: Add Tango and Adwaita icons for the toolbar

[Yuan Fu]

> On May 4, 2024, at 11:57 PM, Yuan Fu <casouri@gmail.com> wrote:
> 
> 
> 
>> On May 4, 2024, at 9:07 PM, Elijah G <eg642616@gmail.com> wrote:
>> 
>> Yuan Fu <casouri@gmail.com> writes:
>>> I certainly would like to have xpm and bpm versions for the new
>>> icons, but as I said, I’m no graphic designer and have no ability to hand-draw 
>>> them; the only thing I can do is to convert them from png, which you also
>>> against. (Though, to be fair, even if I have the
>>> ability, I probably wouldn’t want to, it’s a lot of work to hand draw all these icons.)
>> 
>> Hi, I'm interested in help to convert the icons into xpm and bpm, i think the process would be faster if the original icons are in svg otherwise i can make my best effort in help.
> 
> That’s great news! You can find the svg icons I made in etc/images/scalable in the scratch/tango-icons branch. You can get that branch by
> 
> git clone -b scratch/tango-icons git://git.sv.gnu.org/emacs.git

And before anyone comments on the commit messages on that branch: I’ll squash and write proper commit messages later.

Yuan

Re: Add Tango and Adwaita icons for the toolbar

[Po Lu]

Yuan Fu <casouri@gmail.com> writes:

>> On May 4, 2024, at 9:07 PM, Elijah G <eg642616@gmail.com> wrote:
>> 
>> Yuan Fu <casouri@gmail.com> writes:
>> > I certainly would like to have xpm and bpm versions for the new
>> > icons, but as I said, I’m no graphic designer and have no ability to hand-draw 
>> > them; the only thing I can do is to convert them from png, which you also
>> > against. (Though, to be fair, even if I have the
>> > ability, I probably wouldn’t want to, it’s a lot of work to hand draw all these icons.)
>> 
>> Hi, I'm interested in help to convert the icons into xpm and bpm, i
>> think the process would be faster if the original icons are in svg
>> otherwise i can make my best effort in help.
>
> That’s great news! You can find the svg icons I made in
> etc/images/scalable in the scratch/tango-icons branch. You can get
> that branch by
>
> git clone -b scratch/tango-icons git://git.sv.gnu.org/emacs.git
>
> That branch is modified to load the png icons in etc/images for the
> tool-bar (assuming you’re using a mac, on Linux Emacs will use the
> system icons).
>
> If you’d like to, feel free to improve the svg icons I made too. I
> also attached the svg tango and adwaita icons that I used, in case
> they’ll be useful.
>
>
>
>
> Yuan

Thanks, but in future, please resist the impulse to post an 11.5 MB
attachment to a public mailing list...

Re: Add Tango and Adwaita icons for the toolbar

[Yuan Fu]

> On May 5, 2024, at 1:07 AM, Po Lu <luangruo@yahoo.com> wrote:
> 
> Yuan Fu <casouri@gmail.com> writes:
> 
>>> On May 4, 2024, at 9:07 PM, Elijah G <eg642616@gmail.com> wrote:
>>> 
>>> Yuan Fu <casouri@gmail.com> writes:
>>>> I certainly would like to have xpm and bpm versions for the new
>>>> icons, but as I said, I’m no graphic designer and have no ability to hand-draw 
>>>> them; the only thing I can do is to convert them from png, which you also
>>>> against. (Though, to be fair, even if I have the
>>>> ability, I probably wouldn’t want to, it’s a lot of work to hand draw all these icons.)
>>> 
>>> Hi, I'm interested in help to convert the icons into xpm and bpm, i
>>> think the process would be faster if the original icons are in svg
>>> otherwise i can make my best effort in help.
>> 
>> That’s great news! You can find the svg icons I made in
>> etc/images/scalable in the scratch/tango-icons branch. You can get
>> that branch by
>> 
>> git clone -b scratch/tango-icons git://git.sv.gnu.org/emacs.git
>> 
>> That branch is modified to load the png icons in etc/images for the
>> tool-bar (assuming you’re using a mac, on Linux Emacs will use the
>> system icons).
>> 
>> If you’d like to, feel free to improve the svg icons I made too. I
>> also attached the svg tango and adwaita icons that I used, in case
>> they’ll be useful.
>> 
>> 
>> 
>> 
>> Yuan
> 
> Thanks, but in future, please resist the impulse to post an 11.5 MB
> attachment to a public mailing list…

Ohhhh, right… :-( Should I contact someone to remove it from the archive or something?

Yuan

Re: Add Tango and Adwaita icons for the toolbar

[Elijah G]

[-- Attachment #1: Type: text/plain, Size: 1624 bytes --]

El dom., 5 de mayo de 2024 12:57 a. m., Yuan Fu <casouri@gmail.com>
escribió:

>
>
> > On May 4, 2024, at 9:07 PM, Elijah G <eg642616@gmail.com> wrote:
> >
> > Yuan Fu <casouri@gmail.com> writes:
> > > I certainly would like to have xpm and bpm versions for the new
> > > icons, but as I said, I’m no graphic designer and have no ability to
> hand-draw
> > > them; the only thing I can do is to convert them from png, which you
> also
> > > against. (Though, to be fair, even if I have the
> > > ability, I probably wouldn’t want to, it’s a lot of work to hand draw
> all these icons.)
> >
> > Hi, I'm interested in help to convert the icons into xpm and bpm, i
> think the process would be faster if the original icons are in svg
> otherwise i can make my best effort in help.
>
> That’s great news! You can find the svg icons I made in
> etc/images/scalable in the scratch/tango-icons branch. You can get that
> branch by
>
> git clone -b scratch/tango-icons git://git.sv.gnu.org/emacs.git
>
> That branch is modified to load the png icons in etc/images for the
> tool-bar (assuming you’re using a mac, on Linux Emacs will use the system
> icons).
>
> If you’d like to, feel free to improve the svg icons I made too. I also
> attached the svg tango and adwaita icons that I used, in case they’ll be
> useful.
>

Thank you, i have a question, should i send a patch to this thread when i
have the icons?

Also i've also read etc/images/scalable README file about some missing
icons, i would like also provide them by myself keeping the tango (or
adwaita) style.

>

[-- Attachment #2: Type: text/html, Size: 2437 bytes --]

Re: Add Tango and Adwaita icons for the toolbar

[Yuan Fu]

> On May 5, 2024, at 10:10 PM, Elijah G <eg642616@gmail.com> wrote:
> 
> El dom., 5 de mayo de 2024 12:57 a. m., Yuan Fu <casouri@gmail.com> escribió:
> 
> 
> > On May 4, 2024, at 9:07 PM, Elijah G <eg642616@gmail.com> wrote:
> > 
> > Yuan Fu <casouri@gmail.com> writes:
> > > I certainly would like to have xpm and bpm versions for the new
> > > icons, but as I said, I’m no graphic designer and have no ability to hand-draw 
> > > them; the only thing I can do is to convert them from png, which you also
> > > against. (Though, to be fair, even if I have the
> > > ability, I probably wouldn’t want to, it’s a lot of work to hand draw all these icons.)
> > 
> > Hi, I'm interested in help to convert the icons into xpm and bpm, i think the process would be faster if the original icons are in svg otherwise i can make my best effort in help.
> 
> That’s great news! You can find the svg icons I made in etc/images/scalable in the scratch/tango-icons branch. You can get that branch by
> 
> git clone -b scratch/tango-icons git://git.sv.gnu.org/emacs.git
> 
> That branch is modified to load the png icons in etc/images for the tool-bar (assuming you’re using a mac, on Linux Emacs will use the system icons).
> 
> If you’d like to, feel free to improve the svg icons I made too. I also attached the svg tango and adwaita icons that I used, in case they’ll be useful.
> 
> Thank you, i have a question, should i send a patch to this thread when i have the icons?

Sending large files on the mailing list doesn’t seem like a good idea, maybe we can collaborate on GitHub/sourcehut? Let me know which one you’d prefer, or if you have better ideas.

> Also i've also read etc/images/scalable README file about some missing icons, i would like also provide them by myself keeping the tango (or adwaita) style.

That’s great! If you don’t mind, maybe also look at the icon for index. The current xpm icon has a hand plus a page, the one I made is missing the hand. 

Yuan 

Re: Add Tango and Adwaita icons for the toolbar

[Elijah G]

On Sun, May 5, 2024 at 11:32 PM Yuan Fu <casouri@gmail.com> wrote:
>
>
>
> > On May 5, 2024, at 10:10 PM, Elijah G <eg642616@gmail.com> wrote:
> >
> > El dom., 5 de mayo de 2024 12:57 a. m., Yuan Fu <casouri@gmail.com> escribió:
> >
> >
> > > On May 4, 2024, at 9:07 PM, Elijah G <eg642616@gmail.com> wrote:
> > >
> > > Yuan Fu <casouri@gmail.com> writes:
> > > > I certainly would like to have xpm and bpm versions for the new
> > > > icons, but as I said, I’m no graphic designer and have no ability to hand-draw
> > > > them; the only thing I can do is to convert them from png, which you also
> > > > against. (Though, to be fair, even if I have the
> > > > ability, I probably wouldn’t want to, it’s a lot of work to hand draw all these icons.)
> > >
> > > Hi, I'm interested in help to convert the icons into xpm and bpm, i think the process would be faster if the original icons are in svg otherwise i can make my best effort in help.
> >
> > That’s great news! You can find the svg icons I made in etc/images/scalable in the scratch/tango-icons branch. You can get that branch by
> >
> > git clone -b scratch/tango-icons git://git.sv.gnu.org/emacs.git
> >
> > That branch is modified to load the png icons in etc/images for the tool-bar (assuming you’re using a mac, on Linux Emacs will use the system icons).
> >
> > If you’d like to, feel free to improve the svg icons I made too. I also attached the svg tango and adwaita icons that I used, in case they’ll be useful.
> >
> > Thank you, i have a question, should i send a patch to this thread when i have the icons?
>
> Sending large files on the mailing list doesn’t seem like a good idea, maybe we can collaborate on GitHub/sourcehut? Let me know which one you’d prefer, or if you have better ideas.

I prefer using GitHub since I don't know how to use sourcehut,
i've created a repo where its stored the icons that i made + patch file,

https://github.com/DevelopmentCool2449/emacs/tree/scratch/tango-icons

Patch file: https://raw.githubusercontent.com/DevelopmentCool2449/emacs/scratch/tango-icons/PATCH-0001-Convert-and-change-tango-icons-to-xpm-and-pbm.patch

Currently i only completed some icons, i will try to complete the remain
the next days.

But in short, the xpm and pbm are a little different from the originals,
(i had to make ones by hand), i've recolored the close.* icons to a red-ish one.
Now i've added 1 hand to index.* icons (it may be a bit ugly since i
find hard drawing hands)

if anyone have any commentary, i would gladly listen them.

Re: Add Tango and Adwaita icons for the toolbar

[Yuan Fu]

> On May 6, 2024, at 9:18 PM, Elijah G <eg642616@gmail.com> wrote:
> 
> On Sun, May 5, 2024 at 11:32 PM Yuan Fu <casouri@gmail.com> wrote:
>> 
>> 
>> 
>>> On May 5, 2024, at 10:10 PM, Elijah G <eg642616@gmail.com> wrote:
>>> 
>>> El dom., 5 de mayo de 2024 12:57 a. m., Yuan Fu <casouri@gmail.com> escribió:
>>> 
>>> 
>>>> On May 4, 2024, at 9:07 PM, Elijah G <eg642616@gmail.com> wrote:
>>>> 
>>>> Yuan Fu <casouri@gmail.com> writes:
>>>>> I certainly would like to have xpm and bpm versions for the new
>>>>> icons, but as I said, I’m no graphic designer and have no ability to hand-draw
>>>>> them; the only thing I can do is to convert them from png, which you also
>>>>> against. (Though, to be fair, even if I have the
>>>>> ability, I probably wouldn’t want to, it’s a lot of work to hand draw all these icons.)
>>>> 
>>>> Hi, I'm interested in help to convert the icons into xpm and bpm, i think the process would be faster if the original icons are in svg otherwise i can make my best effort in help.
>>> 
>>> That’s great news! You can find the svg icons I made in etc/images/scalable in the scratch/tango-icons branch. You can get that branch by
>>> 
>>> git clone -b scratch/tango-icons git://git.sv.gnu.org/emacs.git
>>> 
>>> That branch is modified to load the png icons in etc/images for the tool-bar (assuming you’re using a mac, on Linux Emacs will use the system icons).
>>> 
>>> If you’d like to, feel free to improve the svg icons I made too. I also attached the svg tango and adwaita icons that I used, in case they’ll be useful.
>>> 
>>> Thank you, i have a question, should i send a patch to this thread when i have the icons?
>> 
>> Sending large files on the mailing list doesn’t seem like a good idea, maybe we can collaborate on GitHub/sourcehut? Let me know which one you’d prefer, or if you have better ideas.
> 
> I prefer using GitHub since I don't know how to use sourcehut,
> i've created a repo where its stored the icons that i made + patch file,
> 
> https://github.com/DevelopmentCool2449/emacs/tree/scratch/tango-icons
> 
> Patch file: https://raw.githubusercontent.com/DevelopmentCool2449/emacs/scratch/tango-icons/PATCH-0001-Convert-and-change-tango-icons-to-xpm-and-pbm.patch
> 
> Currently i only completed some icons, i will try to complete the remain
> the next days.
> 
> But in short, the xpm and pbm are a little different from the originals,
> (i had to make ones by hand), i've recolored the close.* icons to a red-ish one.
> Now i've added 1 hand to index.* icons (it may be a bit ugly since i
> find hard drawing hands)
> 
> if anyone have any commentary, i would gladly listen them.

Looks great!

I see that you replaced the current xpm and bpm with new files. I’m fine with that, but I wonder what others think.

Yuan

Re: Add Tango and Adwaita icons for the toolbar

[Elijah G]

On Tue, May 7, 2024 at 6:22 PM Yuan Fu <casouri@gmail.com> wrote:
>
>
>
> > On May 6, 2024, at 9:18 PM, Elijah G <eg642616@gmail.com> wrote:
> >
> > On Sun, May 5, 2024 at 11:32 PM Yuan Fu <casouri@gmail.com> wrote:
> >>
> >>
> >>
> >>> On May 5, 2024, at 10:10 PM, Elijah G <eg642616@gmail.com> wrote:
> >>>
> >>> El dom., 5 de mayo de 2024 12:57 a. m., Yuan Fu <casouri@gmail.com> escribió:
> >>>
> >>>
> >>>> On May 4, 2024, at 9:07 PM, Elijah G <eg642616@gmail.com> wrote:
> >>>>
> >>>> Yuan Fu <casouri@gmail.com> writes:
> >>>>> I certainly would like to have xpm and bpm versions for the new
> >>>>> icons, but as I said, I’m no graphic designer and have no ability to hand-draw
> >>>>> them; the only thing I can do is to convert them from png, which you also
> >>>>> against. (Though, to be fair, even if I have the
> >>>>> ability, I probably wouldn’t want to, it’s a lot of work to hand draw all these icons.)
> >>>>
> >>>> Hi, I'm interested in help to convert the icons into xpm and bpm, i think the process would be faster if the original icons are in svg otherwise i can make my best effort in help.
> >>>
> >>> That’s great news! You can find the svg icons I made in etc/images/scalable in the scratch/tango-icons branch. You can get that branch by
> >>>
> >>> git clone -b scratch/tango-icons git://git.sv.gnu.org/emacs.git
> >>>
> >>> That branch is modified to load the png icons in etc/images for the tool-bar (assuming you’re using a mac, on Linux Emacs will use the system icons).
> >>>
> >>> If you’d like to, feel free to improve the svg icons I made too. I also attached the svg tango and adwaita icons that I used, in case they’ll be useful.
> >>>
> >>> Thank you, i have a question, should i send a patch to this thread when i have the icons?
> >>
> >> Sending large files on the mailing list doesn’t seem like a good idea, maybe we can collaborate on GitHub/sourcehut? Let me know which one you’d prefer, or if you have better ideas.
> >
> > I prefer using GitHub since I don't know how to use sourcehut,
> > i've created a repo where its stored the icons that i made + patch file,
> >
> > https://github.com/DevelopmentCool2449/emacs/tree/scratch/tango-icons
> >
> > Patch file: https://raw.githubusercontent.com/DevelopmentCool2449/emacs/scratch/tango-icons/PATCH-0001-Convert-and-change-tango-icons-to-xpm-and-pbm.patch
> >
> > Currently i only completed some icons, i will try to complete the remain
> > the next days.
> >
> > But in short, the xpm and pbm are a little different from the originals,
> > (i had to make ones by hand), i've recolored the close.* icons to a red-ish one.
> > Now i've added 1 hand to index.* icons (it may be a bit ugly since i
> > find hard drawing hands)
> >
> > if anyone have any commentary, i would gladly listen them.
>
> Looks great!
>
> I see that you replaced the current xpm and bpm with new files. I’m fine with that, but I wonder what others think.

It's only temporary, I had to do that to test them in Windows, when I
have all the icons done I will move them to a separate folder.
Also watching this thread I was wondering why not add optional svg
icons if emacs supports it (and make them default), like how the
current icons in the toolbar does.
Windows port allows svg icons in the toolbar and resize them, svg has
more quality and allows better resize than png.

Re: Add Tango and Adwaita icons for the toolbar

[Elijah G]

[-- Attachment #1: Type: text/plain, Size: 924 bytes --]

Good news,
I've completed the icons and added a
few, i couldn't provide new icons to mh-logo,
sort-row-ascending and sort-column-ascending
(the first one due i don't know what `mh' means and the others due I
couldn't think in a good design).
I had plans for provide new icons in png for modifier keys icons from
modifier-bar-mode from android port but i dont know if there is interest in
that.
The new icons can be found in the
etc/images/tango folder from my repo.

Also sorry If this is off topic:

Also i would like to know if there are plans for
add a redo button in the tool-bar, there is a redo
button in menu-bar Edit section but no in the
tool-bar.

I case there are plans im sending here a little
snippet that i use in my setup if this can help:
(tool-bar-add-item-from-menu 'undo-redo "redo" nil)

  (keymap-set-after (default-value 'tool-bar-map) "<undo-redo>"
    (cdr (assq 'undo-redo tool-bar-map))
    'undo)

[-- Attachment #2: Type: text/html, Size: 1492 bytes --]

Re: Add Tango and Adwaita icons for the toolbar

[Yuan Fu]

> On May 8, 2024, at 8:52 PM, Elijah G <eg642616@gmail.com> wrote:
> 
> Good news,
> I've completed the icons and added a
> few, i couldn't provide new icons to mh-logo,
> sort-row-ascending and sort-column-ascending
> (the first one due i don't know what `mh' means and the others due I couldn't think in a good design).
> I had plans for provide new icons in png for modifier keys icons from modifier-bar-mode from android port but i dont know if there is interest in that.
> The new icons can be found in the
> etc/images/tango folder from my repo.

I think they look great! I also like the red close icon, that’ll be more friendly to dark themes. The remaining work is to figure out how to correctly load the icons into toolbar. We also need some way to opt-out of the new icons. I’ll try to figure it out.

Yuan

Re: Add Tango and Adwaita icons for the toolbar

[Elijah G.]

[-- Attachment #1: Type: text/plain, Size: 1035 bytes --]

Yuan Fu <casouri@gmail.com> writes:

>> On May 8, 2024, at 8:52 PM, Elijah G <eg642616@gmail.com> wrote:
>> 
>> Good news,
>> I've completed the icons and added a
>> few, i couldn't provide new icons to mh-logo,
>> sort-row-ascending and sort-column-ascending
>> (the first one due i don't know what `mh' means and the others due I couldn't think in a good design).
>> I had plans for provide new icons in png for modifier keys icons from modifier-bar-mode from android port but i dont know if there is interest in that.
>> The new icons can be found in the
>> etc/images/tango folder from my repo.
>
> We also need some way to opt-out of the new icons. I’ll try to figure
> it out.

I've made a litle patch that can help in that (note: I've not tested it
yet and i don't think i can test it :( ).
The new icons are enabled by default but it can be switched to the
current ones (also i think that defcustom should specify that it must
be set in early-init.el because AFAIK tool-bar can not refresh the icons).


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: PATCH --]
[-- Type: text/x-patch, Size: 2833 bytes --]

From 2531aebfd21de84261834d189fda87844e92b1f5 Mon Sep 17 00:00:00 2001
From: "Elias G. Perez" <eg642616@gmail.com>
Date: Thu, 9 May 2024 19:18:43 -0600
Subject: [PATCH] SVG and tango icon theme support

---
 lisp/tool-bar.el | 24 +++++++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)

diff --git a/lisp/tool-bar.el b/lisp/tool-bar.el
index 20efddb..d183123 100644
--- a/lisp/tool-bar.el
+++ b/lisp/tool-bar.el
@@ -211,25 +211,43 @@ To define items in any other map, use `tool-bar-local-item'."
   (apply #'tool-bar-local-item icon def key tool-bar-map props)
   (tool-bar--flush-cache))
 
+(defcustom tool-bar-icon-theme 'tango
+  "Specify icon theme for tool-bar.
+Possible values are `tango' and `classic'"
+  :type 'symbol)
+
 (defun tool-bar--image-expression (icon)
   "Return an expression that evaluates to an image spec for ICON."
   (let* ((fg (face-attribute 'tool-bar :foreground))
 	 (bg (face-attribute 'tool-bar :background))
 	 (colors (nconc (if (eq fg 'unspecified) nil (list :foreground fg))
 			(if (eq bg 'unspecified) nil (list :background bg))))
-	 (xpm-spec (list :type 'xpm :file (concat icon ".xpm")))
+	 (xpm-spec (list :type 'xpm :file
+                         (concat icon
+                                 (if (eq tool-bar-icon-theme 'tango) "tango/")
+                                 ".xpm")))
 	 (xpm-lo-spec (list :type 'xpm :file
 			    (concat "low-color/" icon ".xpm")))
 	 (pbm-spec (append (list :type 'pbm :file
-                                 (concat icon ".pbm")) colors))
+                                 (concat icon
+                                         (if (eq tool-bar-icon-theme 'tango) "tango/")
+                                         ".pbm")) colors))
 	 (xbm-spec (append (list :type 'xbm :file
                                  (concat icon ".xbm")) colors))
          (png-spec (append (list :type 'png :file
-                                 (concat icon ".png")) colors)))
+                                 (concat icon
+                                         (if (eq tool-bar-icon-theme 'tango) "tango/")
+                                         ".png")) colors))
+         (svg-spec (append (list :type 'svg :file
+                                 (concat icon
+                                         (if (eq tool-bar-icon-theme 'tango) "tango/")
+                                         ".svg")) colors)))
     `(find-image (cond ((not (display-color-p))
 			',(list pbm-spec xbm-spec xpm-lo-spec xpm-spec))
 		       ((< (display-color-cells) 256)
 			',(list xpm-lo-spec xpm-spec pbm-spec xbm-spec))
+                       ((fboundp 'svg-image)
+                        ',(list png-spec xpm-spec pbm-spec xbm-spec svg-spec))
 		       (t
 			',(list png-spec xpm-spec pbm-spec xbm-spec)))
                  t)))
-- 
2.44.0.windows.1

Re: Add Tango and Adwaita icons for the toolbar

[Eli Zaretskii]

> From: "Elijah G." <eg642616@gmail.com>
> Cc: <emacs-devel@gnu.org>,  Po Lu <luangruo@yahoo.com>
> Date: Thu, 09 May 2024 20:04:03 -0600
> 
> > We also need some way to opt-out of the new icons. I’ll try to figure
> > it out.
> 
> I've made a litle patch that can help in that (note: I've not tested it
> yet and i don't think i can test it :( ).
> The new icons are enabled by default but it can be switched to the
> current ones (also i think that defcustom should specify that it must
> be set in early-init.el because AFAIK tool-bar can not refresh the icons).

Is "tool-bar theme" really a good idea for this?  AFAIK, we didn't
decide to introduce "tool-bar themes", and so doing this as part of
adding new icons is not TRT, it should be a separate and
well-documented decision, since the results are visible to users.

> +	 (xpm-spec (list :type 'xpm :file
> +                         (concat icon
> +                                 (if (eq tool-bar-icon-theme 'tango) "tango/")
> +                                 ".xpm")))

Shouldn't you _prepend_ "tango/" to the icon's file name?

In any case, I find this way of implementing a tool-bar theme
inelegant: we'd need a test for each supported theme, which doesn't
scale.

This issue needs more thought and discussions.  Let's not mix the new
icons with this "theme" issue.

Re: Add Tango and Adwaita icons for the toolbar

[Elijah G.]

[-- Attachment #1: Type: text/plain, Size: 1988 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: "Elijah G." <eg642616@gmail.com>
>> Cc: <emacs-devel@gnu.org>,  Po Lu <luangruo@yahoo.com>
>> Date: Thu, 09 May 2024 20:04:03 -0600
>> 
>> > We also need some way to opt-out of the new icons. I’ll try to figure
>> > it out.
>> 
>> I've made a litle patch that can help in that (note: I've not tested it
>> yet and i don't think i can test it :( ).
>> The new icons are enabled by default but it can be switched to the
>> current ones (also i think that defcustom should specify that it must
>> be set in early-init.el because AFAIK tool-bar can not refresh the icons).
>
> Is "tool-bar theme" really a good idea for this?  AFAIK, we didn't
> decide to introduce "tool-bar themes", and so doing this as part of
> adding new icons is not TRT, it should be a separate and
> well-documented decision, since the results are visible to users.

I didn't mean a tool-bar theme, i didn't know how to name to that
defcustom so i thought in name it `tool-bar-icon-theme', i was thinking
in something like tool-bar-icon-style or similar since that patch
is only a draft.

>> +	 (xpm-spec (list :type 'xpm :file
>> +                         (concat icon
>> +                                 (if (eq tool-bar-icon-theme 'tango) "tango/")
>> +                                 ".xpm")))
>
> Shouldn't you _prepend_ "tango/" to the icon's file name?

Sorry i thought it was prepended it.

> In any case, I find this way of implementing a tool-bar theme
> inelegant: we'd need a test for each supported theme, which doesn't
> scale.
>
> This issue needs more thought and discussions.  Let's not mix the new
> icons with this "theme" issue.

Sorry, wasn't my intention making another issue, it was just an idea
based in the other messages of this thread about making the new icons
as an optional feature and allow change them to the original (current)
ones, this patch was intended to be used as base for this.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: FIXED PATCH --]
[-- Type: text/x-patch, Size: 2976 bytes --]

From 49019a3938269ae2ecf7e55df943e6808fb86eb6 Mon Sep 17 00:00:00 2001
From: "Elias G. Perez" <eg642616@gmail.com>
Date: Thu, 9 May 2024 19:18:43 -0600
Subject: [PATCH] SVG and tango icon theme support

---
 lisp/tool-bar.el | 29 ++++++++++++++++++++++++++---
 1 file changed, 26 insertions(+), 3 deletions(-)

diff --git a/lisp/tool-bar.el b/lisp/tool-bar.el
index 20efddb..5a466bf 100644
--- a/lisp/tool-bar.el
+++ b/lisp/tool-bar.el
@@ -211,25 +211,48 @@ To define items in any other map, use `tool-bar-local-item'."
   (apply #'tool-bar-local-item icon def key tool-bar-map props)
   (tool-bar--flush-cache))
 
+(defcustom tool-bar-icon-style 'tango
+  "Specify icon style to use in tool-bar.
+Possible values are `tango' and `classic'.
+
+If Emacs supports GTK it will use current icon theme.
+
+This variable should be set in your `early-init.el'."
+  :type 'symbol
+  :group 'frames)
+
 (defun tool-bar--image-expression (icon)
   "Return an expression that evaluates to an image spec for ICON."
   (let* ((fg (face-attribute 'tool-bar :foreground))
 	 (bg (face-attribute 'tool-bar :background))
 	 (colors (nconc (if (eq fg 'unspecified) nil (list :foreground fg))
 			(if (eq bg 'unspecified) nil (list :background bg))))
-	 (xpm-spec (list :type 'xpm :file (concat icon ".xpm")))
+	 (xpm-spec (list :type 'xpm :file
+                         (concat (if (eq tool-bar-icon-theme 'tango) "tango/")
+                                 icon
+                                 ".xpm")))
 	 (xpm-lo-spec (list :type 'xpm :file
 			    (concat "low-color/" icon ".xpm")))
 	 (pbm-spec (append (list :type 'pbm :file
-                                 (concat icon ".pbm")) colors))
+                                 (concat (if (eq tool-bar-icon-theme 'tango) "tango/")
+                                         icon
+                                         ".pbm")) colors))
 	 (xbm-spec (append (list :type 'xbm :file
                                  (concat icon ".xbm")) colors))
          (png-spec (append (list :type 'png :file
-                                 (concat icon ".png")) colors)))
+                                 (concat (if (eq tool-bar-icon-theme 'tango) "tango/")
+                                         icon
+                                         ".png")) colors))
+         (svg-spec (append (list :type 'svg :file
+                                 (concat (if (eq tool-bar-icon-theme 'tango) "tango/")
+                                         icon
+                                         ".svg")) colors)))
     `(find-image (cond ((not (display-color-p))
 			',(list pbm-spec xbm-spec xpm-lo-spec xpm-spec))
 		       ((< (display-color-cells) 256)
 			',(list xpm-lo-spec xpm-spec pbm-spec xbm-spec))
+                       ((fboundp 'svg-image)
+                        ',(list png-spec xpm-spec pbm-spec xbm-spec svg-spec))
 		       (t
 			',(list png-spec xpm-spec pbm-spec xbm-spec)))
                  t)))
-- 
2.44.0.windows.1

Re: Add Tango and Adwaita icons for the toolbar

[Yuan Fu]

> On May 10, 2024, at 8:43 AM, Elijah G. <eg642616@gmail.com> wrote:
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
>>> From: "Elijah G." <eg642616@gmail.com>
>>> Cc: <emacs-devel@gnu.org>,  Po Lu <luangruo@yahoo.com>
>>> Date: Thu, 09 May 2024 20:04:03 -0600
>>> 
>>>> We also need some way to opt-out of the new icons. I’ll try to figure
>>>> it out.
>>> 
>>> I've made a litle patch that can help in that (note: I've not tested it
>>> yet and i don't think i can test it :( ).
>>> The new icons are enabled by default but it can be switched to the
>>> current ones (also i think that defcustom should specify that it must
>>> be set in early-init.el because AFAIK tool-bar can not refresh the icons).
>> 
>> Is "tool-bar theme" really a good idea for this?  AFAIK, we didn't
>> decide to introduce "tool-bar themes", and so doing this as part of
>> adding new icons is not TRT, it should be a separate and
>> well-documented decision, since the results are visible to users.
> 
> I didn't mean a tool-bar theme, i didn't know how to name to that
> defcustom so i thought in name it `tool-bar-icon-theme', i was thinking
> in something like tool-bar-icon-style or similar since that patch
> is only a draft.
> 
>>> +  (xpm-spec (list :type 'xpm :file
>>> +                         (concat icon
>>> +                                 (if (eq tool-bar-icon-theme 'tango) "tango/")
>>> +                                 ".xpm")))
>> 
>> Shouldn't you _prepend_ "tango/" to the icon's file name?
> 
> Sorry i thought it was prepended it.
> 
>> In any case, I find this way of implementing a tool-bar theme
>> inelegant: we'd need a test for each supported theme, which doesn't
>> scale.
>> 
>> This issue needs more thought and discussions.  Let's not mix the new
>> icons with this "theme" issue.
> 
> Sorry, wasn't my intention making another issue, it was just an idea
> based in the other messages of this thread about making the new icons
> as an optional feature and allow change them to the original (current)
> ones, this patch was intended to be used as base for this.

No need to be sorry, there’s nothing wrong suggesting a solution, whether or not it’s accepted in the end :-)

As for the “theme” issue, I agree it’s best to leave it out for now. I’m hoping to reuse Stefan K’s icon theme in icons.el (which is in the scratch/icons branch). And for us, we can just focus on _providing_ the icons for now, and not worry about how to make Emacs use them.

Yuan

Re: Redo button on the tool bar

[Eli Zaretskii]

> From: Elijah G <eg642616@gmail.com>
> Date: Wed, 8 May 2024 21:52:31 -0600
> Cc: "Ergus via Emacs development discussions." <emacs-devel@gnu.org>,
>  Po Lu <luangruo@yahoo.com>
> 
> Also sorry If this is off topic:

Please always start a new thread of discussion for unrelated issues.
I did that now.

> Also i would like to know if there are plans for
> add a redo button in the tool-bar, there is a redo
> button in menu-bar Edit section but no in the
> tool-bar.

Is that used frequently enough to justify an icon?  We need to
consider the limited screen estate on the tool bar, and only put there
buttons for very popular commands.  Undo certainly fits that bill, but
undo-redo? not so sure.

Re: Redo button on the tool bar

[Elijah G.]

Eli Zaretskii <eliz@gnu.org> writes:

> Please always start a new thread of discussion for unrelated issues.
> I did that now.
>
>> Also i would like to know if there are plans for
>> add a redo button in the tool-bar, there is a redo
>> button in menu-bar Edit section but no in the
>> tool-bar.
>
> Is that used frequently enough to justify an icon?  We need to
> consider the limited screen estate on the tool bar, and only put there
> buttons for very popular commands.  Undo certainly fits that bill, but
> undo-redo? not so sure.

Undo and Redo are very common in most text editor such as GVim,
notepad++, etc.

undo-redo (like undo) is a very used command today, i think that adding it
can add a plus forward a more friendly Emacs (especially for newcomers
or people that always uses mouse (like me)).

Also i don't think that adding only 1 extra button can bloat the
toolbar, on 800x600 there is not that much difference.

Re: Redo button on the tool bar

[Elijah G.]

"Elijah G." <eg642616@gmail.com> writes:

> Eli Zaretskii <eliz@gnu.org> writes:
>
>> Please always start a new thread of discussion for unrelated issues.
>> I did that now.
>>
>>> Also i would like to know if there are plans for
>>> add a redo button in the tool-bar, there is a redo
>>> button in menu-bar Edit section but no in the
>>> tool-bar.
>>
>> Is that used frequently enough to justify an icon?  We need to
>> consider the limited screen estate on the tool bar, and only put there
>> buttons for very popular commands.  Undo certainly fits that bill, but
>> undo-redo? not so sure.
>
> Undo and Redo are very common in most text editor such as GVim,
> notepad++, etc.
>
> undo-redo (like undo) is a very used command today, i think that adding it
> can add a plus forward a more friendly Emacs (especially for newcomers
> or people that always uses mouse (like me)).
>
> Also i don't think that adding only 1 extra button can bloat the
> toolbar, on 800x600 there is not that much difference.

I forgot to say that in case there's interest in that, I'd like to
provide a patch.

Thanks.

Re: Redo button on the tool bar

[Eli Zaretskii]

> From: "Elijah G." <eg642616@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 09 May 2024 09:49:23 -0600
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Please always start a new thread of discussion for unrelated issues.
> > I did that now.
> >
> >> Also i would like to know if there are plans for
> >> add a redo button in the tool-bar, there is a redo
> >> button in menu-bar Edit section but no in the
> >> tool-bar.
> >
> > Is that used frequently enough to justify an icon?  We need to
> > consider the limited screen estate on the tool bar, and only put there
> > buttons for very popular commands.  Undo certainly fits that bill, but
> > undo-redo? not so sure.
> 
> Undo and Redo are very common in most text editor such as GVim,
> notepad++, etc.

That's because they behave very differently from Emacs.  In Emacs,
redo is basically the same as undo.

> undo-redo (like undo) is a very used command today

I think it's unused for a good reason.

> i think that adding it can add a plus forward a more friendly Emacs
> (especially for newcomers or people that always uses mouse (like
> me)).

We already have it in the menu.

> Also i don't think that adding only 1 extra button can bloat the
> toolbar, on 800x600 there is not that much difference.

I happen to disagree: the screen estate on the tool bar is at premium.

But let's hear what others think.

Re: Redo button on the tool bar

[Dmitry Gutov]

On 09/05/2024 19:41, Eli Zaretskii wrote:
>> Undo and Redo are very common in most text editor such as GVim,
>> notepad++, etc.
> That's because they behave very differently from Emacs.  In Emacs,
> redo is basically the same as undo.
> 
>> undo-redo (like undo) is a very used command today
> I think it's unused for a good reason.
> 
>> i think that adding it can add a plus forward a more friendly Emacs
>> (especially for newcomers or people that always uses mouse (like
>> me)).
> We already have it in the menu.
> 
>> Also i don't think that adding only 1 extra button can bloat the
>> toolbar, on 800x600 there is not that much difference.
> I happen to disagree: the screen estate on the tool bar is at premium.
> 
> But let's hear what others think.

Emacs's undo, while powerful, is not very newbie-friendly, IMHO.

That's why I argued for adding the command 'undo-redo', and I also think 
it would help to have it in the toolbar, as least if we think that the 
toolbar is there first of all to help new users.

Though maybe we'd predicate its display on 'undo-no-redo' being 
customized to t. Then the two buttons would be more consistent with each 
other.

Re: Add Tango and Adwaita icons for the toolbar

[Elijah G.]

I'm sorry for the inconvenience, is there any new about this?, i'm
asking since the branch for emacs-30 was cut.

-- 
E.G. from Gnus The Emacs Newsreader and E-mail client

Re: Add Tango and Adwaita icons for the toolbar

[Yuan Fu]

> On Jun 27, 2024, at 7:24 PM, Elijah G. <eg642616@gmail.com> wrote:
> 
> I'm sorry for the inconvenience, is there any new about this?, i'm
> asking since the branch for emacs-30 was cut.
> 
> -- 
> E.G. from Gnus The Emacs Newsreader and E-mail client

I the one that should be sorry. I’ve having a lot of stuff on my plate and barely keeping up :-) Also I don’t have a good solution for making the new tab icons work well on all platforms: it requires figuring out image scaling on all the platforms and modifying tab-bar code that handle individual platforms. 

I wonder if we can just add the icon files for now, so people can try them out and experiment with them? Hopefully in the future someone (or I) can come up with something that works on all the platforms.

Yuan

Re: Add Tango and Adwaita icons for the toolbar

[Po Lu]

Yuan Fu <casouri@gmail.com> writes:

> I the one that should be sorry. I’ve having a lot of stuff on my plate
> and barely keeping up :-) Also I don’t have a good solution for making
> the new tab icons work well on all platforms: it requires figuring out
> image scaling on all the platforms and modifying tab-bar code that
> handle individual platforms.

Where does the tab-bar code enter the equation?  More generally, why
modify any platform-specific code in the first place?  Focusing on
scaling at this time would be a gross misplacement of priorities; first
these icons ought not to constitute a regression from the existing icon
theme where this is already adequate, which they wouldn't if XPM and PBM
versions of the proposed icons, scaled to the dimensions of the
existing, were to be installed.

> I wonder if we can just add the icon files for now, so people can try
> them out and experiment with them? Hopefully in the future someone (or
> I) can come up with something that works on all the platforms.

If you unload this feature on users before it is ready for those
completely satisfied as it is, or before the infrastructure is in place
for rendering it optional, you will receive plenty of negative feedback
but negligible "experimentation."