all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Rudolf Adamkovič" <rudolf@adamkovic.org>
Cc: 70797@debbugs.gnu.org
Subject: bug#70797: [PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle errors
Date: Sat, 11 May 2024 11:56:02 +0300	[thread overview]
Message-ID: <86jzk03exp.fsf@gnu.org> (raw)
In-Reply-To: <m2fruvx5xv.fsf@adamkovic.org> (message from Rudolf Adamkovič on Mon, 06 May 2024 00:14:04 +0200)

> From: Rudolf Adamkovič <rudolf@adamkovic.org>
> Date: Mon, 06 May 2024 00:14:04 +0200
> 
> >From 8ff95a02a321d730e2c3171b18ddb55f3a554d20 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= <rudolf@adamkovic.org>
> Date: Thu, 2 May 2024 19:06:11 +0200
> Subject: [PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle
>  errors
> 
> The Compilation mode recognizes Kotlin/Gradle errors but only in the old
> format.  The new format, which has been in wide use for about a year, is
> not supported.  This patch adds support for the new format.
> 
> * etc/compilation.txt:
> (symbols): Add a non-legacy Kotlin/Gradle warning and error.
> * lisp/progmodes/compile.el:
> (compilation-error-regexp-alist-alist): Rename 'gradle-kotlin' to
> 'gradle-kotlin-legacy' and add 'grade-kotlin' that matches errors and
> warnings outputted by non-legacy Kotlin/Gradle.
> ---
>  etc/compilation.txt       | 13 +++++++++++--
>  lisp/progmodes/compile.el | 20 +++++++++++++++++---
>  2 files changed, 28 insertions(+), 5 deletions(-)

Thanks, but:

  . applying this fails compile-tests in the test suite, so I guess
    some adjustment there is also needed;
  . you removed the comment with the pointer to kotlin sources, which
    might be still useful for the legacy format (unless the URL is no
    longer valid), so please restore that if the pointer can still be
    useful

Thanks.





  reply	other threads:[~2024-05-11  8:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-05 22:14 bug#70797: [PATCH] Make the Compilation mode recognize non-legacy Kotlin/Gradle errors Rudolf Adamkovič
2024-05-11  8:56 ` Eli Zaretskii [this message]
2024-05-25  7:46   ` Eli Zaretskii
2024-06-08 11:44     ` Eli Zaretskii
2024-06-09 21:40       ` Rudolf Adamkovič
2024-06-13 14:44   ` Rudolf Adamkovic
2024-06-22  8:34     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86jzk03exp.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=70797@debbugs.gnu.org \
    --cc=rudolf@adamkovic.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.