bug#71405: 30.0.50; separator line in string-edit's *edit string* buffer can be deleted

bug#71405: 30.0.50; separator line in string-edit's *edit string* buffer can be deleted

[Nicholas Vollmer]

1. emacs -q
2. eval (string-edit "test" "" #'ignore :abort-callback #'ignore)
3. In the "*edit string*" buffer delete-backward-char

Observe the separator line has been deleted.
Attempting to insert a character will user-error "Text is 
read-only".

bug#71405: 30.0.50; separator line in string-edit's *edit string* buffer can be deleted

[Eli Zaretskii]

> From: Nicholas Vollmer <nv@parenthetic.dev>
> Date: Thu, 06 Jun 2024 11:55:01 -0400
> 
> 
> 1. emacs -q
> 2. eval (string-edit "test" "" #'ignore :abort-callback #'ignore)
> 3. In the "*edit string*" buffer delete-backward-char
> 
> Observe the separator line has been deleted.
> Attempting to insert a character will user-error "Text is 
> read-only".

Does the patch below give good results?

diff --git a/lisp/textmodes/string-edit.el b/lisp/textmodes/string-edit.el
index 03be426..2a96289 100644
--- a/lisp/textmodes/string-edit.el
+++ b/lisp/textmodes/string-edit.el
@@ -58,7 +58,8 @@ string-edit
                              (list 'intangible t
                                    'face 'string-edit-prompt
                                    'read-only t))
-        (insert (propertize (make-separator-line) 'rear-nonsticky t))
+        (insert (propertize (make-separator-line)
+                            'read-only t 'rear-nonsticky t))
         (add-text-properties (point-min) (point)
                              (list 'string-edit--prompt t))))
     (let ((start (point)))

bug#71405: 30.0.50; separator line in string-edit's *edit string* buffer can be deleted

[Eli Zaretskii]

> From: Nicholas Vollmer <nv@parenthetic.dev>
> Cc: 71405@debbugs.gnu.org
> Date: Mon, 10 Jun 2024 16:52:33 -0400
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Does the patch below give good results?
> 
> Yes.

Thanks, installed on master, and closing the bug.