From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: master 6b7ff60a5e7: Highlight the suffix in *Completions* buffer in 'basic' style too Date: Mon, 01 Jul 2024 09:57:08 +0300 Organization: LINKOV.NET Message-ID: <86jzi5bnnz.fsf@mail.linkov.net> References: <171823002031.28307.18221225159709452537@vcs2.savannah.gnu.org> <20240612220700.A0F4DC1FB4C@vcs2.savannah.gnu.org> <86h6dwf40q.fsf@mail.linkov.net> <86frtffpdb.fsf@mail.linkov.net> <867ce6pwrq.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32631"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org, Dmitry Gutov To: Eshel Yaron Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jul 01 09:05:52 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sOB6k-0008G6-RD for ged-emacs-devel@m.gmane-mx.org; Mon, 01 Jul 2024 09:05:50 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sOB5r-0005Ue-I1; Mon, 01 Jul 2024 03:04:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOB5o-0005UU-Pp for emacs-devel@gnu.org; Mon, 01 Jul 2024 03:04:53 -0400 Original-Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOB5m-0003tf-V8 for emacs-devel@gnu.org; Mon, 01 Jul 2024 03:04:52 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id E6B251C0005; Mon, 1 Jul 2024 07:04:43 +0000 (UTC) In-Reply-To: (Eshel Yaron's message of "Sun, 30 Jun 2024 20:14:02 +0200") X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=2001:4b98:dc4:8::225; envelope-from=juri@linkov.net; helo=relay5-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320999 Archived-At: >> 1. M-x icomplete-mode RET >> 2. M-x rgrep RET foo RET b >> >> Error in post-command-hook (icomplete-post-command-hook): >> (wrong-type-argument number-or-marker-p nil) > > Ouch. AFAICT the problem is in grep.el, and it's not specific to > icomplete-mode, e.g. I can reproduce it with: > > M-: (grep-read-files "foo") RET b ? Also typing 'el TAB' after RET gives: Debugger entered--Lisp error: (error "Internal error: all doesn’t match \\`el") signal(error ("Internal error: all doesn’t match \\`el")) error("Internal error: %s doesn't match %s" "all" "\\`el") completion-pcm--merge-completions(("all" "el" "ch" "c" "cc" "cchh" "hh" "h" "l" "am" "m" "tex" "texi" "asm") ("el")) completion-pcm--merge-try(("el") ("all" "el" "ch" "c" "cc" "cchh" "hh" "h" "l" "am" "m" "tex" "texi" "asm") "" "") > grep-read-files calls completing-read with a misbehaving completion > table, that returns some completion candidates unconditionally. This > breaks the assumption of completion-pcm--all-completions that the > candidates it gets actually match the given pattern. > > Does the diff below help? Thanks, after short testing I see it doesn't lose the ability to complete in both cases: a list of abbreviations and file names, while fixing the problem above, so it looks like the right thing to do. > (Note that this change has the downside that file name quoting/unquoting > is no longer applied. Handling that with completion-table-merge might > be a bit more tricky.) Not sure how serious this limitation is.