From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71883: [PATCH] Fix tab-bar-auto-width with customized tab-bar-tab-face-function Date: Wed, 17 Jul 2024 14:18:52 +0300 Message-ID: <86jzhkgtb7.fsf@gnu.org> References: <87le2kaloz.fsf@breatheoutbreathe.in> <861q4ce1yb.fsf@mail.linkov.net> <877ce3damx.fsf@breatheoutbreathe.in> <86r0cb7l58.fsf@mail.linkov.net> <5aff3095-087f-493d-9251-8048b51280f9@alphapapa.net> <86msmzc7ne.fsf@mail.linkov.net> <86o77dox54.fsf@mail.linkov.net> <87a5ihgii9.fsf@breatheoutbreathe.in> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8031"; mail-complaints-to="usenet@ciao.gmane.io" Cc: adam@alphapapa.net, 71883@debbugs.gnu.org, shipmints@gmail.com, juri@linkov.net To: Joseph Turner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 17 13:22:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sU2jb-0001uZ-8E for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Jul 2024 13:22:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sU2jQ-0001CS-SD; Wed, 17 Jul 2024 07:22:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sU2jP-00013b-9U for bug-gnu-emacs@gnu.org; Wed, 17 Jul 2024 07:21:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sU2jO-0006Ke-VX for bug-gnu-emacs@gnu.org; Wed, 17 Jul 2024 07:21:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sU2jS-0003bG-1L for bug-gnu-emacs@gnu.org; Wed, 17 Jul 2024 07:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Jul 2024 11:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71883 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71883-submit@debbugs.gnu.org id=B71883.172121528813780 (code B ref 71883); Wed, 17 Jul 2024 11:22:02 +0000 Original-Received: (at 71883) by debbugs.gnu.org; 17 Jul 2024 11:21:28 +0000 Original-Received: from localhost ([127.0.0.1]:35160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sU2it-0003aB-TL for submit@debbugs.gnu.org; Wed, 17 Jul 2024 07:21:28 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sU2io-0003Zx-Of for 71883@debbugs.gnu.org; Wed, 17 Jul 2024 07:21:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sU2gX-0005fF-Ri; Wed, 17 Jul 2024 07:19:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=unqCKAXt2jlTfxP/rrHcfQjMdUbLXskhmd2XAq5pA6o=; b=gJP65DcZf3Hi l7nZeSCBPX+MTE6ml8McRBQyNwyt5pfukc1AYs2Ni0vp2nZfDvuOmnT3JDBE0w/5pxn/IhxuegVLT QCtfwhqchfuN802ElOUgR+jt5dD8pXlnH/faxoxtrxZnaFx/ANblljHrbGY3U/RaBh76fj+xLFwAu A0v3bp+uUp53lkgg+9n8NdRvqYAk0FCD0bwxMrewafxilByfrk1+P2Rn7Li5srYOjo94yd5C+aolQ CjAdWP4LFNR1mgRr3O1MROCBcY8T4PBimrzKP3vVvtbFAE+k5Fs2lBfc5y/s24JfqgGtAIkxKqj6z vF9eio5ANDTZ7x9/xVfjow==; In-Reply-To: <87a5ihgii9.fsf@breatheoutbreathe.in> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288918 Archived-At: > Cc: Adam Porter , 71883@debbugs.gnu.org, > Ship Mints > Date: Mon, 15 Jul 2024 22:12:46 -0700 > From: Joseph Turner via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Juri Linkov writes: > > > Let's see what Joseph and Stephane think. > > Please see the attached patches, where the first three commits are > intended to be applied to the emacs-30 branch, and the final commit > removes the obsolete `tab-bar-auto-width-faces' on master. I'm not sure I understand why they need to be installed on emacs-30. Is this a regression in Emacs 29 or Emacs 30? What bad things will happen if we install the changes on master instead> > Does this change warrant a NEWS entry? Yes, since you are adding a hook variable. Obsolescence of a variable also requires a NEWS entry. > From: Joseph Turner > Date: Mon, 15 Jul 2024 22:07:22 -0700 > Subject: [PATCH 4/4] Remove obsolete tab-bar-auto-width-faces > > * lisp/tab-bar.el (tab-bar-auto-width-faces): Remove. > (tab-bar-auto-width): Only run tab-bar-auto-width-functions. We don't usually remove a variable one major release after it has been obsoleted. It's too soon. Thanks.