From: Eli Zaretskii <eliz@gnu.org>
To: Joseph Turner <joseph@breatheoutbreathe.in>
Cc: adam@alphapapa.net, 71883@debbugs.gnu.org, shipmints@gmail.com,
juri@linkov.net
Subject: bug#71883: [PATCH] Fix tab-bar-auto-width with customized tab-bar-tab-face-function
Date: Wed, 17 Jul 2024 14:18:52 +0300 [thread overview]
Message-ID: <86jzhkgtb7.fsf@gnu.org> (raw)
In-Reply-To: <87a5ihgii9.fsf@breatheoutbreathe.in> (bug-gnu-emacs@gnu.org)
> Cc: Adam Porter <adam@alphapapa.net>, 71883@debbugs.gnu.org,
> Ship Mints <shipmints@gmail.com>
> Date: Mon, 15 Jul 2024 22:12:46 -0700
> From: Joseph Turner via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> Juri Linkov <juri@linkov.net> writes:
>
> > Let's see what Joseph and Stephane think.
>
> Please see the attached patches, where the first three commits are
> intended to be applied to the emacs-30 branch, and the final commit
> removes the obsolete `tab-bar-auto-width-faces' on master.
I'm not sure I understand why they need to be installed on emacs-30.
Is this a regression in Emacs 29 or Emacs 30? What bad things will
happen if we install the changes on master instead>
> Does this change warrant a NEWS entry?
Yes, since you are adding a hook variable. Obsolescence of a variable
also requires a NEWS entry.
> From: Joseph Turner <joseph@breatheoutbreathe.in>
> Date: Mon, 15 Jul 2024 22:07:22 -0700
> Subject: [PATCH 4/4] Remove obsolete tab-bar-auto-width-faces
>
> * lisp/tab-bar.el (tab-bar-auto-width-faces): Remove.
> (tab-bar-auto-width): Only run tab-bar-auto-width-functions.
We don't usually remove a variable one major release after it has been
obsoleted. It's too soon.
Thanks.
next prev parent reply other threads:[~2024-07-17 11:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 20:42 bug#71883: [PATCH] Fix tab-bar-auto-width with customized tab-bar-tab-face-function Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-02 6:55 ` Juri Linkov
2024-07-02 13:42 ` Ship Mints
2024-07-02 16:25 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-02 17:34 ` Juri Linkov
2024-07-02 23:10 ` Adam Porter
2024-07-03 6:27 ` Juri Linkov
2024-07-03 19:50 ` Adam Porter
2024-07-04 17:57 ` Juri Linkov
2024-07-04 21:11 ` Ship Mints
2024-07-16 5:12 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-17 11:18 ` Eli Zaretskii [this message]
2024-07-19 6:42 ` Juri Linkov
2024-07-25 18:11 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-25 18:18 ` Juri Linkov
2024-07-25 18:52 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-25 19:09 ` Eli Zaretskii
2024-07-25 23:00 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-06 6:59 ` Juri Linkov
2024-08-09 12:15 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-09 12:25 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-19 16:57 ` Juri Linkov
2024-08-20 1:49 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-20 6:40 ` Juri Linkov
2024-08-20 7:11 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86jzhkgtb7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=71883@debbugs.gnu.org \
--cc=adam@alphapapa.net \
--cc=joseph@breatheoutbreathe.in \
--cc=juri@linkov.net \
--cc=shipmints@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.