From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#71883: [PATCH] Fix tab-bar-auto-width with customized tab-bar-tab-face-function Date: Tue, 20 Aug 2024 09:40:38 +0300 Organization: LINKOV.NET Message-ID: <86jzgb4ttl.fsf@mail.linkov.net> References: <87le2kaloz.fsf@breatheoutbreathe.in> <861q4ce1yb.fsf@mail.linkov.net> <877ce3damx.fsf@breatheoutbreathe.in> <86r0cb7l58.fsf@mail.linkov.net> <5aff3095-087f-493d-9251-8048b51280f9@alphapapa.net> <86msmzc7ne.fsf@mail.linkov.net> <86o77dox54.fsf@mail.linkov.net> <87a5ihgii9.fsf@breatheoutbreathe.in> <86jzhkgtb7.fsf@gnu.org> <865xt1lw66.fsf@mail.linkov.net> <87ikwttk96.fsf@breatheoutbreathe.in> <861q3h47ci.fsf@gnu.org> <87a5i5dqmd.fsf@breatheoutbreathe.in> <86plqmqgpa.fsf@mail.linkov.net> <87ed6xanny.fsf@breatheoutbreathe.in> <86o75o30ye.fsf@mail.linkov.net> <87ttfgc6ag.fsf@breatheoutbreathe.in> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34204"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) Cc: adam@alphapapa.net, 71883@debbugs.gnu.org, Eli Zaretskii , shipmints@gmail.com To: Joseph Turner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 20 08:50:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sgIhI-0008i6-Ci for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 20 Aug 2024 08:50:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sgIhG-0002PK-9Y; Tue, 20 Aug 2024 02:50:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sgIh9-0002Nz-SW for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2024 02:50:19 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sgIh9-0006ac-DP for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2024 02:50:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=W7ONY/m2d9HHgoxwDyusli434YCblNaeHWdqRh861uw=; b=H10tVZNnWCOxYfVpS9WsiBm6jip9rRh6kVqHCTC9y5kVNQAT5WYFiMYcPoTv1Oc1mAcFmossddjWKg6x3dnEJLaDdK4TC0Vp388aOcXD9G4jawg6ctUyYg/h5V4gMW52lFwSFTS7X+Zh/qMFpztYsQ3L5Uh+q9vbQNqTMk3pxw7XC5JXtjxvhmThvxOGy8FFdgqh4MGdLK1Ls+uvP+JqgcSu+j5uQ4OuM/+oATORLYn9Kkb3LbxKeP4+1p9z1Wppsrirw7s835aJ6BffQUtBxl5strrYZJqvYFqEkky9CarZ/DkODXJG9z2B/ecc3OCrT+ZcJeh5M9mMptTaERtTPQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sgIhq-00081P-16 for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2024 02:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Aug 2024 06:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71883 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71883-submit@debbugs.gnu.org id=B71883.172413661830769 (code B ref 71883); Tue, 20 Aug 2024 06:51:01 +0000 Original-Received: (at 71883) by debbugs.gnu.org; 20 Aug 2024 06:50:18 +0000 Original-Received: from localhost ([127.0.0.1]:59695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgIh8-00080B-3H for submit@debbugs.gnu.org; Tue, 20 Aug 2024 02:50:18 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:50033) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sgIh6-0007zv-EK for 71883@debbugs.gnu.org; Tue, 20 Aug 2024 02:50:16 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 2BC9F240005; Tue, 20 Aug 2024 06:49:04 +0000 (UTC) In-Reply-To: <87ttfgc6ag.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Mon, 19 Aug 2024 18:49:27 -0700") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290426 Archived-At: >>>>> +(defun tab-bar-auto-width-predicate-default (item) >>>>> + "Accepts tab ITEM and returns non-nil for tabs and tab groups." >>>>> + (string-match-p >>>>> + ;; (rx bos (or "current-tab" "current-group" "tab-" "group-")) >>>>> + "\\`\\(?:current-\\(?:group\\|tab\\)\\|\\(?:group\\|tab\\)-\\)" >>>>> + (symbol-name (nth 0 item)))) >>>> >>>> In this part please remove the current group from the default implementation, >>>> because it looks too ugly, and it was not resized before this change, since >>>> tab-bar-auto-width-faces didn't contain the tab-bar-tab-group-current face. >>> >>> If the simpler change offers feature parity, that sounds good to me. >> >> Thanks for the patch, I pushed it to master, then ameliorated it >> to keep backwards-compatibility for users customized these faces, >> but by default using your predicate on symbols. > > Thank you! How would users have customized tab-bar-auto-width-faces > since it was not a defcustom? I meant that customized it without using the Customization UI. Maybe a better word would be "configured", e.g. with 'setopt' ('setopt' supports non-customizable plain variables as 'setq' does, unlike 'set-variable' that refuses to change them).