From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72759: 31.0.50; Emacs hangs with open-paren-in-column-0-is-defun-start set to nil Date: Fri, 23 Aug 2024 09:56:15 +0300 Message-ID: <86jzg7rals.fsf@gnu.org> References: <868qwou8pv.fsf@gnu.org> <861q2gu56u.fsf@gnu.org> <86msl4slwv.fsf@gnu.org> <86ed6gsfm3.fsf@gnu.org> <86a5h4sast.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27512"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72759@debbugs.gnu.org To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 23 08:57:32 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1shOEm-0006wG-2m for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Aug 2024 08:57:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1shOEY-0004xT-77; Fri, 23 Aug 2024 02:57:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1shOEW-0004xE-OT for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2024 02:57:16 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1shOEW-0001mr-Dm for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2024 02:57:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=BB9MRZDSRVMr3c39E0CJiDxKNc+jHIb0F4y+et7h1qc=; b=EQb6iJNGArWryPVbzj/txMWwTGnAIe4JDPNyEekuQIYO686h6B0QfBlRLTPyPnTPJpwYj/N4kn47e1lHb97t+whFsOQMhll6MDj4gPuN9pcbOZahTTbMYKjlyRkZj3rx2GSsQzguW+bslLmWg30XjtPo28b9fsuWuLbtXz+91wa6SH6UpPksvqUpmhymN+Cfge42iFZdEWKMJCZOEw+goQl3ffMjBCIAZ1YnHnmCR0UsBjR+x3IoCw43uGucCfLk1KbUuEB1KeZ1b/5WbJUqOj2olxFpSXYydBdplXB8AUEO95L+wu/sWlHNHjHUC3A0QZK2XJp51KgCOC2riQbpyA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1shOFH-00067i-5K for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2024 02:58:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Aug 2024 06:58:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72759 X-GNU-PR-Package: emacs Original-Received: via spool by 72759-submit@debbugs.gnu.org id=B72759.172439623123423 (code B ref 72759); Fri, 23 Aug 2024 06:58:03 +0000 Original-Received: (at 72759) by debbugs.gnu.org; 23 Aug 2024 06:57:11 +0000 Original-Received: from localhost ([127.0.0.1]:38829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shOER-00065i-BY for submit@debbugs.gnu.org; Fri, 23 Aug 2024 02:57:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45272) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1shOEP-00065Y-Dl for 72759@debbugs.gnu.org; Fri, 23 Aug 2024 02:57:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1shODZ-0001gI-6X; Fri, 23 Aug 2024 02:56:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=BB9MRZDSRVMr3c39E0CJiDxKNc+jHIb0F4y+et7h1qc=; b=eT18eulTScpy 5khnRdVXKoXzIYEwan3zik/4nq5lt2BXDnzi4Vm3APNJEIpUTwBkvEMkyK0DVrbm4vv8mwz04G5W+ ds5z4qTl9g/AWXghtkIj1ur+3ksLQ6ghj2AlMWGVJIIBSwKldDIDSLcDqvAXBokqKxFQYY6h8JoBf A9IckZAZH5Y28trT0SYUbTrbeN6MibGLlQXFTT+S6tQ7xXeKCdN6vUIR5U9seqUraR8JzXf659JxP polIofqNnEECXh+2iaHpksqm7YjTfmMsn4PTIKQAuLk93rstdaTke+mbNsvVT6Q6D3YVQrRJWjzK0 IriTS+CibcS0J/TICA+9yw==; In-Reply-To: (message from Eshel Yaron on Fri, 23 Aug 2024 07:54:25 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290578 Archived-At: > From: Eshel Yaron > Cc: 72759@debbugs.gnu.org > Date: Fri, 23 Aug 2024 07:54:25 +0200 > > Hi Eli, > > Eli Zaretskii writes: > > >> >> diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el > >> >> index 949ca6b74ad..65226d8ee44 100644 > >> >> --- a/lisp/emacs-lisp/checkdoc.el > >> >> +++ b/lisp/emacs-lisp/checkdoc.el > >> >> @@ -981,7 +981,7 @@ checkdoc-next-docstring > >> >> Return nil if there are no more doc strings." > >> >> (let (found) > >> >> (while (and (not (setq found (checkdoc--next-docstring))) > >> >> - (beginning-of-defun -1))) > >> >> + (beginning-of-defun-raw -1))) > >> >> found)) > > > I'm trying to understand what kind of behavior change could be caused > > by your proposed change, which is why what beginning-of-defun-raw does > > and beginning-of-defun doesn't is important, especially if some user > > options can affect that. E.g., does anything change in this scenario > > if defun-prompt-regexp is non-nil? > > This change is the correct also when defun-prompt-regexp is non-nil. > Take a look at beginning-of-defun, it just calls beginning-of-defun-raw > after possibly pushing a mark, and then it calls beginning-of-line. > We're not interested in pushing a mark here, neither do we want to move > back to beginning of the line after each call (that yields an infloop), > so beginning-of-defun-raw fits the bill precisely. Thanks, feel free to install this, then.