From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: MPS: Win64 testers? Date: Sun, 01 Sep 2024 14:59:40 +0300 Message-ID: <86jzfva8k3.fsf@gnu.org> References: <87bk1k8mzd.fsf@protonmail.com> <861q2gs8xu.fsf@gnu.org> <877cc88j4p.fsf@protonmail.com> <86seuvre6x.fsf@gnu.org> <8734mv8yb6.fsf@protonmail.com> <87wmk54yk5.fsf@protonmail.com> <86r0a3ahm9.fsf@gnu.org> <86plpnacsd.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33444"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sebastian@sebasmonia.com, pipcet@protonmail.com, emacs-devel@gnu.org, yantar92@posteo.net To: kien.n.quang@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Sep 01 14:00:39 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1skjG3-0008Uj-3y for ged-emacs-devel@m.gmane-mx.org; Sun, 01 Sep 2024 14:00:39 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1skjFC-0000Ff-Rn; Sun, 01 Sep 2024 07:59:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1skjFB-0000FQ-Vk for emacs-devel@gnu.org; Sun, 01 Sep 2024 07:59:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1skjFB-0005bq-06; Sun, 01 Sep 2024 07:59:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=tM1cohOuw0cxGF42F/PD2CGGwuLoWNoSEXeH6oyfo7w=; b=MoYbX8RX8XRc YdOMiapa3hEz8SIiEJRawH0XD8lifZuad0VYsRKixYxlbodywuqsa/iJCvx/9XU3NID0RQ4UErL/Y D15bUiNjt5mJOG5aBbJTAl4v2wkSPLD27U5Bq7TpooqBUVL+7NU+cQ83lgk2jjFSPWFc3AW+/R2RD nRawEgOnAYlXUY8Lx0KfcID71OKvhNtfjLOfqSQb/QNRnP/TVfWZv+5n4cXJu58TVubnVYLy+JIB1 bbW+l1DzGi2I1LU5Twt0xvpPAzy2oAyRKHV6SavCbrG0oQGd8qKhUH6qzaPGmdDb6x64qhlSopVzI bGc+WmjK4J1GKh0H+JK9zg==; In-Reply-To: <86plpnacsd.fsf@gnu.org> (message from Eli Zaretskii on Sun, 01 Sep 2024 13:28:18 +0300) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323255 Archived-At: > Date: Sun, 01 Sep 2024 13:28:18 +0300 > From: Eli Zaretskii > Cc: sebastian@sebasmonia.com, pipcet@protonmail.com, > emacs-devel@gnu.org, yantar92@posteo.net > > I hesitate to make the change you proposed because emacs_abort is > called not just when Emacs is under a debugger, so the change will > affect many users who don't debug Emacs. Does the alternative change below solve your problem when attaching to Emacs? diff --git a/src/.gdbinit b/src/.gdbinit index 0f55cc1..885d3dc 100644 --- a/src/.gdbinit +++ b/src/.gdbinit @@ -1308,6 +1308,11 @@ if defined_HAVE_X_WINDOWS break x_error_quitter end +if defined_WINDOWSNT + if kbdhook.hook_count > 0 + call remove_w32_kbdhook() + end +end # Put the Python code at the end of .gdbinit so that if GDB does not # support Python, GDB will do all the above initializations before diff --git a/src/alloc.c b/src/alloc.c index c22a5a7..3943224 100644 --- a/src/alloc.c +++ b/src/alloc.c @@ -8309,6 +8309,12 @@ syms_of_alloc (void) enum defined_HAVE_PGTK { defined_HAVE_PGTK = false }; #endif +#ifdef WINDOWSNT +enum defined_WINDOWSNT { defined_WINDOWSNT = true }; +#else +enum defined_WINDOWSNT { defined_WINDOWSNT = false }; +#endif + /* When compiled with GCC, GDB might say "No enum type named pvec_type" if we don't have at least one symbol with that type, and then xbacktrace could fail. Similarly for the other enums and @@ -8329,6 +8335,7 @@ syms_of_alloc (void) enum pvec_type pvec_type; enum defined_HAVE_X_WINDOWS defined_HAVE_X_WINDOWS; enum defined_HAVE_PGTK defined_HAVE_PGTK; + enum defined_WINDOWSNT defined_WINDOWSNT; } const gdb_make_enums_visible; union enums_for_gdb const EXTERNALLY_VISIBLE gdb_make_enums_visible = {0}; #endif /* __GNUC__ */