From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73050: 30.0.90; Empty tool tip when hovering over tab-bar separator Date: Sun, 08 Sep 2024 10:06:30 +0300 Message-ID: <86jzfmwrnt.fsf@gnu.org> References: <87r09ygit9.fsf@daniel-mendler.de> <86le03yeyv.fsf@gnu.org> <86jzfmu0lm.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31325"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mail@daniel-mendler.de, 73050@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 08 09:07:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1snC13-00081n-HX for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Sep 2024 09:07:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1snC0k-0005xh-AP; Sun, 08 Sep 2024 03:07:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1snC0i-0005xI-D7 for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2024 03:07:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1snC0i-0007v9-45 for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2024 03:07:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=vIGxwz/FCE4hIDo8atqPlFDsyJKr0hhKx13p6JsLd94=; b=IeXbV3sL0MppSABzu6gWPVNpVfz6XZlwMb0t6iDfWbuofzB/7qqSudUUFpWOZ1XDFBrcZO7QEQq6qS9HCINWFqbe+VqXDAL4cvr3esWhRzzEa8JHMSQj/C8kUJIVA5RnmyMXQPDgWDr2Oam+pGCfhsgzcrR9Nv6sRGk5U9+7U2vilKitKcKPy3Ylb4sWiHdL1lUVTboUVsC5nTFV0D49VXoMFo2tKtmtbJghhAyZzNnGguvriU3NnhkK1d5Ys39u37z6lXq4eoQS/55JByhJCRfuVke6FsmmrAXn+1I6jRCGXG2t4Hb3tAB4w1JXsQI4JGY2P6tYOcdR9Zow9QjC2A==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1snC0j-0001sl-U3 for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2024 03:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Sep 2024 07:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73050 X-GNU-PR-Package: emacs Original-Received: via spool by 73050-submit@debbugs.gnu.org id=B73050.17257792197226 (code B ref 73050); Sun, 08 Sep 2024 07:07:01 +0000 Original-Received: (at 73050) by debbugs.gnu.org; 8 Sep 2024 07:06:59 +0000 Original-Received: from localhost ([127.0.0.1]:57916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1snC0h-0001sU-Gv for submit@debbugs.gnu.org; Sun, 08 Sep 2024 03:06:59 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1snC0f-0001sF-I7 for 73050@debbugs.gnu.org; Sun, 08 Sep 2024 03:06:58 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1snC0X-0007tg-TD; Sun, 08 Sep 2024 03:06:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=vIGxwz/FCE4hIDo8atqPlFDsyJKr0hhKx13p6JsLd94=; b=XoWi3RB3t2Xr 6xw8mtPBfd2VdcRaG+EPo3xAWPP0AX1Sy1nwrImpqgPMwrIlKfQhCECUkJ3upfzxMU+VV69KZJE3e 5b8gj30CQTG4KfiyDvBL1U3Z6I7EaPtPBh0BKD4Lq35Lh8vaIXQg2g1KSCcvi6+ERed5cRLGP6470 /dPKUhomEmRgYSqgJG/ulQ9yD9AelVUeJePFvJW3aGLMGGroq17+0NShdCaJ4CgP628WMV7gP799S r22l9KttPOtdsaqY8gyV4Lxh1sH4oU7laKd/bAHkSnRhOsYyRJ0GZOlSK2oGtF0h0rrQ/WKmGI7Sy lKY1b3uePcR2a1bh/rT+xw==; In-Reply-To: <86jzfmu0lm.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 08 Sep 2024 09:51:41 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291429 Archived-At: > From: Juri Linkov > Cc: Daniel Mendler , 73050@debbugs.gnu.org > Date: Sun, 08 Sep 2024 09:51:41 +0300 > > >> This is only a minor issue. After enabling `tab-bar-mode' when hovering > >> with the mouse over the `tab-bar-separator' space, an empty tool tip > >> will be shown after a short delay. > >> > >> To reproduce: > >> > >> 1. Start emacs -Q > >> 2. M-x tab-bar-mode > >> 3. Move the mouse pointer over the space right after the "*scratch*" tab > >> > >> Would it make sense to somehow prevent displaying blank tool tips, e.g., > >> via the following advice? Or maybe blank tool tips could be prevented on > >> the tab-bar level? > >> > >> (defun x-show-tip-adv (str &rest _) (string-blank-p str)) > >> (advice-add #'x-show-tip :before-until #'x-show-tip-adv) > > > > Juri, can we prevent such empty tooltips from being shown by tab bar? > > Maybe this unasked-for default fallback is not needed after all: > > diff --git a/src/xdisp.c b/src/xdisp.c > index f9a10267bad..18834c6b781 100644 > --- a/src/xdisp.c > +++ b/src/xdisp.c > @@ -15155,8 +15155,6 @@ note_tab_bar_highlight (struct frame *f, int x, int y) > help_echo_object = help_echo_window = Qnil; > help_echo_pos = -1; > help_echo_string = AREF (f->tab_bar_items, prop_idx + TAB_BAR_ITEM_HELP); > - if (NILP (help_echo_string)) > - help_echo_string = AREF (f->tab_bar_items, prop_idx + TAB_BAR_ITEM_CAPTION); > } > > #endif /* HAVE_WINDOW_SYSTEM */ Do you remember why was this introduced?