From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74461: [PATCH] Add go-work-ts-mode Date: Sat, 30 Nov 2024 12:17:45 +0200 Message-ID: <86jzcl81py.fsf@gnu.org> References: <87ttbzd16p.fsf@disroot.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23591"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dev@rjt.dev, 74461@debbugs.gnu.org To: Gabriel Santos Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 30 11:19:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tHKZF-0005z0-6X for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Nov 2024 11:19:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tHKZ7-0006gj-72; Sat, 30 Nov 2024 05:19:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHKZ4-0006gU-Oi for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2024 05:19:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tHKZ4-0007yO-FJ for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2024 05:19:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=McwNqBYJEjQHM7beKiK8gAa0RY5tHQK1WsWvgu0sjI8=; b=ArCQ8GGo9I/SZcr9M1dJiGutIwNDimW/+xkzmIIDjevc0Xfjp3mczChri8y3YxKZuOxsihXyjYrzF1gTlko+Z9NFpsGIaNWl7m5SkYsG3NyvmdPo8fESWJ9YPrpgayHl77OH2n5wQf7MPiiCMAPxy3BFVYfg7aV0umdUGnzkSW3w7MCxatHltJQtTeMLhZzbHNHPZEGXV3MgbYxWyp9qvY98JAj7z4FuaodtrCCST+GM6xhsXDQiMjjxWZkyBMn3aNR/+UtjaI+7NNRShawXZQfUQ4FK01+44Fz9CKt4Sc5BTAjWwLhR2eYAWsPktViDTgCkxBdxw/1g2lZUlzKFJQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tHKZ4-00084n-27 for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2024 05:19:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Nov 2024 10:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74461 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74461-submit@debbugs.gnu.org id=B74461.173296188530932 (code B ref 74461); Sat, 30 Nov 2024 10:19:02 +0000 Original-Received: (at 74461) by debbugs.gnu.org; 30 Nov 2024 10:18:05 +0000 Original-Received: from localhost ([127.0.0.1]:45555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHKY8-00082q-MV for submit@debbugs.gnu.org; Sat, 30 Nov 2024 05:18:05 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHKY4-000826-TY for 74461@debbugs.gnu.org; Sat, 30 Nov 2024 05:18:02 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHKXw-0007a2-DI; Sat, 30 Nov 2024 05:17:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=McwNqBYJEjQHM7beKiK8gAa0RY5tHQK1WsWvgu0sjI8=; b=oPrCYinz8dQz 6RrQCNXCjrpMPDngfvZB2GTQ+kIIBibe0ygbatx84SHZQ5zcf0ntbZ3zmKF0s48Mr8jOjKqVA21r4 yE1rAkfZ9LEWCAgibfjki1i/bruwJom6XCLBva9PNarSuuSJJk//okRf5PW5/Q2BBSqPWvjKLMTIy VMP74v4uZUGnxQCkerLgrS/+Bo/kQ/ix57pwfxQ1NyClxf5swCk+aorDHwGXNE5QbZ8g5AB6E1qse AtmsCSJtfqsYqahQF0AAoLTuTgnL61fLdOsdG80oOicc19OiKqnMW4yNiVh6qFRuaOlWT0Y9OnDQB sOK5T5NjDdkJ/7/lManlmQ==; In-Reply-To: <87ttbzd16p.fsf@disroot.org> (message from Gabriel Santos on Fri, 22 Nov 2024 07:15:26 -0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296141 Archived-At: > From: Gabriel Santos > Cc: 74461@debbugs.gnu.org, eliz@gnu.org > Date: Fri, 22 Nov 2024 07:15:26 -0300 > > I fixed the mistake you pointed out in build.sh > > > It would be nice to have syntax highlighting and indentation tests for > > this (ideally covering everything). If you're interested, take a look > > at go-ts-mode-tests.el and the files it references for inspiration. > > I wrote some simple tests for both go-mod-ts-mode and go-work-ts-mode. > For syntax highlighting, I had them both use the same file > (font-lock-package.go), since they have some compatible elements, and > for indentation, I made a simple test for indenting multiple lines. > > I also changed the face for operators (on go-work-ts-mode), as I > incorrectly used font-lock-warning-face. > > Also, please let me know your opinion on how I layed out the grammars in > the commentary section. I think I'll go through the other tree-sitter > modes and add the grammar to their commentary section too, so it's nice > to get some feedback before making these changes. The patch LGTM, but if you have a later version, please post that. The only comment I have is that for the commit log message: > * lisp/progmodes/go-ts-mode: Add go-work-ts-mode for working with > workspace files. > * lisp/progmodes/go-ts-mode: Add the repositories for the grammars to > the commentary section. > * lisp/progmodes/go-ts-mode (go-mod-ts-mode--in-directive-p): Be more > specific on the directive location. These should mention the file name only once, and they all should mention the names of functions/variables where the changes were made. For new functions, just list them and say "New functions." Also, the lines in the log message are too long: they should preferably be at most 64 columns, and never more than 70. How is your copyright assignment paperwork going? I don't think I saw any responses from the FSF copyright clerk; if more than 2 weeks have passed since you emailed the assignment form, please ping them and CC me. Thanks.