From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74966: 31.0.50; Crash report (using igc on macOS) Date: Sat, 21 Dec 2024 18:15:48 +0200 Message-ID: <86jzbt6mh7.fsf@gnu.org> References: <86a5cqkc2g.fsf@gnu.org> <86o716ah09.fsf@gnu.org> <87r062jpi1.fsf@protonmail.com> <874j2xhxp2.fsf@protonmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19282"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, spd@toadstyle.org, monnier@iro.umontreal.ca, 74966@debbugs.gnu.org To: Pip Cet , acorallo@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 21 17:17:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tP2A9-0004sy-Db for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Dec 2024 17:17:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tP2A4-0002dc-Sf; Sat, 21 Dec 2024 11:17:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tP2A2-0002cy-LV for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2024 11:17:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tP2A2-0003KR-7Y for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2024 11:17:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=ripkoMyaHIW+NA23nqRngKFET/KRc31H6BD0vjcWByQ=; b=KNwuOmaPB4bbDIYNxFZ4vkwzHWZQ4HyT18Q3HX8aqBJZgKu8vWTH74pd8XlrC/psYY593n4o0lMPSHyZ5afzHFOjEaIRHrEHHA3tjg5UApo/qMgPxBOAag0BN7jYKXebdzb0kek55a40HJuefziVTwSOThQI8dR0UHvsOYdBsS8hc/ELx4GhCx9SiDhD9bh3nCp1y8KyH6U5js+mymw3p1AGkvxnlWywwlV7bWZxabPsHrN0QtCBjKqymmhDYYNZkPTVwAaZjqQB4hu/3t/wKeEMo1hrXbU1kTLm+oohEpw8nif3DOZhd58l2ClTToAhIc+TNPjey1qa5Zdt27Rpiw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tP2A1-00037h-Uf for bug-gnu-emacs@gnu.org; Sat, 21 Dec 2024 11:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Dec 2024 16:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74966 X-GNU-PR-Package: emacs Original-Received: via spool by 74966-submit@debbugs.gnu.org id=B74966.173479776511898 (code B ref 74966); Sat, 21 Dec 2024 16:17:01 +0000 Original-Received: (at 74966) by debbugs.gnu.org; 21 Dec 2024 16:16:05 +0000 Original-Received: from localhost ([127.0.0.1]:47409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tP297-00035q-A4 for submit@debbugs.gnu.org; Sat, 21 Dec 2024 11:16:05 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tP294-00035F-Pt for 74966@debbugs.gnu.org; Sat, 21 Dec 2024 11:16:03 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tP28z-0003Ch-Bv; Sat, 21 Dec 2024 11:15:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ripkoMyaHIW+NA23nqRngKFET/KRc31H6BD0vjcWByQ=; b=HQKQi3K6Lj/j0tWDIEfC BCS6n/ao7OVowRlMZDW1+5HS1KsHgo7G56zPpygmdTM2zswyMSmfQWRz8moKaMRk4CTXKmEzA3cdk lkaNE1RkB0SJtRG/jmJxNQ/mAUYNkeGEiPsv+J2pw1beIM1yxIOIDi+H4UiVzaeSFoY5CiV60tNnq sQvxF2CztqTrqYe+ZgS+j9qx5Ekw5frtnCpR7flCpwGHstq/xv1JRWS4bwQxqvXFgz7LC3RnUfUBF /89BFiZ9804rq0ZGlEI/yufGwPgfAGUe285UE+le1gu8xjWTrd/WE+BktIt8wGjg/7qDanCXXRHpG QtF322m8jzlMsA==; In-Reply-To: <874j2xhxp2.fsf@protonmail.com> (message from Pip Cet on Sat, 21 Dec 2024 15:18:43 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297537 Archived-At: > Date: Sat, 21 Dec 2024 15:18:43 +0000 > From: Pip Cet > Cc: Gerd Möllmann , Eli Zaretskii , acorallo@gnu.org, spd@toadstyle.org, 74966@debbugs.gnu.org > > "Stefan Monnier" writes: > > >>> `offset` here should be fixnum that gives the position of this docstring > >>> in the DOC file. And FUN should be a function for which we found > >> > >> Yes, but the nativecomp code assumes ->doc is an index into a > >> nativecomp'd subr's constant vector. > > > > Aha! > > > >> So we overwrite it with a docfile > >> index, access an out-of-bounds index and crash. > >> > >> I think the best thing to do is to use separate fields for the "offset" > >> doc and the "index" doc; or at least, the second best thing, after > >> removing the entire docfile hack. > > > > I think a much simpler change is to use the sign bit to distinguish indices > > into the constant vector from indices into the DOC file. > > And use one's-complement, I assume, to guard against some future weird > nativecomp change resulting in the index -0? :-) > > I really have no strong preference here. And I still want to hear from Andrea. It's his code, so the solution he prefers gets my vote.