From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: Adding parameters to windows Date: Wed, 04 Jun 2008 13:18:49 +0200 Message-ID: <86iqwp5tye.fsf@lola.quinscape.zz> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1212578347 12562 80.91.229.12 (4 Jun 2008 11:19:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Jun 2008 11:19:07 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: joakim@verona.se Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 04 13:19:48 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1K3r1u-0007oz-Eu for ged-emacs-devel@m.gmane.org; Wed, 04 Jun 2008 13:19:46 +0200 Original-Received: from localhost ([127.0.0.1]:52441 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K3r17-0005m9-Ov for ged-emacs-devel@m.gmane.org; Wed, 04 Jun 2008 07:18:57 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K3r14-0005lO-5t for emacs-devel@gnu.org; Wed, 04 Jun 2008 07:18:54 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K3r12-0005kV-RN for emacs-devel@gnu.org; Wed, 04 Jun 2008 07:18:53 -0400 Original-Received: from [199.232.76.173] (port=39367 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K3r12-0005kQ-HA for emacs-devel@gnu.org; Wed, 04 Jun 2008 07:18:52 -0400 Original-Received: from mail.quinscape.de ([212.29.44.217]:37901) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K3r12-0004ge-B0 for emacs-devel@gnu.org; Wed, 04 Jun 2008 07:18:52 -0400 Original-Received: (qmail-ldap/ctrl 1479 invoked from network); 4 Jun 2008 11:18:50 -0000 Original-Received: from unknown (HELO lola.quinscape.zz) ([10.0.3.43]) (envelope-sender ) by quinx.quinscape.de (qmail-ldap-1.03) with SMTP for ; 4 Jun 2008 11:18:50 -0000 Original-Received: by lola.quinscape.zz (Postfix, from userid 1001) id 7DB568EFF7; Wed, 4 Jun 2008 13:18:49 +0200 (CEST) In-Reply-To: (joakim@verona.se's message of "Wed, 04 Jun 2008 13:01:54 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-AntiVirus: checked by AntiVir MailGate (version: 2.1.3-2; AVE: 7.8.0.26; VDF: 7.0.4.140; host: quinx) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:98377 Archived-At: joakim@verona.se writes: > Stefan Monnier writes: > >> Your patch needs a few tweaks, e.g. to adjust it to the coding >> conventions: >> - The docstring of window-parameters is poor. >> E.g. the first line doesn't say anything. The second line is indented >> in the source, which looks bad when you do C-h f window-parameters. >> nil is an aliast as well, so there's no need to mention it explicitly. >> - I'd prefer to have `window-parameter' rather than `window-parameters'. >> - The docstring of set-window-parameter needs to start with a capital >> letter and end with a "." and should mention its arguments. >> Feel free to plagiarize set-frame-parameter. >> - The comment for window_parameters refers to `pin' and `group'. > > I've tried to adress your concerns in the attached patch. M-x checkdoc RET should help with getting stuff more coding convention compliant. -- David Kastrup