make check

make check

[Fabrice Popineau]

[-- Attachment #1: Type: text/plain, Size: 639 bytes --]

Hi,

Is there any reason why `make check' on the master branch stopped working ?
Or is it only me ?

make[1] : on entre dans le répertoire « /c/source/emacs/build-x64/test »
make[2] : on entre dans le répertoire « /c/source/emacs/build-x64/test »
make[2]: ***  Aucune règle pour fabriquer la cible «
../../emacs/test/lisp/abbrev-tests.log », nécessaire pour « check-maybe ».
Arrêt.
make[2] : on quitte le répertoire « /c/source/emacs/build-x64/test »

It is telling me that there is no rule for making the target
 ../../emacs/test/lisp/abbrev-tests.log

What am I missing ?

Thanks in advance,

Fabrice

[-- Attachment #2: Type: text/html, Size: 842 bytes --]

Re: make check

[Eli Zaretskii]

> From: Fabrice Popineau <fabrice.popineau@gmail.com>
> Date: Sun, 29 Nov 2015 23:34:19 +0100
> 
> Is there any reason why `make check' on the master branch stopped working ?

The directory structure there was changed.

> Or is it only me ?

I don't know, I work only in the emacs-25 branch lately.  Master can
wait.

Re: make check

[Phillip Lord]

Fabrice Popineau <fabrice.popineau@gmail.com> writes:
> Is there any reason why `make check' on the master branch stopped working ?
> Or is it only me ?
>
> make[1] : on entre dans le répertoire « /c/source/emacs/build-x64/test »
> make[2] : on entre dans le répertoire « /c/source/emacs/build-x64/test »
> make[2]: ***  Aucune règle pour fabriquer la cible «
> ../../emacs/test/lisp/abbrev-tests.log », nécessaire pour « check-maybe ».
> Arrêt.
> make[2] : on quitte le répertoire « /c/source/emacs/build-x64/test »
>
> It is telling me that there is no rule for making the target
>  ../../emacs/test/lisp/abbrev-tests.log
>
> What am I missing ?


Probably my commit 75336a29460752700e4e424a9c7aa932cc237689.

I changed the location of the test files and the Makefiles. It looks to
me like your Makefile has not been regenerated. Can you try ./configure?
Or if that fails a clean build?

Phil

Re: make check

[Stephen Leake]

Fabrice Popineau <fabrice.popineau@gmail.com> writes:

> Hi,
>
> Is there any reason why `make check' on the master branch stopped working ?
> Or is it only me ?
>
> make[1] : on entre dans le répertoire « /c/source/emacs/build-x64/test »
> make[2] : on entre dans le répertoire « /c/source/emacs/build-x64/test »
> make[2]: ***  Aucune règle pour fabriquer la cible «
> ../../emacs/test/lisp/abbrev-tests.log », nécessaire pour « check-maybe ».
> Arrêt.
> make[2] : on quitte le répertoire « /c/source/emacs/build-x64/test »
>
> It is telling me that there is no rule for making the target
>  ../../emacs/test/lisp/abbrev-tests.log
>
> What am I missing ?

I get a similar error.

It looks like you are building outside the source tree, as I do; I think
that is broken due to the recent changes in test directory structure.

I'll probably get to fixing it this week, if Phillip doesn't beat me to it.

-- 
-- Stephe

Re: make check

[Fabrice Popineau]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

2015-11-30 22:00 GMT+01:00 Stephen Leake <stephen_leake@stephe-leake.org>:

>
> It looks like you are building outside the source tree, as I do; I think
> that is broken due to the recent changes in test directory structure.
>

Yes.

>
> I'll probably get to fixing it this week, if Phillip doesn't beat me to it.
>
>
Thanks, I'll wait for it.

Best regards,

Fabrice

[-- Attachment #2: Type: text/html, Size: 987 bytes --]

Re: make check

[Phillip Lord]

Stephen Leake <stephen_leake@stephe-leake.org> writes:

> Fabrice Popineau <fabrice.popineau@gmail.com> writes:
>
>> Is there any reason why `make check' on the master branch stopped working ?
>> Or is it only me ?
>>
>> make[1] : on entre dans le répertoire « /c/source/emacs/build-x64/test »
>> make[2] : on entre dans le répertoire « /c/source/emacs/build-x64/test »
>> make[2]: ***  Aucune règle pour fabriquer la cible «
>> ../../emacs/test/lisp/abbrev-tests.log », nécessaire pour « check-maybe ».
>> Arrêt.
>> make[2] : on quitte le répertoire « /c/source/emacs/build-x64/test »
>>
>> It is telling me that there is no rule for making the target
>>  ../../emacs/test/lisp/abbrev-tests.log
>>
>> What am I missing ?
>
> I get a similar error.
>
> It looks like you are building outside the source tree, as I do; I think
> that is broken due to the recent changes in test directory structure.

Confused. How do I replicate this?

> I'll probably get to fixing it this week, if Phillip doesn't beat me to it.

I won't if I can't get it to break!

Phil

Re: make check

[Stephen Leake]

phillip.lord@russet.org.uk (Phillip Lord) writes:

>> It looks like you are building outside the source tree, as I do; I think
>> that is broken due to the recent changes in test directory structure.
>
> Confused. How do I replicate this?

git clone ... master

cd master

./autogen.sh

cd ..

mkdir master-build

cd master-build

../master/configure

make check


This allows using the same source tree for different builds with
different compilers/options. I often maintain a debug and no-debug build
for the branch I'm working on.

-- 
-- Stephe

Re: make check

[Phillip Lord]

Stephen Leake <stephen_leake@stephe-leake.org> writes:

> phillip.lord@russet.org.uk (Phillip Lord) writes:
>
>>> It looks like you are building outside the source tree, as I do; I think
>>> that is broken due to the recent changes in test directory structure.
>>
>> Confused. How do I replicate this?
>
> git clone ... master
>
> cd master
>
> ./autogen.sh
>
> cd ..
>
> mkdir master-build
>
> cd master-build
>
> ../master/configure
>
> make check
>
>
> This allows using the same source tree for different builds with
> different compilers/options. I often maintain a debug and no-debug build
> for the branch I'm working on.


Well, there you go, didn't know that you could do this.

I've just push a commit which (hopefully) fixes this and (hopefully)
doesn't break the more normal build.

Phil

Re: make check

[Stephen Leake]

phillip.lord@russet.org.uk (Phillip Lord) writes:

> Stephen Leake <stephen_leake@stephe-leake.org> writes:
>
>> phillip.lord@russet.org.uk (Phillip Lord) writes:
>>
>>>> It looks like you are building outside the source tree, as I do; I think
>>>> that is broken due to the recent changes in test directory structure.
>>>
>>> Confused. How do I replicate this?
>>
>> git clone ... master
>>
>> cd master
>>
>> ./autogen.sh
>>
>> cd ..
>>
>> mkdir master-build
>>
>> cd master-build
>>
>> ../master/configure
>>
>> make check
>>
>>
>> This allows using the same source tree for different builds with
>> different compilers/options. I often maintain a debug and no-debug build
>> for the branch I'm working on.
>
>
> Well, there you go, didn't know that you could do this.
>
> I've just push a commit which (hopefully) fixes this and (hopefully)
> doesn't break the more normal build.

I just updated master; 'make check' works for me.

Windows 8/MinGW, out of tree build.

-- 
-- Stephe

Re: make check

[Fabrice Popineau]

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

2015-12-02 21:27 GMT+01:00 Stephen Leake <stephen_leake@stephe-leake.org>:

> phillip.lord@russet.org.uk (Phillip Lord) writes:
>
> > Stephen Leake <stephen_leake@stephe-leake.org> writes:
> >
>
> > I've just push a commit which (hopefully) fixes this and (hopefully)
> > doesn't break the more normal build.
>
> I just updated master; 'make check' works for me.
>
> Windows 8/MinGW, out of tree build.
>
>
Great ! Thanks to Stephen and Phillip

Fabrice

[-- Attachment #2: Type: text/html, Size: 1075 bytes --]

Re: make check

[Phillip Lord]

Fabrice Popineau <fabrice.popineau@gmail.com> writes:

> 2015-12-02 21:27 GMT+01:00 Stephen Leake <stephen_leake@stephe-leake.org>:
>
>> phillip.lord@russet.org.uk (Phillip Lord) writes:
>>
>> > Stephen Leake <stephen_leake@stephe-leake.org> writes:
>> >
>>
>> > I've just push a commit which (hopefully) fixes this and (hopefully)
>> > doesn't break the more normal build.
>>
>> I just updated master; 'make check' works for me.
>>
>> Windows 8/MinGW, out of tree build.
>>
>>
> Great ! Thanks to Stephen and Phillip


Thanks for testing, and apologies for breaking your build.

Phil