* bug#14114: tango-dark: background highlighting not working properly
@ 2013-04-01 15:00 James Jong
2018-04-20 20:35 ` Nicolas Petton
0 siblings, 1 reply; 2+ messages in thread
From: James Jong @ 2013-04-01 15:00 UTC (permalink / raw)
To: 14114
[-- Attachment #1.1: Type: text/plain, Size: 619 bytes --]
The following code does not work well on the builtin `tango-dark` theme:
(custom-set-faces
'(region ((t (:inherit nil :background "RoyalBlue4"))))
'(highlight ((t (:inherit region :background "dark olive green"))))
'(hl-line ((t (:inherit highlight)))))
Region highlighting works well and respects foreground faces:
[image: Inline image 1]
but line highlighting doesn't:
[image: Inline image 2]
There is a thread on StackOverflow discussing this:
http://stackoverflow.com/questions/15733873/customizing-highlighting-faces-in-emacs-only-change-the-background-color
Any thoughts?
Thanks,
James
[-- Attachment #1.2: Type: text/html, Size: 1269 bytes --]
[-- Attachment #2: image.png --]
[-- Type: image/png, Size: 9825 bytes --]
[-- Attachment #3: image.png --]
[-- Type: image/png, Size: 14037 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#14114: tango-dark: background highlighting not working properly
2013-04-01 15:00 bug#14114: tango-dark: background highlighting not working properly James Jong
@ 2018-04-20 20:35 ` Nicolas Petton
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Petton @ 2018-04-20 20:35 UTC (permalink / raw)
To: 14114
tags 14114 notabug
close 14114
stop
James Jong <ribonucleico@gmail.com> writes:
> The following code does not work well on the builtin `tango-dark` theme:
>
> (custom-set-faces
> '(region ((t (:inherit nil :background "RoyalBlue4"))))
> '(highlight ((t (:inherit region :background "dark olive green"))))
> '(hl-line ((t (:inherit highlight)))))
>
> Region highlighting works well and respects foreground faces:
That's the region face, not the highlight face (for which tango-dark
sets a foreground color).
> Inline image 1
>
> but line highlighting doesn't:
>
> Inline image 2
I think that's to be expected, since the tango-dark theme sets a
foreground color for the highlight face:
`(highlight ((,class (:foreground ,alum-6 :background ,butter-2))))
So I'm closing this ticket.
Cheers,
Nico
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-20 20:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-01 15:00 bug#14114: tango-dark: background highlighting not working properly James Jong
2018-04-20 20:35 ` Nicolas Petton
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.