From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Nicolas Petton Newsgroups: gmane.emacs.bugs Subject: bug#14114: tango-dark: background highlighting not working properly Date: Fri, 20 Apr 2018 22:35:26 +0200 Message-ID: <86in8llipd.fsf@petton.fr> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1524256454 4968 195.159.176.226 (20 Apr 2018 20:34:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 20 Apr 2018 20:34:14 +0000 (UTC) To: 14114@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 20 22:34:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f9cjL-000136-H8 for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Apr 2018 22:34:03 +0200 Original-Received: from localhost ([::1]:59951 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9clQ-0003YX-Hc for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Apr 2018 16:36:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9clK-0003YC-ED for bug-gnu-emacs@gnu.org; Fri, 20 Apr 2018 16:36:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f9clG-0004kx-IG for bug-gnu-emacs@gnu.org; Fri, 20 Apr 2018 16:36:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54700) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f9clG-0004ke-Dy for bug-gnu-emacs@gnu.org; Fri, 20 Apr 2018 16:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f9clG-0002YT-54 for bug-gnu-emacs@gnu.org; Fri, 20 Apr 2018 16:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nicolas Petton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Apr 2018 20:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14114 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14114-submit@debbugs.gnu.org id=B14114.15242565379791 (code B ref 14114); Fri, 20 Apr 2018 20:36:02 +0000 Original-Received: (at 14114) by debbugs.gnu.org; 20 Apr 2018 20:35:37 +0000 Original-Received: from localhost ([127.0.0.1]:34364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f9ckr-0002Xr-C3 for submit@debbugs.gnu.org; Fri, 20 Apr 2018 16:35:37 -0400 Original-Received: from petton.fr ([89.234.186.68]:48932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f9ckq-0002Xf-HJ for 14114@debbugs.gnu.org; Fri, 20 Apr 2018 16:35:36 -0400 In-Reply-To: (James Jong's message of "Mon, 1 Apr 2013 11:00:50 -0400") DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=petton.fr; s=mail; t=1524256530; bh=1lE7t/yqDmo++OPZwoSUkRmhPfTrRH8Pdf7VqHRxefM=; h=From:To:Subject:References:Date:In-Reply-To:Message-ID:MIME-Version:Content-Type; b=sITfIwKSFzI0w+/K9qHGDINJ7SL17TvQvyTBz0T1gqYZs2ePE4zrHaBvr6hXzPL1ZjF3hGpnbybrNulH4ifVr+BvcZqQx1p5kTvBuSsR2V0LQGHNqB/3HJODdp9om5k8mRVGd5EjBtal+Iz0oYbW73rhRC+VP50u4uTOY6w9tVs= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145648 Archived-At: tags 14114 notabug close 14114 stop James Jong writes: > The following code does not work well on the builtin `tango-dark` theme: > > (custom-set-faces > '(region ((t (:inherit nil :background "RoyalBlue4")))) > '(highlight ((t (:inherit region :background "dark olive green")))) > '(hl-line ((t (:inherit highlight))))) > > Region highlighting works well and respects foreground faces: That's the region face, not the highlight face (for which tango-dark sets a foreground color). > Inline image 1 > > but line highlighting doesn't: > > Inline image 2 I think that's to be expected, since the tango-dark theme sets a foreground color for the highlight face: `(highlight ((,class (:foreground ,alum-6 :background ,butter-2)))) So I'm closing this ticket. Cheers, Nico