From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: bignum branch Date: Fri, 03 Aug 2018 10:01:59 +0100 Message-ID: <86in4resc8.fsf@gmail.com> References: <87o9fbbw1t.fsf@tromey.com> <86in5jdj49.fsf@gmail.com> <83wotxaiwi.fsf@gnu.org> <86k1pxmvmx.fsf@gmail.com> <87efg4a9xc.fsf@tromey.com> <87a7qr8cz7.fsf@tromey.com> <86tvoy3je9.fsf@gmail.com> <86bmb0vbxf.fsf@gmail.com> <87k1pnfcg1.fsf@tromey.com> <86sh4b1833.fsf@gmail.com> <861sbgz3dm.fsf@gmail.com> <83a7q4ufxp.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1533286918 16409 195.159.176.226 (3 Aug 2018 09:01:58 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 3 Aug 2018 09:01:58 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 03 11:01:54 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flVy5-00049G-O4 for ged-emacs-devel@m.gmane.org; Fri, 03 Aug 2018 11:01:53 +0200 Original-Received: from localhost ([::1]:49706 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flW0C-000618-GU for ged-emacs-devel@m.gmane.org; Fri, 03 Aug 2018 05:04:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flVyR-0005Tx-4w for emacs-devel@gnu.org; Fri, 03 Aug 2018 05:02:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1flVyM-0001Ji-6N for emacs-devel@gnu.org; Fri, 03 Aug 2018 05:02:15 -0400 Original-Received: from [195.159.176.226] (port=53706 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1flVyL-0001Fk-Tl for emacs-devel@gnu.org; Fri, 03 Aug 2018 05:02:10 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1flVwD-0002D3-Bm for emacs-devel@gnu.org; Fri, 03 Aug 2018 10:59:57 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 83 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:nhJUggAJzbunnudZndwjtvnyAA4= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228119 Archived-At: On Fri 03 Aug 2018, Eli Zaretskii wrote: >> From: Andy Moreton >> Date: Fri, 03 Aug 2018 01:43:17 +0100 >> >> After a lot more testing, I have a somewhat scruffy patch that works in >> the following emacs builds on unpatched master, and on patched bignum branch: >> - cygwin 64bit (LP64 model) >> - mingw64 msys2 32bit >> - mingw64 msys2 64bit (LLP64 model) I have now also tested - mingw64 msys2 32bit (wide int) > I believe your changes also cover the 32-bit MinGW build with wide ints. I expect so, but the build fails for 32bit MinGW builds on bignum branch with gettimeofday problems. I have a feeling that this has already been fixed on the master branch some time ago. >> The patch contains changes for: >> - fix CCL to ensure it uses 28biut codewords properly in bignum build >> - ensure make_number creates fixnums in LLP64 builds >> - fix bugnumcompare for LLP64 builds >> - fix arith_driver to handle markers correctly >> - fix arith_driver operations for LLP64 builds (more testing needed) >> - fix float_arith_driver to allow bignums >> - fix ash_lsh_impl to produce correct results in bignum build >> - fix NUMBERP to remove redundant BIGNUMP test (ensured by INTEGERP) > > Can you tell what is the following hunk about? > >> @@ -3414,7 +3473,7 @@ Markers are converted to integers. */) >> else >> { >> eassume (FIXNUMP (number)); >> - if (XINT (number) > MOST_POSITIVE_FIXNUM) >> + if (XINT (number) > MOST_NEGATIVE_FIXNUM) >> XSETINT (number, XINT (number) - 1); >> else >> { The updated Fadd1 checks if the old value is MOST_POSITIVE_FIXNUM before incrementing, as that would need a bignum result. This hunk in Fsub1 should check if the old value is MOST_NEGATIVE_FIXNUM before decrementing, as that would need a bignum result. > Also, this: > >> +(defun ccl-fixnum (code) >> + "Convert a CCL code word to a fixnum value." >> + (- (logxor (logand code #x0fffffff) #x08000000) #x08000000)) The CCL compiled codewords are 28bits, but the CCL implementation assumes that the codewords are sign-extended, so that data constants in the upper part of the codeword are signed. This function truncates a codeword to 28bits, and then sign extends the result to a fixnum. This ensures that the CCL compiler output is the same on master and bignum branches. > Btw, isn't it confusing that INTEGERP allows fixnums and bignums, but > XINT, XFASTINT, and XSETINT work only with fixnums? I envision quite > a few of potential bugs due to this semantic discrepancy, like the one > you just fixed: > >> - fix NUMBERP to remove redundant BIGNUMP test (ensured by INTEGERP) Indeed. NUMBERP could include rationals if emacs lisp ever acquires a full scheme-like numeric tower. > Should we have a different name for what is now INTEGERP? Like > WHOLENUMP, for example? INTEGERP seems natural enough, and WHOLENUMP would perhaps be confused with NATNUMP and FIXNATP. If anything, perhaps XINT, XFASTINT and XSETINT should be XFIXNUM, XFASTFIXNUM and XSETFIXNUM. AndyM