all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: 68691@debbugs.gnu.org, stefankangas@gmail.com,
	iarchivedmywholelife@gmail.com
Subject: bug#68691: 30.0.50; [WISHLIST] Make it easier to conform to desired commit message format
Date: Sun, 28 Jan 2024 09:42:51 +0200	[thread overview]
Message-ID: <86il3d6gzo.fsf@gnu.org> (raw)
In-Reply-To: <877cjtj4v9.fsf@yahoo.com> (message from Po Lu on Sun, 28 Jan 2024 15:26:18 +0800)

> From: Po Lu <luangruo@yahoo.com>
> Cc: Stefan Kangas <stefankangas@gmail.com>,  iarchivedmywholelife@gmail.com,
>   68691@debbugs.gnu.org
> Date: Sun, 28 Jan 2024 15:26:18 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > The script which generates ChangeLog files from Git logs is not
> > maintained by us, so this suggestion should go to the Gnulib folks, I
> > think.  If they succeed in generating the files and variables touched
> > by a given change mechanically, we can modify our conventions to ask
> > contributors to provide only the part that explains the change, its
> > rationale and important aspects, something that a program cannot
> > produce.
> 
> How is this different from expecting them to type C-c C-w in a vc-log
> buffer, and inserting this information?

It's one thing less to do.

> BTW, I wasn't proposing a commit hook that verifies the _contents_ of
> each commit message, only one that verifies the format of the messages.

It cannot.  Format could be okay, but will not describe all of the
changes, or describe them in a nonsensical way.

OTOH, is the format below OK or not?

     Merge from origin/emacs-29

     53481cc9546 Fix description of when "\xNNN" is considered a unibyte character
     1ef8b90ae06 Simplify imenu setup for {cmake,dockerfile}-ts-modes
     7338af9c986 ; * etc/PROBLEMS: Document that GnuPG 2.4.4 solves the EasyPG
     5483a1df99c Improve documentation of profiler commands
     fb4cf0ab46d ; Fix xref under Output Overrides in Elisp manual.
     aa6c24da61f Fix broken links to Freedesktop notifications spec
     14d68221d26 Fix nasty cut'n'waste error in Tramp
     51ca049608c Fix image-dired-tags-db-file void variable error
     c450eec07ff typescript-ts-mode: Skip test if tsx grammar missing
     9841ced147f ; Fix typos
     557ed9c0463 * admin/README: Document the run-codespell script.
     5701f96335c * admin/README: Fix entry on coccinelle subdirectory.
     1805f4bfd62 Add script admin/run-codespell and supporting files

Or this one:

    Revert "Fix typo in lispref 'Creating Strings' section"

    This reverts commit b825962ea840348bbde0c834ca398458a06fbb8b
    which was mistakenly installed in master instead of emacs-29.

Or this one:

    ; Update copyright years in more files

How do you distinguish between the above perfectly valid examples, and
some arbitrary text in a log message (which should be flagged as
nonconforming)?





  reply	other threads:[~2024-01-28  7:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24 17:20 bug#68691: 30.0.50; [WISHLIST] Make it easier to conform to desired commit message format No Wayman
2024-01-25 23:09 ` Stefan Kangas
2024-01-26  1:27   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-26 18:44     ` Jim Porter
2024-01-28  0:44     ` Stefan Kangas
2024-01-28  6:18       ` Eli Zaretskii
2024-01-28  7:21         ` Stefan Kangas
2024-01-28  7:33           ` Eli Zaretskii
2024-01-28  8:43           ` Juri Linkov
2024-01-26  7:18   ` Eli Zaretskii
2024-01-28  1:07     ` Stefan Kangas
2024-01-28  6:21       ` Eli Zaretskii
2024-01-28  7:26         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-28  7:42           ` Eli Zaretskii [this message]
2024-01-28  9:04             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-28  9:57               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86il3d6gzo.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=68691@debbugs.gnu.org \
    --cc=iarchivedmywholelife@gmail.com \
    --cc=luangruo@yahoo.com \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.