From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#69093: window-state-put doesn't update current buffer Date: Tue, 20 Feb 2024 09:40:11 +0200 Organization: LINKOV.NET Message-ID: <86il2jhb7o.fsf@mail.linkov.net> References: <86il2s6cva.fsf@mail.linkov.net> <2387160a-717f-4164-a0ad-cd831cabd60f@gmx.at> <86cysy1c7e.fsf@mail.linkov.net> <9bc224fd-265b-42a6-9315-9e1caa9e7172@gmx.at> <86msryw7gy.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40863"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 69093@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 20 09:00:00 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rcL2l-000AUC-31 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 20 Feb 2024 08:59:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rcL2U-0007Ow-Jy; Tue, 20 Feb 2024 02:59:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rcL2T-0007OT-Nv for bug-gnu-emacs@gnu.org; Tue, 20 Feb 2024 02:59:41 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rcL2T-0007dy-G9 for bug-gnu-emacs@gnu.org; Tue, 20 Feb 2024 02:59:41 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rcL2p-00065j-0E for bug-gnu-emacs@gnu.org; Tue, 20 Feb 2024 03:00:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Feb 2024 08:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69093 X-GNU-PR-Package: emacs Original-Received: via spool by 69093-submit@debbugs.gnu.org id=B69093.170841595823289 (code B ref 69093); Tue, 20 Feb 2024 08:00:02 +0000 Original-Received: (at 69093) by debbugs.gnu.org; 20 Feb 2024 07:59:18 +0000 Original-Received: from localhost ([127.0.0.1]:44229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcL26-00063Z-1J for submit@debbugs.gnu.org; Tue, 20 Feb 2024 02:59:18 -0500 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:47499) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcL23-00063J-LE for 69093@debbugs.gnu.org; Tue, 20 Feb 2024 02:59:16 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 5CC68C0004; Tue, 20 Feb 2024 07:58:47 +0000 (UTC) In-Reply-To: (martin rudalics's message of "Mon, 19 Feb 2024 10:43:00 +0100") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280313 Archived-At: >>> Or could you tell beforehand which buffer will be current after >>> >>> (let ((configuration (current-window-configuration))) >>> (pop-to-buffer "*Messages*" '((display-buffer-pop-up-frame))) >>> (set-window-configuration configuration) >>> (current-buffer)) >> >> Does this ambiguity exist only for multi-frame setups where >> a system window manager decides what frame to select afterwards? > > The system window manager here does only what Emacs tells it to do. But > note that multi-frame setups got more and more broken since Emacs 26 and > are maybe not used frequently nowadays. So you probably needn't give > them much attention in the first place. Ok, since it's impossible to fix 'window-state-put', let's narrow the scope just to the single-frame case in the caller 'tab-bar-select-tab': diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index d653f339fea..efca893fc16 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -1477,7 +1489,8 @@ tab-bar-select-tab ;; `window-state-put' fails when called in the minibuffer (when (window-minibuffer-p) (select-window (get-mru-window))) - (window-state-put ws nil 'safe))) + (window-state-put ws nil 'safe) + (set-buffer (window-buffer)))) ;; Select the minibuffer when it was active before switching tabs (when (and minibuffer-was-active (active-minibuffer-window))