From: Eli Zaretskii <eliz@gnu.org>
To: "Mattias Engdegård" <mattias.engdegard@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: master de6b1e1efb1: Replace XSETSYMBOL with make_lisp_symbol
Date: Sun, 25 Feb 2024 07:53:06 +0200 [thread overview]
Message-ID: <86il2dxf7h.fsf@gnu.org> (raw)
In-Reply-To: <D0AB4A35-8764-430D-B9DE-728A64BBB196@gmail.com> (message from Mattias Engdegård on Sat, 24 Feb 2024 21:54:39 +0100)
> From: Mattias Engdegård <mattias.engdegard@gmail.com>
> Date: Sat, 24 Feb 2024 21:54:39 +0100
> Cc: emacs-devel@gnu.org
>
> 24 feb. 2024 kl. 19.23 skrev Eli Zaretskii <eliz@gnu.org>:
>
> > Why is this a good idea? We have those XSET* macros in Emacs since
> > time immemoriam; why remove them now?
>
> There is no longer any reason for having those macros now, nor has there been for a very long time.
Maybe not for you, but for those like me who are hacking on Emacs for
many years, there is a significant reason: the familiarity with the
Emacs sources and the knowledge of how certain things are done in
Emacs that is burnt into our muscle memory.
> More in detail, `a=f(b)` is inherently simpler, more transparent, concise and composable than `X(a,b)`. It is obvious to the reader that it's an assignment and that `a` is only modified, `b` not at all and is only evaluated once. There is no need for an assignment at all if the result is used elsewhere.
This is your stylistic preference, which I don't share, probably
because I'm biased by many years of staring on Emacs code that uses
such macros everywhere.
So unless you can point out some serious disadvantage of these macros,
I think we should revert that commit, and refrain from doing similar
changes with other XSET* macros we have, at least until the last of us
dinosaurs leave Emacs development. TIA.
next prev parent reply other threads:[~2024-02-25 5:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-24 18:23 master de6b1e1efb1: Replace XSETSYMBOL with make_lisp_symbol Eli Zaretskii
2024-02-24 20:54 ` Mattias Engdegård
2024-02-25 5:53 ` Eli Zaretskii [this message]
2024-03-02 21:57 ` Stefan Monnier via Emacs development discussions.
2024-03-03 6:52 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86il2dxf7h.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=mattias.engdegard@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.