From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70068: [PATCH] Don't warn about lexical binding in lisp-interaction-mode Date: Tue, 09 Apr 2024 14:24:42 +0300 Message-ID: <86il0qwzgl.fsf@gnu.org> References: <2FB192D4-40E7-4327-BC0E-62674C2C1A03@gmail.com> <8734s2cnv7.fsf@posteo.net> <6246FE18-7962-40F0-807F-1ABE8F9D2A25@gmail.com> <93A70615-823B-4369-BE17-128EEA430ADA@gmail.com> <87y19o2ubc.fsf@posteo.net> <8634rwytcq.fsf@gnu.org> <7FFED798-8839-43D4-9629-E087A6DFE0D0@gmail.com> <86msq2x3r4.fsf@gnu.org> <963F9A52-9903-426A-A505-2CF7F7F315F8@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4875"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, monnier@iro.umontreal.ca, 70068@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 09 13:26:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ru9cI-00013v-MW for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Apr 2024 13:26:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ru9bz-0007zR-84; Tue, 09 Apr 2024 07:26:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ru9bv-0007yT-AM for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2024 07:25:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ru9bv-0001AU-1Y for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2024 07:25:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ru9c3-0000tv-0A for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2024 07:26:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Apr 2024 11:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70068-submit@debbugs.gnu.org id=B70068.17126619033367 (code B ref 70068); Tue, 09 Apr 2024 11:26:02 +0000 Original-Received: (at 70068) by debbugs.gnu.org; 9 Apr 2024 11:25:03 +0000 Original-Received: from localhost ([127.0.0.1]:48506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ru9b4-0000sE-IL for submit@debbugs.gnu.org; Tue, 09 Apr 2024 07:25:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ru9b2-0000rZ-1b for 70068@debbugs.gnu.org; Tue, 09 Apr 2024 07:25:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ru9ao-0000mw-Ee; Tue, 09 Apr 2024 07:24:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=VbKMzSy5tEK09H2zYrYsrbks6E6kbor4aUS7CGhFCBY=; b=gNW3MZsjAxMqI7ZaRbDL T6P1SQs+sVK2zzReEUeKTNsSdQlbg567WCuLZgL6NUWPUC5BPWGwjy1bNNggtdMAe3S2R9bfyXDhn xOiE7Wr2AFxrz77TdSxBfRJY6eLI+dSBk1E8ukr+nyNTjLe8/RFVHE0dsk3xChVNp207inoTP+3fQ yD0sGlL6/NKfGx/Klhy2ZWKb6tSM0I4JlckdnUZKWVMH+4Wp39XJxOjv+g0fUQRfk1RL7o8BwnLx6 YY5mfNUdvqWYll6uo0OVf4q+/tBL5DOZVCmC2zKFi+vCBqEGsPiZ8LiEut42ePelVeF0O2VlAn/Ok BjOzTpM018MKOw==; In-Reply-To: <963F9A52-9903-426A-A505-2CF7F7F315F8@gmail.com> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Tue, 9 Apr 2024 12:45:18 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282987 Archived-At: > From: Mattias Engdegård > Date: Tue, 9 Apr 2024 12:45:18 +0200 > Cc: monnier@iro.umontreal.ca, > philipk@posteo.net, > 70068@debbugs.gnu.org > > 9 apr. 2024 kl. 11.51 skrev Eli Zaretskii : > > >> Looks like option 3 won. Actually I implemented option 3' which is like 3 but checks the mode instead of lexical-binding, on the grounds that a user who damages his lexical cookie by mistake wants to be reminded of it as soon as possible. > > > > That's not what I see in the changes you installed on master. > > Then I made a mistake, but I don't see where. The intent is to have flymake add the argument > > --eval (setq bytecomp--inhibit-lexical-cookie-warning t) > > if (derived-mode-p 'lisp-interaction-mode) is true, and then make the warning conditional on that variable. Doesn't it work? Ah, okay, then it's my misunderstanding: I saw the (local-variable-p 'lexical-binding) test and thought you intended to replace that with a mode test. Apologies.