From: Eli Zaretskii <eliz@gnu.org>
To: "Mattias Engdegård" <mattias.engdegard@gmail.com>
Cc: philipk@posteo.net, monnier@iro.umontreal.ca, 70068@debbugs.gnu.org
Subject: bug#70068: [PATCH] Don't warn about lexical binding in lisp-interaction-mode
Date: Tue, 09 Apr 2024 14:24:42 +0300 [thread overview]
Message-ID: <86il0qwzgl.fsf@gnu.org> (raw)
In-Reply-To: <963F9A52-9903-426A-A505-2CF7F7F315F8@gmail.com> (message from Mattias Engdegård on Tue, 9 Apr 2024 12:45:18 +0200)
> From: Mattias Engdegård <mattias.engdegard@gmail.com>
> Date: Tue, 9 Apr 2024 12:45:18 +0200
> Cc: monnier@iro.umontreal.ca,
> philipk@posteo.net,
> 70068@debbugs.gnu.org
>
> 9 apr. 2024 kl. 11.51 skrev Eli Zaretskii <eliz@gnu.org>:
>
> >> Looks like option 3 won. Actually I implemented option 3' which is like 3 but checks the mode instead of lexical-binding, on the grounds that a user who damages his lexical cookie by mistake wants to be reminded of it as soon as possible.
> >
> > That's not what I see in the changes you installed on master.
>
> Then I made a mistake, but I don't see where. The intent is to have flymake add the argument
>
> --eval (setq bytecomp--inhibit-lexical-cookie-warning t)
>
> if (derived-mode-p 'lisp-interaction-mode) is true, and then make the warning conditional on that variable. Doesn't it work?
Ah, okay, then it's my misunderstanding: I saw the
(local-variable-p 'lexical-binding) test and thought you
intended to replace that with a mode test. Apologies.
next prev parent reply other threads:[~2024-04-09 11:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 11:31 bug#70068: [PATCH] Don't warn about lexical binding in lisp-interaction-mode Philip Kaludercic
2024-03-30 6:57 ` Eli Zaretskii
2024-03-30 11:07 ` Philip Kaludercic
2024-03-30 12:54 ` Eli Zaretskii
2024-04-01 5:27 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-03 8:52 ` Philip Kaludercic
2024-04-03 9:35 ` Mattias Engdegård
2024-04-03 18:17 ` Philip Kaludercic
2024-04-03 19:07 ` Mattias Engdegård
2024-04-06 10:14 ` Mattias Engdegård
2024-04-08 7:21 ` Philip Kaludercic
2024-04-08 11:41 ` Eli Zaretskii
2024-04-08 12:02 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-09 8:57 ` Mattias Engdegård
2024-04-09 9:51 ` Eli Zaretskii
2024-04-09 10:45 ` Mattias Engdegård
2024-04-09 11:24 ` Eli Zaretskii [this message]
2024-04-09 13:35 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-09 13:42 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86il0qwzgl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=70068@debbugs.gnu.org \
--cc=mattias.engdegard@gmail.com \
--cc=monnier@iro.umontreal.ca \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.