From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs Date: Thu, 06 Jun 2024 08:45:06 +0300 Message-ID: <86ikymipzx.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13544"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71386@debbugs.gnu.org To: Al Haji-Ali , Juri Linkov , martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 06 08:03:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sF6DR-0003CH-Fx for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Jun 2024 08:03:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sF6D4-0001UP-Qu; Thu, 06 Jun 2024 02:02:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sF6D2-0001TX-Ef for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2024 02:02:48 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sF6D2-0005MA-5V for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2024 02:02:48 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sF6DG-00009y-I9 for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2024 02:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Jun 2024 06:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71386 X-GNU-PR-Package: emacs Original-Received: via spool by 71386-submit@debbugs.gnu.org id=B71386.1717653778588 (code B ref 71386); Thu, 06 Jun 2024 06:03:02 +0000 Original-Received: (at 71386) by debbugs.gnu.org; 6 Jun 2024 06:02:58 +0000 Original-Received: from localhost ([127.0.0.1]:40577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sF6DB-00009P-Mw for submit@debbugs.gnu.org; Thu, 06 Jun 2024 02:02:58 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sF6D7-00008r-RN for 71386@debbugs.gnu.org; Thu, 06 Jun 2024 02:02:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sF5vy-00025A-18; Thu, 06 Jun 2024 01:45:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=73z2TLx+Qy1OJuS7f5DKJA3M+JviVVmWHxCOi0m4N+A=; b=d2X8VnZCpc+s 25Sv6nZ+S+Oci+nNRx/bImPzgNC7AGZzBNG2WSYNI80DoogcQFV0iqFS8FYnoC+84ekoEQdyFstdA phntBtMMvXZZcuxkeouSed90NtI5Nbe4/xylzGW/fUsTFBVKryEl/HsyLq2gDriQZsYGuBaA18tDx Fy8yEI1Nr/tCpdycpqNN506KCpF+5nHyb0SlMAYsjC7rsOeAuMFexYaWnmmtasS/sADp1gkvHqHGu PzTtLhErwj2JrbKtT2IR4O7D4W5rgjCFeyP6YyUD7oMfT5FEDuJYPNoFOWQhxwcoejvxR4otRpYyH VAtqD72VVi4fAloI09sUnQ==; In-Reply-To: (message from Al Haji-Ali on Thu, 06 Jun 2024 00:44:28 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286656 Archived-At: > From: Al Haji-Ali > Date: Thu, 06 Jun 2024 00:44:28 +0100 > > > If I open a frame with multiple tabs, and one of the tabs has a dedicated window, then kill the buffer with the dedicated window, the frame is deleted along with its tabs. > > I understand that this is the documented behaviour, however my expectation is that the tab should be deleted but the frame should stay when other tabs are available, similar to how the frame is not deleted if other windows are visible. I'm not sure I agree with you. Tabs are just saved frame configurations, they are not real windows. If we make this behavior dependent on tab-bar-mode, we basically introduce an incompatible behavior change in this particular case, which people and Lisp programs out there might not expect or like. I'm adding Juri and Martin to this discussion. > The following code illustrates the issue: > > ,---- > | (with-selected-frame (make-frame) > | (tab-bar-mode) > | (switch-to-buffer (generate-new-buffer "test")) > | (tab-bar-new-tab) > | (switch-to-buffer (generate-new-buffer "test2")) > | (set-window-dedicated-p (selected-window) t) > | ;;(kill-buffer) ;; Kill buffer manually to see the issue > | ) > `---- > > I am unable to test this on Emacs 30, but I checked the source code and `window--delete` in `window.el`, which is the function that I think should be changed, seems to do the same as in Emacs 29.1. Emacs 30 behaves the same in this regard.