From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs Date: Sun, 09 Jun 2024 21:16:34 +0300 Message-ID: <86ikyi9e2l.fsf@gnu.org> References: <86ikymipzx.fsf@gnu.org> <7269c7c4-86a1-44bf-8d5d-378c3584027a@gmx.at> <86zfrx8ec0.fsf@mail.linkov.net> <8561a63a-66d3-44cd-872f-73d26af7edbe@gmx.at> <86msnw4qm4.fsf@mail.linkov.net> <86y17gej2x.fsf@gnu.org> <86y17gmxdg.fsf@mail.linkov.net> <868qzehxie.fsf@mail.linkov.net> <86msnu9fhg.fsf@gnu.org> <86zfruc7qh.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40213"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rudalics@gmx.at, abdo.haji.ali@gmail.com, 71386@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 09 20:41:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sGNTd-000AFn-Tf for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 09 Jun 2024 20:41:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sGNTD-0002Iz-1u; Sun, 09 Jun 2024 14:40:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGNTC-0002If-5K for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2024 14:40:46 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sGNTB-0002X1-TT for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2024 14:40:45 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sGNTS-0000IR-Cd for bug-gnu-emacs@gnu.org; Sun, 09 Jun 2024 14:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Jun 2024 18:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71386 X-GNU-PR-Package: emacs Original-Received: via spool by 71386-submit@debbugs.gnu.org id=B71386.1717958424963 (code B ref 71386); Sun, 09 Jun 2024 18:41:02 +0000 Original-Received: (at 71386) by debbugs.gnu.org; 9 Jun 2024 18:40:24 +0000 Original-Received: from localhost ([127.0.0.1]:54160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGNSo-0000FJ-OS for submit@debbugs.gnu.org; Sun, 09 Jun 2024 14:40:23 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sGNHk-0008A3-Ca for 71386@debbugs.gnu.org; Sun, 09 Jun 2024 14:28:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGN5q-0006RD-Dx; Sun, 09 Jun 2024 14:16:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dqtwR/+M8SXApgMidazdw480SHPS98BKcgKF7z92khM=; b=GED+zN0O2SGl DcMX1EJTrq/lI5GhzPbUvpBak6CbYDem7k1cAcCpJSKAhMnwOMo8ibUW5QJsUCcxIEhF0wRCPJ/1g 66KCiSAZrFaOJAifKKKs+b1x1te4965Q0aV2xxjVa/fVx+pLCh9HloiSFm5MIAoXULIQ+eUSfOkZD vx5NrP6/SBHT9aybKAzasWsEXmmjfCfICO0H5Ad3bv5b0+QPdy4yKHS16EQiBF5PL+JyR1LTZuhlT RQ62rj/5pdgGoGPGQ3XbH2p0u4JiPW5QQ2cJosy0BQMZh40ugqcRWMaZCA6Ig1MW6pVMQl1N6zuj4 QUt/W7eki1O/DvOmOtBYYA==; In-Reply-To: <86zfruc7qh.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 09 Jun 2024 20:58:10 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286964 Archived-At: > From: Juri Linkov > Cc: abdo.haji.ali@gmail.com, rudalics@gmx.at, 71386@debbugs.gnu.org > Date: Sun, 09 Jun 2024 20:58:10 +0300 > > >> +(defun tab-bar-window-delete-frame (frame _kill) > >> + "Whether FRAME should be deleted when other tabs are available for that frame. > >> +Instead of deleting the frame, close the current tab. > > > > The first and the second sentences contradict each other. The first > > implies that this is a predicate which returns a boolean, whereas the > > second says that it closes the tab and negtlets to say anything about > > the return value. > > > >> +(defvar window-delete-frame-functions nil > >> + "Don't delete frame when one of functions returns t. > >> +Each of functions is called with two arguments: FRAME and KILL. > >> +The function can perform an action instead of deleting the frame.") > > > > This doc string should at least explain what is the KILL argument and > > its meaning. > > I tried to improve these doc strings: Thanks, they are more clear now. But one point still needs clarification, IMO: > +(defvar window-delete-frame-functions nil > + "A list of functions to handle the frame deletion. > +Each of functions is called with two arguments: FRAME and KILL where > +KILL means the buffer shown in window will be killed. When one of functions So KILL is a boolean, and if it's non-nil, it means the buffer will be killed? If so, will the buffer be killed even if the function returns non-nil?