From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71863: 31.0.50; Wrong argument type for treesit-query-range in treesit-update-ranges Date: Sun, 07 Jul 2024 08:35:21 +0300 Message-ID: <86ikxh3gti.fsf@gnu.org> References: <86y16e530r.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4818"; mail-complaints-to="usenet@ciao.gmane.io" Cc: noah.v.peart@gmail.com, 71863@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 07 07:38:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sQKbO-00012M-8s for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Jul 2024 07:38:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sQKb2-0005WH-Oe; Sun, 07 Jul 2024 01:38:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQKb1-0005W8-HM for bug-gnu-emacs@gnu.org; Sun, 07 Jul 2024 01:37:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sQKb0-0005dT-Lz for bug-gnu-emacs@gnu.org; Sun, 07 Jul 2024 01:37:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sQKb4-0000WJ-Fm for bug-gnu-emacs@gnu.org; Sun, 07 Jul 2024 01:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Jul 2024 05:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71863 X-GNU-PR-Package: emacs Original-Received: via spool by 71863-submit@debbugs.gnu.org id=B71863.17203306661973 (code B ref 71863); Sun, 07 Jul 2024 05:38:02 +0000 Original-Received: (at 71863) by debbugs.gnu.org; 7 Jul 2024 05:37:46 +0000 Original-Received: from localhost ([127.0.0.1]:47088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQKan-0000Vk-Sk for submit@debbugs.gnu.org; Sun, 07 Jul 2024 01:37:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQKam-0000VZ-DU for 71863@debbugs.gnu.org; Sun, 07 Jul 2024 01:37:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQKYV-0004w9-Iz; Sun, 07 Jul 2024 01:35:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=YBS2lE0o9/fnUS8m1WcX0rV+M8HsBQObmF4Gd36KCgA=; b=JvTCxcV5Z2z1BhQCAK/+ dtdrmMM0eVb50zU0eFqK38HEaX6HZ7ULbXNLgnXk78iAstgsyBPFx2mG6zezQjHVWXhskKLD/QWkl FMnAIg4HEjc6umrazJRxU+GMhycQ/TvGLswCDZhEl1uIMJBmxFd20fsKmwtzc3pBdRDphYvvqlYAb pV/dF/ZuqKzltTVWR8AjXf1P5ZU6/BA9oV+6BBEQz88Hlxg0oeFiN4CDuxKuoEvPOb/n0C1gHTD24 5EspsIg6HRQeFZ/0mUJhFFg6pXg4mDi3NTrou8eAGiCwW/CNv01lUvTEQQjPpUKlNvQmGFF03PDCx rdnNrOTIuvt8JA==; In-Reply-To: (message from Yuan Fu on Sat, 6 Jul 2024 13:50:10 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288539 Archived-At: > From: Yuan Fu > Date: Sat, 6 Jul 2024 13:50:10 -0700 > Cc: Noah Peart , > 71863@debbugs.gnu.org > > > > > On Jul 6, 2024, at 1:38 AM, Eli Zaretskii wrote: > > > >> From: Noah Peart > >> Date: Sun, 30 Jun 2024 16:12:06 -0400 > >> > >> I just noticed this after building latest Emacs. In > >> `treesit-update-ranges`, during redisplay, the first argument to > >> `treesit-query-range` is a tree-sitter language symbol, not a node. > >> > >> At treesit.el:760 > >> > >> (let* ((host-lang (treesit-query-language query)) > >> (parser (treesit-parser-create language)) > >> (old-ranges (treesit-parser-included-ranges parser)) > >>>>> host-lang isnt a node > >> (new-ranges (treesit-query-range > >> host-lang query beg end offset)) > >> > >> This causes a an error in modes that have set `treesit-range-settings` > >> eg., `js-ts-mode`: > >> > >>> Error muted by safe_call: (treesit--font-lock-mark-ranges-to-fontify > >>> ((1 . 940)) #) signaled > >>> (wrong-type-argument treesit-node-p javascript) Error during > >>> redisplay: (jit-lock-function 1) signaled (wrong-type-argument > >>> treesit-node-p javascript) > >> > >> And in `syntax-propertize-function`, for example in `ruby-ts-mode`, > >> > >>> QuitError muted by safe_call: (internal--syntax-propertize 46) > >>> signaled (wrong-type-argument treesit-node-p ruby) > > > > Yuan, could you please look into this issue? > > This is a bug I introduced on emacs-30 and later fixed. So once emacs-30 is merged into master the issue should go away. Sorry for the trouble :-( When did you fix it on emacs-30? The merges to master happen very frequently lately; the last one was yesterday. Could it be that this is already fixed?