From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] EWW - use revert--buffer-function to reload, and allow reload in eww-list-buffer Date: Sat, 14 Sep 2024 10:32:14 +0300 Message-ID: <86ikuyitc1.fsf@gnu.org> References: <86jzgg5pgv.fsf@gnu.org> <86frqunwgu.fsf@gnu.org> <8d5956f2-545d-470d-8f61-59670570b868@app.fastmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17785"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, emacs-devel@gnu.org To: =?iso-8859-1?Q?Sebasti=E1n_Mon=EDa?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 14 09:32:47 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1spNGx-0004Ts-3P for ged-emacs-devel@m.gmane-mx.org; Sat, 14 Sep 2024 09:32:47 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1spNGW-0002c6-Jo; Sat, 14 Sep 2024 03:32:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spNGU-0002br-L0 for emacs-devel@gnu.org; Sat, 14 Sep 2024 03:32:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1spNGU-0000Fa-AR; Sat, 14 Sep 2024 03:32:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=HyOqAHsSilOOhhm2Ogwyam0BG3sAEGU8oWNR2WlL9Og=; b=MCgkM/lLQIer/3IBVaev kkSclCueAEpnWOkKSSIevUsNdALuaRoTOT327pFCKqu33tlzSsQo/R9SUyKvGwZjBA7ZkdF0upbcB v1HJLC74S8QfR3af0tBu2dHl6L8jygNAQ+/+wdaxCfi70Vai3C9DCQ3ayxADqeB4TdBzHuW3xYmHW tDlPbodxOwAU2evIXliNUZQASKUQ3sH/2EsMAAH+MoHCaRZ3D2LjIJ7S8VZJnpd8wOyAz7UHW2Dg+ 9DpgBTSHsvtvtt9WVqmooVttTy/GcJGs8cmsJLRD+3smqHET9ZMf+326FwwBXjgU6wdp9NzVF8xnL XQ2F/k+8nuq0Lg==; In-Reply-To: <8d5956f2-545d-470d-8f61-59670570b868@app.fastmail.com> (message from =?iso-8859-1?Q?Sebasti=E1n_Mon=EDa?= on Fri, 30 Aug 2024 16:01:00 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323605 Archived-At: > Date: Fri, 30 Aug 2024 16:01:00 -0400 > From: Sebastián Monía > Cc: emacs-devel@gnu.org > > Hi Jim, > > Thanks for your review. > > On Sat, Aug 24, 2024, at 1:27 PM, Jim Porter wrote: > > So I think we'd want some new function like 'eww--do-list-buffers' that > > takes the code from 'eww-list-buffers' that actually writes out the text > > (i.e. the 'let' form starting with '(inhibit-read-only t)'). Then have > > 'eww-list-buffers' call that, and set 'revert-buffer-function' to > > 'eww--do-list-buffers'. Or something like that anyway... > > You are entirely correct, will provide an updated patch whenever I get a chance. Any progress there?