From: Eli Zaretskii <eliz@gnu.org>
To: Sean Whitton <spwhitton@spwhitton.name>
Cc: dgutov@yandex.ru, 73407@debbugs.gnu.org, juri@linkov.net
Subject: bug#73407: 31.0.50; Add diff-discard-hunk
Date: Tue, 24 Sep 2024 15:21:42 +0300 [thread overview]
Message-ID: <86ikuldyy1.fsf@gnu.org> (raw)
In-Reply-To: <87y13hmold.fsf@zephyr.silentflame.com> (message from Sean Whitton on Tue, 24 Sep 2024 09:40:30 +0100)
> Cc: 73407@debbugs.gnu.org
> From: Sean Whitton <spwhitton@spwhitton.name>
> Date: Tue, 24 Sep 2024 09:40:30 +0100
>
> +@findex diff-discard-hunk
> +@item C-c C-k
> +Reverse-apply this hunk to the target file, and then kill it
> +(@code{diff-discard-hunk}). Unless the buffer visiting the target file
> +was already modified, save it.
We should come up with a better name for this command.
diff-discard-hunk tells me the command will discard the hunk, but says
nothing about applying it, let alone reverse-applying it. How about
diff-revert-hunk, or maybe diff-revert-and-discard?
> +This command is useful in buffers generated by @w{@kbd{C-x v =}} and
> +@w{@kbd{C-x v D}} (@pxref{Old Revisions}). You can use this command to
> +remove hunks you never intend to commit, such as temporary debug prints,
> +and the like.
This text could also use some clarification: "remove hunks you never
intended to commit" only hints on what it actually does. A better
description would be something like "undo some of the changes you made
that you didn't intend". I wouldn't mention "commit" at all, since
AFAIU this command is not specific to VC and doesn't require a VCS.
> - (message "%d hunks failed; no buffers changed" failures)))))
> + (message "%d hunks failed; no buffers changed" failures)
> + failures))))
This comes from existing text, but still: what does the above say when
there's only 1 failure? does it say "1 hunks failed"? If so, can we
improve the handling of singular/plural here?
Thanks.
next prev parent reply other threads:[~2024-09-24 12:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-21 10:19 bug#73407: 31.0.50; Add diff-discard-hunk Sean Whitton
2024-09-23 22:52 ` Dmitry Gutov
2024-09-24 7:53 ` Sean Whitton
2024-09-24 12:27 ` Dmitry Gutov
2024-09-24 15:48 ` Sean Whitton
2024-09-24 6:36 ` Juri Linkov
2024-09-24 8:07 ` Sean Whitton
2024-09-24 8:40 ` Sean Whitton
2024-09-24 8:42 ` Sean Whitton
2024-09-24 12:22 ` Dmitry Gutov
2024-09-24 12:21 ` Eli Zaretskii [this message]
2024-09-24 12:23 ` Dmitry Gutov
2024-09-24 14:33 ` Óscar Fuentes
2024-09-24 15:43 ` bug#73407: [PATCH v4] " Sean Whitton
2024-09-24 16:59 ` Juri Linkov
2024-09-24 17:56 ` Sean Whitton
2024-09-24 18:07 ` Eli Zaretskii
2024-09-25 6:36 ` Sean Whitton
2024-09-25 12:17 ` Eli Zaretskii
2024-09-25 19:33 ` Sean Whitton
2024-09-24 12:20 ` Dmitry Gutov
2024-09-26 10:52 ` bug#73407: 31.0.50; Add diff-revert-and-kill-hunk Sean Whitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ikuldyy1.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=73407@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=juri@linkov.net \
--cc=spwhitton@spwhitton.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.